Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 20 23:01
    romaninsh review_requested #871
  • Jan 20 23:01
    romaninsh labeled #871
  • Jan 20 23:01
    romaninsh unlabeled #871
  • Jan 20 22:57

    github-actions[bot] on 2.0.0

    (compare)

  • Jan 20 22:57
    codecov[bot] commented #28
  • Jan 20 22:56
    romaninsh edited #28
  • Jan 20 22:56
    romaninsh edited #28
  • Jan 20 22:56
    romaninsh edited #28
  • Jan 20 22:56

    romaninsh on 2.0.0

    (compare)

  • Jan 20 22:56

    romaninsh on master

    Releasing 2.0.0 into master (#2… (compare)

  • Jan 20 22:56
    romaninsh closed #28
  • Jan 20 22:56
    codecov[bot] commented #28
  • Jan 20 22:56
    github-actions[bot] review_requested #28
  • Jan 20 22:56
    github-actions[bot] assigned #28
  • Jan 20 22:56
    github-actions[bot] opened #28
  • Jan 20 22:56

    github-actions[bot] on 2.0.0

    Setting release dependencies (compare)

  • Jan 20 22:55

    romaninsh on 2.0.0

    (compare)

  • Jan 20 22:55

    romaninsh on 2.0.0

    (compare)

  • Jan 20 22:55

    romaninsh on develop

    fix (compare)

  • Jan 20 22:53

    github-actions[bot] on 2.0.0

    Setting release dependencies (compare)

PhilippGrashoff
@PhilippGrashoff
but will join
Romans Malinovskis
@romaninsh
ah
"15-person video calls let you host daily stand-ups, share docs, and check in with team members all over the world. Learn more about paid plans"
discord is probably unlimited.
PhilippGrashoff
@PhilippGrashoff
how is the discord channel called? Cant find it using "atk" or "agile" as search
Romans Malinovskis
@romaninsh
i think you need a link there.
let me check.
This message was deleted
PhilippGrashoff
@PhilippGrashoff
am in there
Romans Malinovskis
@romaninsh
oh it also allows to present.
cool!
PhilippGrashoff
@PhilippGrashoff
discord?
Romans Malinovskis
@romaninsh
Nice, we figured out how to hold meetings on Discord!
as soon as i figure out "traefik" setup for kubernetes, I'm setting up a basic app for redirects and we can then have the atk4 discord shortlink.
PhilippGrashoff
@PhilippGrashoff
yes discord was very easy to use as meeting software with screen sharing
but it only works with the discord Software installed, not via browser
Svetlozar Kondakov
@skondakov

svetlozar, like this:

if($_GET['extra_reload_arg']){ 
  $view->js(true, $js);
}

Ah thanks man!

Thomas Stokkeland
@stokkeland
data 1.7.. one of my $model->save() appears to just do a die() or something.. no errors/error logs that i can find.. anything known?
Thomas Stokkeland
@stokkeland
found it... since i am in a modal o dont get any output. model throws a validation exception on the model. on a field i did not change.. interresting
PhilippGrashoff
@PhilippGrashoff
just wondering: I see there are DropDown classes in atk4/login. Don't really get why they are there, are atk4\ui already has a DropDown class. Shouldnt we try to avoid duplicate code along the repos?
Another thought regarding this: As UI 2.0 is released, that would be a good time to delete AutoComplete FormField. Lookup was planned to replace it, so doing this in v2 would be sensible
Francesco Danti
@abbadon1334
@PhilippGrashoff agree
PhilippGrashoff
@PhilippGrashoff
ah regarding dropdown, I see it extends ui/Dropdown
@abbadon1334 you were the one suggesting to move UI code from atk54\login?
Francesco Danti
@abbadon1334
@PhilippGrashoff sorry i read your message without look at the code, my fault. I check the code in atk login and is ok, it extends dropdown for a specific behaviour.
imho nothing needs to be moved
PhilippGrashoff
@PhilippGrashoff
Menat splitting login data and ui in general
Thomas Stokkeland
@stokkeland
ui pre 2.0 -- when a form is submitted but required fields or validation is hit - if the form spans more than visible screen, there is no scroll-up ability is there? or a way to put a generic alert on bottom that there is missing requirements above?
PhilippGrashoff
@PhilippGrashoff
meeting tonight?
Thomas Stokkeland
@stokkeland
as far as i can tell - the form validation based on model/ui info happens before onSubmit is called - is there a way to intercept or hook to something here, so that I can enable/unhide a field in the form that says "Please scroll up and look for missing or faulty input above" ?
Romans Malinovskis
@romaninsh
You could extend Form class.
Form catches validation exceptions
You can override “error” method too.
Georgi Hristov
@georgehristov
I actually updated AutoComplete with many functionalities and was planning to create a PR to share them. Will do that anyway and reviewers will decide if changes to be merged with atk
Changes include consistency refactoring (to match DropDown, multiple values selection, custom row results through callback (as DropDown), support for dependency on other fields in the dirty form (e.g. country -> state -> city functionality), etc
PhilippGrashoff
@PhilippGrashoff
that sounds very interesting!
I always wondered why AutoComplete wasnt an extension of DropDown in the first Place :)
Georgi Hristov
@georgehristov
Well it is still not but now it is consistent with DripDown having additional functionality
PhilippGrashoff
@PhilippGrashoff
sounds pretty good to me
Thomas Stokkeland
@stokkeland
Thank you @romaninsh - was hoping for some already created magic - i will attempt to identify validations things t an experiment with overrides
Thomas Stokkeland
@stokkeland
new UI oddity - still 1.7. if i do a $view->js(true, new \atk4\ui\jsNotify('Eff You')); or jsToast for that matter on page load - the notification pops up, but it breaks a modal action within this page.. if i skip the $view->js the modal works just fine.. i havent really gotten to dig into it ye - just curious if there are any issues known here.. if my ->js on page load is the right thing to do
Thomas Stokkeland
@stokkeland
seems to break all modals.. if however, i trigger a jsNotify or toast on some action with the page there are no issue.. so I am guessing that doing $view = $app->add('View'); $view->js(true, new jsNotify()); like it shows in the docs is not really all that proper..
Thomas Stokkeland
@stokkeland
wonder if it is related to that the index/counteer of javascript items are off on the ajax call.. hmmm.. probably
Thomas Stokkeland
@stokkeland
here with my monolog again.. i am not sure how to solve this - i am using a $_SESSION var in an IF to prompt showing the jsToast on document.ready, do it at the very end of my script in a brand new view at the end, but still it breaks $modal->show() .. i assume it is related to the js object indexing being different on the ajax call - i had hoped putting my notifiers at the end would have helped - but no..
(my session var is gone by the time the ajax call comes around, he jsToast is no longer being created)
PhilippGrashoff
@PhilippGrashoff
can you provide some code?
Thomas Stokkeland
@stokkeland
i just solved it actually - i was thinking about it, just it is scattered in some locations and needed assembly to make sense.. the problem was that even if i had my jsToasts being added at the end, the View i was using, also at the end, also did not get adde in the call back, so that did disrupt the JS indexcount between load and ajax.. once i figured that, and made sure the jsToasts are at the end it now works ok
Thomas Stokkeland
@stokkeland
that previous sentence looked funny..the part i was thinking about was how to assemble some code that i could show here.. then i finally figured out the view that was not being added
Georgi Hristov
@georgehristov
https://www.agiletoolkit.org/ certificate has expired today