Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 00:21
    mvorisek review_requested #877
  • 00:21
    mvorisek review_requested #877
  • 00:21
    mvorisek review_requested #319
  • 00:21
    mvorisek review_requested #319
  • 00:21
    mvorisek ready_for_review #319
  • 00:21
    mvorisek ready_for_review #877
  • May 11 22:21
    mvorisek opened #877
  • May 11 22:21
    mvorisek opened #319
  • May 11 22:19

    mvorisek on minor_fixes

    Bump versions for the next rele… (compare)

  • May 11 22:19

    mvorisek on minor_fixes

    Bump versions for the next rele… (compare)

  • May 11 22:18

    mvorisek on minor_fixes

    Bump versions for upcoming v3.1 (compare)

  • May 11 20:18
    mvorisek edited #246
  • May 11 15:15
    georgehristov edited #306
  • May 11 15:15
    georgehristov edited #306
  • May 11 13:32

    mvorisek on 3.0.gen

    (compare)

  • May 11 13:32

    mvorisek on 3.0.0

    (compare)

  • May 11 13:31

    mvorisek on 3.0.gen

    (compare)

  • May 11 13:30

    mvorisek on 3.0.0

    (compare)

  • May 11 13:28

    github-actions[bot] on 3.0.gen

    Build Release (compare)

  • May 11 13:27

    github-actions[bot] on 3.0.gen

    Build Release (compare)

Romans Malinovskis
@romaninsh
mergedh.
Imants Horsts
@DarkSide666
thanks!
Imants Horsts
@DarkSide666
http://demo.feelinart.com/ - admin template looks quite OK, but nothing special :)
Imants Horsts
@DarkSide666
more examples, cheatsheet - https://ehkoo.github.io/semantic-ui-examples/
github page in semantic ui css :D :D http://semantic-org.github.io/example-github/
Romans Malinovskis
@romaninsh
yeah, awesome ,right ?
semantic UI is the most closest to Agile CSS in terms of concept.
my priorities would be
  1. Agile Data 1.1
  2. UI
let me check if we can release agile data
few issues , i'll put some time into it right now.
Romans Malinovskis
@romaninsh
Imants, i think i'll be moving to atk4/atk4 room soon.
Imants Horsts
@DarkSide666
ok
Romans Malinovskis
@romaninsh
can you see / read / write messages there ?
Imants Horsts
@DarkSide666
i guess so
Imants Horsts
@DarkSide666
Did I miss something or AD doesn't support OR conditions ?
Romans Malinovskis
@romaninsh
no with array.
Imants Horsts
@DarkSide666
I need something like where a like '%a%' OR b like '%b%'
passing array to addCondition will simply do this (AND)
        if (is_array($field)) {
            array_map(function ($a) {
                call_user_func_array([$this, 'addCondition'], $a);
            }, $field);

            return $this;
        }
Imants Horsts
@DarkSide666
Here is fake "solution" for Quicksearch (atk4/atk4@639e328). Can you please take a look and think how to fix this?
Basically we need ability in AD to set conditions like this:
... HAVING a LIKE 'a' OR b LIKE 'b' otherwise Quicksearch will not work with AD models
Romans Malinovskis
@romaninsh
$m->addCondition(
    $m->expr(
        '{name} like [] or {name} like []',
        ['%'.$a.'%', '%'.$b.'%']
    )
);
Imants Horsts
@DarkSide666
This message was deleted
this will add WHERE condition not HAVING condition
Imants Horsts
@DarkSide666
ok fixed: atk4/atk4@5f4601c
only it is using where instead of having, but I guess it's ok for now
Imants Horsts
@DarkSide666
ok, found one bug win AD with enum. it only looks for enum array values, but should look in keys too.
enum can be defined as
->enum([
    'legal' => 'Juridiska persona', // non-numeric key, should use key as value
    'individual', // numeric key, should use value as value
])
Imants Horsts
@DarkSide666
reported here: atk4/data#167 and will fix this in a moment
Refined documentation ofr Audit Extension.
uh this type of enum might be problematic.
i've never used enums like that
imagine enum [1,2]
vs enum ['foo', 'bar'] or even
how do you figure out which is key and which is value.
Imants Horsts
@DarkSide666
ir key is numeric, then value should be used, if key is not numeric, then key is value
see: PR atk4/data#168
only problematic left here is if you actually want numeric values in enum
i don't see other way how to work around this issue. One thing is value (numeric or words) and each of them need to have name which we actually will show in forms
maybe we should always always use enum array keys as possible values, but then simple enum(['foo','bar'])will actually save 0 or 1 in db not foo or bar. That's not intuitive, but possible solution
Romans Malinovskis
@romaninsh
isset($enum[0]) - could this work?
which is why i don't want enum() to contain key-value, as it makes certain cases impossible.
and the worst one is
->enum(['N', 'Y']) vs enum([0, 1])
what you're looking at is "valueList"
that can be stored in ui/valueList
because "Juridiska Persona" will not be used by AD
it's only presentation decorator
Imants Horsts
@DarkSide666
well ... maybe
then I'll haveto define it like this in my model?
->enum(['legal', 'individual'])
->valueList([
    'legal' => 'Juridiska persona',
    'individual' => 'Fiziska persona',
])