enum can be defined as
->enum([
'legal' => 'Juridiska persona', // non-numeric key, should use key as value
'individual', // numeric key, should use value as value
])
Refined documentation ofr Audit Extension.
uh this type of enum might be problematic.
i've never used enums like that
imagine enum
[1,2]
vs enum ['foo', 'bar'] or even
how do you figure out which is key and which is value.
see: PR atk4/data#168
only problematic left here is if you actually want numeric values in enum
i don't see other way how to work around this issue. One thing is value (numeric or words) and each of them need to have name which we actually will show in forms
maybe we should always always use enum array keys as possible values, but then simple
enum(['foo','bar'])will actually save 0 or 1 in db not foo or bar. That's not intuitive, but possible solution
which is why i don't want enum() to contain key-value, as it makes certain cases impossible.
and the worst one is
->enum(['N', 'Y']) vs enum([0, 1])
what you're looking at is "valueList"
that can be stored in ui/valueList
because "Juridiska Persona" will not be used by AD
it's only presentation decorator
then I'll haveto define it like this in my model?
->enum(['legal', 'individual'])
->valueList([
'legal' => 'Juridiska persona',
'individual' => 'Fiziska persona',
])
or
->enum(['legal', 'individual'])
->ui[
'valueList' => [
'legal' => 'Juridiska persona',
'individual' => 'Fiziska persona',
],
])$v = ['legal' => 'Juridiska persona',
'individual' => 'Fiziska persona'];
->enum(array_keys($v))->ui(['valueList' => $v]);
ok, another small PR for you: atk4/data#169
there was problem with fields if they have trailing spaces. tests failed then and we didn't notice that ;)
looks ok.
DarkSide666 @DarkSide666 going offline till later
It could be useful to have for example in this situation:
// join address
$j = $this->join('address');
$a1 = $j->hasOne('city_id', ['City', 'mandatory' => 'true'])->withTitle();
$a2 = $j->addField('street');
$a3 = $j->addField('house');
$a4 = $j->addField('flat');
// $this->addExpression('full_address')
// ->set('concat_ws('.$a2->getExpr().','.$a3->getExpr().','.$a4->getExpr().','.$a1->getExpr().')');
see commented addExpression - how can I do this in AD to have correct table aliases in field names?
invited all participants from here to a new room.
(or rather old one)
my primary key is cit_id i want use the name id