These are chat archives for atomix/atomix

11th
Feb 2016
Richard Pijnenburg
@electrical
Feb 11 2016 06:52
Morning
Richard Pijnenburg
@electrical
Feb 11 2016 12:39
is there anything special i need to do so atomix can use the ssl stuff? need to configure it somewhere i guess
most likely somwhere so you can configure it with .withTransport(new NettyTransport()) ?
Jordan Halterman
@kuujo
Feb 11 2016 16:32
Yeah... Let me look at it. There are generally two options: a Builder for API configuration and properties for file configuration. Probably want a NettyTransport.Builder that constructs NettyProperties, and add the SSL stuff to NettyProperties, which is basically an immutable object that reads Properties and can be passed in to configure NettyTransport
Richard Pijnenburg
@electrical
Feb 11 2016 16:32
Ahh okay.
I did make the PR btw. first time real java stuff so please be kind :p lol
Jordan Halterman
@kuujo
Feb 11 2016 16:33
No worries. I may be able to add the configuration stuff
Richard Pijnenburg
@electrical
Feb 11 2016 16:33
Cool :-)
i did add a little bit for the properties file. not sure if i've done it 100% correct
Jordan Halterman
@kuujo
Feb 11 2016 16:34
Sweet
Richard Pijnenburg
@electrical
Feb 11 2016 18:12
Anything i can do to improve the PR?
Richard Pijnenburg
@electrical
Feb 11 2016 18:43
maybe i need to see if i can improve the validation of the certs.. like client verification and stuff.
Jordan Halterman
@kuujo
Feb 11 2016 18:43
ahh interesting
sorry I saw your question and then got stuck in another meeting :-P
Richard Pijnenburg
@electrical
Feb 11 2016 19:16
hehe np
Richard Pijnenburg
@electrical
Feb 11 2016 19:24
Think i'll need to remove the test though since it won't pass. guess it does extra validation already
@kuujo ^^ what i've been doing last 3 years. lol
Jordan Halterman
@kuujo
Feb 11 2016 21:33
:-D