These are chat archives for atomix/atomix

20th
May 2016
Madan Jampani
@madjam
May 20 2016 00:07
@jhalterman and @kuujo with the help of a colleague I finally managed to get the OSGi set up working. It turned out to be significantly more changes than what I anticipated. But I feel it is better to get this straight at the beginning. The biggest problem we had to tackle was the split packaging across multiple bundles and also reorganizing the package structure in catalyst a bit to get the dependencies working. That required some package name refactoring. And as you know once package names are changed the change-set quickly grows! In any case I’ll open PRs for catalyst, copycat and atomix and we can take it from there
o
Jonathan Halterman
@jhalterman
May 20 2016 00:09
@madjam cool - do you guys have any steps to try things out?
Madan Jampani
@madjam
May 20 2016 00:11
So far I have only verified that this work as expected in my project. I am confident this should work fine in general. We still don’t have a stand alone test per se. Hopefully that isn’t very hard to do.
Jonathan Halterman
@jhalterman
May 20 2016 00:12
ok np
Jordan Halterman
@kuujo
May 20 2016 00:13
Sounds good
Madan Jampani
@madjam
May 20 2016 01:11
I opened PRs for all 3 projects. They are all a bit long but straightforward. Obviously there are implications for some existing users. But I feel it is better to bite the bullet and fix this issue now rather than later when there will be a lot more users who’ll feel the pain.
Jordan Halterman
@kuujo
May 20 2016 01:15
Are those implications just the changed dependencies?
Madan Jampani
@madjam
May 20 2016 01:16
Yes.
Jordan Halterman
@kuujo
May 20 2016 01:16
I doubt the Catalyst changes would be problematic for anyone... Haven't looked at the others yet
Bah nvm... There are package changes
Indeed better now than later
Fortunately those classes are likely rarely used externally
I'm going to go through and merge them and run Travis tests in order
Madan Jampani
@madjam
May 20 2016 03:02
I realized there are few places in Atomix and Copycat where we were doing Class.forName on the full class NettyTransport name. I’ll fix those
Jordan Halterman
@kuujo
May 20 2016 03:25
Cool
I'm going to bump the minor version for this... Best that can be done and that makes me feel less bad out breaking things :-)
about*
Madan Jampani
@madjam
May 20 2016 03:36
@kuujo: Cool. That makes sense.
Jordan Halterman
@kuujo
May 20 2016 03:49
I’ll give it a few days first in case anything else comes up