These are chat archives for atomix/atomix

8th
Jul 2016
Roman Pearah
@neverfox
Jul 08 2016 00:13 UTC
It's not frequent yet. It's just that it's currently a showstopper until we write the correct resolution code. What would be helpful is having a good summary of all of the possible exceptions that might be waiting inside of the CompletableFuture and what circumstances give rise to them. It's possible that that is documented somewhere but I've had a little trouble understanding the failure modes of Atomix other than what I've experienced.
@madjam Thanks for your help.
I could be wrong but it seems that the Furture-based API makes it harder to look up what methods throw because they don't throw, yet exceptions are still indirectly possible.
But I'll take the tried and true approach: catch everything and progressively write specific code for interesting cases.
Jordan Halterman
@kuujo
Jul 08 2016 06:15 UTC
I suppose that’s somewhat true. Copycat actually needs more granular exceptions in general. But I think you have the right idea
better documentation for exceptions is indeed needed
we should improve the granularity of exceptions and then document them
Roman Pearah
@neverfox
Jul 08 2016 06:16 UTC
Yeah, unfortunately it creates doc work for you outside of the grease that javadocs gives you with explict throws calls
Jordan Halterman
@kuujo
Jul 08 2016 06:16 UTC
yep
I’m all about documentation though
Roman Pearah
@neverfox
Jul 08 2016 06:17 UTC
Which, btw, is exceptional in this case
Jordan Halterman
@kuujo
Jul 08 2016 06:17 UTC
Copycat and Atomix tend to have way more API documentation than most open source projects I see
Roman Pearah
@neverfox
Jul 08 2016 06:17 UTC
present topic notwithstanding
Jordan Halterman
@kuujo
Jul 08 2016 06:17 UTC
drives me crazy having to dig through code to try to figure out how to use stuff
So, IIRC it is true that commands will fail when a session is expired. The reason for this is because the expired session implies a loss of consistency, and we want to force the user to handle that. It can be a PITA to have to handle it, but generally you’ll get a ClosedSessionException which is the only thing I see failing commands on the client side
Roman Pearah
@neverfox
Jul 08 2016 14:04 UTC
@kuujo Cool thanks. I think we have a strategy now.