These are chat archives for atomix/atomix

22nd
Dec 2017
Zachary Heilbron
@zheilbron
Dec 22 2017 10:03
@johnou I'm here on gitter if that's easier than relaying messages on github
Johno Crawford
@johnou
Dec 22 2017 10:07
hey @zheilbron
looks like we are just missing the following tags in the core/pom.xml
<scope>compile</scope>
<optional>true</optional>
Zachary Heilbron
@zheilbron
Dec 22 2017 10:08
Are you referring to the scope of the other atomix dependencies?
Johno Crawford
@johnou
Dec 22 2017 10:08
just waiting for the snapshot to finish, one moment
Johno Crawford
@johnou
Dec 22 2017 10:31
ah man I think i'll need to revisit this, that module isn't what I thought it is
seems to be an issue with how it's bundled
Zachary Heilbron
@zheilbron
Dec 22 2017 10:31
:)
all good, thanks for looking at it...
I think the issue is that, again, maven-bundle-plugin includes all of the io.atomix classes--which includes all of its dependencies (since they're on the classpath)
Johno Crawford
@johnou
Dec 22 2017 10:32
yep the felix maven bundle plugin
Zachary Heilbron
@zheilbron
Dec 22 2017 10:33
so in theory, you could just exclude the other dependencies when declaring the dependency on io.atomix:atomix
except that when the source-jar is generated, its scope is limited to the current project (core)...so only the classes coming from core have sources for them
Johno Crawford
@johnou
Dec 22 2017 10:42
well I was wondering about repackaging core to io.atomix.core so then the pattern of the bundle plugin would change and avoid the duplicates
but to be honest I have pretty much zero experience with osgi
Zachary Heilbron
@zheilbron
Dec 22 2017 10:54
I was thinking the same thing... then you could have another maven module that further depends on core and runs maven-bundle in its current form... it should produce a nearly identical bundle (modulo the name change) for those that require the uber jar/bundle, while allowing the rest to just depend on core
Anyway, just food for thought... maybe someone with more OSGI experience can provide some guidance here