These are chat archives for atomix/atomix

22nd
Jan 2018
Johno Crawford
@johnou
Jan 22 2018 08:28
@kuujo still not happy with the bug_fixes branch?
bit hard to review it though, seems it wasn't forked from master?
ah, nvm got it
Huibai Huang
@baymaxhuang
Jan 22 2018 16:00

@kuujo I find the PhiAccrualFailureDetector.java is actually implemented based on the FailureDetector of Cassandra, which is a little different from the original Phi failure detector proposed in the original paper by Hayashibara et al. See: https://issues.apache.org/jira/browse/CASSANDRA-2597

As a result, the code comment should also be updated to make it more clear and accurate: https://github.com/atomix/atomix/blob/832df3702d1aabbbbb1a2e3e395d50b1d0e94972/cluster/src/main/java/io/atomix/cluster/impl/PhiAccrualFailureDetector.java#L22-L26