Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Nov 05 16:27

    LukasKalbertodt on v0.5.0

    (compare)

  • Nov 05 16:20

    LukasKalbertodt on master

    Split UI tests into two test fu… Add Rust 1.37 to CI matrix to c… Bump version to 0.5.0 (compare)

  • Nov 05 16:18

    LukasKalbertodt on master

    Update MSRV information and add… Replace usage of `matches!` mac… Split UI tests into two test fu… and 2 more (compare)

  • Nov 05 15:52

    LukasKalbertodt on master

    where possible replace ::std wi… move Box, Rc and Arc impls insi… add no_std test and 1 more (compare)

  • Nov 05 15:48

    LukasKalbertodt on switch-to-gh-actions

    (compare)

  • Nov 05 15:48

    LukasKalbertodt on master

    Update error messages in UI tes… Switch to GitHub Actions for CI Merge pull request #75 from aut… (compare)

  • Nov 05 15:42

    LukasKalbertodt on switch-to-gh-actions

    Switch to GitHub Actions for CI (compare)

  • Nov 05 15:39

    LukasKalbertodt on switch-to-gh-actions

    Switch to GitHub Actions for CI (compare)

  • Nov 05 15:36

    LukasKalbertodt on switch-to-gh-actions

    Update error messages in UI tes… Switch to GitHub Actions for CI (compare)

  • Feb 27 13:41

    LukasKalbertodt on fix-ui-tests

    (compare)

  • Feb 27 13:41

    LukasKalbertodt on master

    Fix UI tests for Rust 1.50 Merge pull request #74 from aut… (compare)

  • Feb 27 13:34

    LukasKalbertodt on fix-ui-tests

    Fix UI tests for Rust 1.50 (compare)

  • Sep 19 2020 12:30

    LukasKalbertodt on v0.4.1

    (compare)

  • Sep 19 2020 12:29

    LukasKalbertodt on release-0.4.1

    (compare)

  • Sep 19 2020 12:29

    LukasKalbertodt on master

    Bump version to 0.4.1 Merge pull request #71 from aut… (compare)

  • Sep 19 2020 12:25

    LukasKalbertodt on release-0.4.1

    Bump version to 0.4.1 (compare)

  • Sep 13 2020 17:18

    LukasKalbertodt on master

    Update proc-macro-error depende… Merge pull request #70 from Cre… (compare)

  • Jul 19 2020 14:44

    LukasKalbertodt on fix-tests-and-method-bounds

    (compare)

  • Jul 19 2020 13:36

    LukasKalbertodt on v0.4.0

    (compare)

  • Jul 19 2020 13:28

    LukasKalbertodt on release-0.4.0

    (compare)

Lukas Kalbertodt
@LukasKalbertodt
Hello!
Samuel Resendez
@saresend_gitlab
Hi! Thanks so much for providing this :)
Ashley Mannix
@KodrAus
:wave: :wave: :wave:
Lukas Kalbertodt
@LukasKalbertodt
@KodrAus Do you have an idea when rust-lang/cargo#6086 lands in nightly?
Ashley Mannix
@KodrAus
@LukasKalbertodt hopefully it will be soon :) Unfortunately nightly isn't always nightly, because sometimes components need to be fixed. It should be within the next few days though
Lukas Kalbertodt
@LukasKalbertodt
@saresend_gitlab I hope all my comments on your PR are clear :)
@saresend_gitlab Do you already know if you want to work on another issue afterwards? And if so, which one? Because I think I would start tackling some issues as well, but I don't want to steal work from anyone interested in contributing.
@KodrAus I thought about README and the docs. What do you think about moving most of the README examples to the crate docs (updating them if necessary) and to only have one nice example + a big nice "Docs" button in the README? I'd like to avoid a lot of duplication between README and docs. And I think I would tend to make the crate docs really extensive and the README short-ish. What do you think?
Ashley Mannix
@KodrAus
@LukasKalbertodt Shifting into the docs sounds good. I suspect what I put in the readme is lazy and inaccurate though :) It's common to have a little badge linking to docs, and possibly a link in prose too after a single quick example
Lukas Kalbertodt
@LukasKalbertodt
Oki doki :)
The next nightly will have the build-plan fix :3 yeaah
Ashley Mannix
@KodrAus
:tada:
Lukas Kalbertodt
@LukasKalbertodt

Damn, I missed the warning introduced by @saresend_gitlab's PR:

warning: cannot specify lifetime arguments explicitly if late bound lifetime parameters are present                                                                                 
  --> examples/names.rs:53:10                                                                                                                                                       
   |                                                                                                                                                                                
53 |     fn A<'b, 'c>(&self, B: C, D: E<&[F; 1]>) -> G<fn((H,))> {                                                                                                                  
   |          ^^ the late bound lifetime parameter is introduced here                                                                                                               
   |                                                                                                                                                                                
   = note: #[warn(late_bound_lifetime_arguments)] on by default                                                                                                                     
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!                                                
   = note: for more information, see issue #42868 <https://github.com/rust-lang/rust/issues/42868>

Seems to be rather complicated. But I think I know how to fix it.

And yes, the build-plan fix finally landed in nightly ^_^
But the new nightly makes another breaking change. I will fix all of this in my travis PR.
Ashley Mannix
@KodrAus
@LukasKalbertodt I'll be keen to see where you end up on that one
Lukas Kalbertodt
@LukasKalbertodt

@KodrAus Just pushed: https://github.com/auto-impl-rs/auto_impl/pull/34/commits/c15616528154a4efc688b63117acb4d22de391c5

The commit message should describe everything. I'm not perfectly happy, but yeah, seems to work for now.

Lukas Kalbertodt
@LukasKalbertodt
Sorry for the spam :P I deleted my previous two messages as they didn't contain any useful info. I now figured it out and my PR is ready now. I should think more before writing comments or messages in chats ^_^
Ashley Mannix
@KodrAus
It's not spam :smile:
Will check it out :eyes:
Looks good :+1: It might be worth adding a little inline comment that we're not passing lifetimes because some of then might be late-bound, and we'd rather let the compiler figure it out implicitly?
Actually... I'll just go drop that comment on the PR :)
Lukas Kalbertodt
@LukasKalbertodt
Awesome! I added a comment and will merge when travis is happy ^_^
Lukas Kalbertodt
@LukasKalbertodt
Hi @KodrAus. Do you already know when you'll be able to review the doc PR? No hurries, I know that those PRs are a bit annoying to review. But yeah, that's the major big blocker before a new release (basically that and the license). Just let me know if you know anything ^_^ Thanks!
Lukas Kalbertodt
@LukasKalbertodt
Thanks for submitting your review. I already thought you might have forgot to submit it, since you did other things already =D
Lukas Kalbertodt
@LukasKalbertodt
So, I just changed the license (and already merged, hopefully everything is correct). Furthermore, I created a PR to fix the last 0.3-milestone issue. When this is merged, we can think about releasing it :)
I would then create a final PR which fixes some metadata in Cargo.toml (including the version bump).
Ashley Mannix
@KodrAus
Sounds good! Thanks for all your amazing work :) I'll catch up on the PRs shortly, I've been a little distracted by log recently
Lukas Kalbertodt
@LukasKalbertodt
@KodrAus Yeah, a few hours after writing that message I've seen and skimmed your log RFC. Nice work ^_^
So very understandable, that there is not enough time for auto_impl :P
Lukas Kalbertodt
@LukasKalbertodt
@KodrAus Hi there and thanks for reviewing the PRs! As you can see on GitHub, the "impl lifetime elision" PR is problematic. So I'd not wait for it to resolve, but instead already release the next version. There is already a version bump PR -- after that is merged, we can release.
I would also post something on /r/rust to get a bit publicity, if you don't mind ^_^