Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Jonas Pauthier
    @Nargonath
    yeah it is still pretty new but I have already working with it at their jobs
    So I guess it works even though you still have some little quirks every now and then.
    Suhas Karanth
    @sudo-suhas
    Hmm.. Maybe I'll give it a try
    Suhas Karanth
    @sudo-suhas
    Thanks!
    Jonas Pauthier
    @Nargonath
    np
    Jonas Pauthier
    @Nargonath
    so do we still talk to each other on Sunday 12:30 lunchbreak at your time @asfktz?
    Asaf Katz
    @asfktz
    Hi @Nargonath! What's up? It was next Sunday, but I think do something different instead. This week I'll take the time to write about how each part works and I why things are the way they are. I think it will be more effective that way
    Jonas Pauthier
    @Nargonath
    Hey! i'm good and you? Oh I thought it was this weekend. Yeah it will probably be easier to pass to someone else afterwards and also to read it at any time.
    good call
    Jonas Pauthier
    @Nargonath
    @sudo-suhas I've setup my desktop at home with Windows Linux Subsystem and I must say that it works well for now
    I haven't done anything fancy like playing with docker for example but for a backend development right now it works fine
    Just have to follow the rule: NEVER EDIT LINUX FILES FROM WINDOWS APP
    Jonas Pauthier
    @Nargonath
    hence all your codebase will live in Windows land and you access it through your bash terminal
    Suhas Karanth
    @sudo-suhas
    Okay.. I have been meaning to try it out but haven't found the time yet. Hopefully I'll get some time soon
    Asaf Katz
    @asfktz

    Hi guys!

    For some reason the npm run format stoped working.
    I think its related to some change inside prettier-eslint-cli
    but I’m not sure, I don’t think it somthing from our side.
    This is the log:

    ➜  autodll-webpack-plugin git:(master) ✗ npm run format
    
    > autodll-webpack-plugin@0.3.6 format /Users/asafkatz/dev/autodll-webpack-plugin
    > prettier-eslint --print-width 100 --trailing-comma es5 --single-quote --write "{{src,specs,scripts,examples/**/src,experiments/**/src}/**/*.{js,json,css},*.{js,json}}"
    
    prettier-eslint-cli [ERROR]: There has been an unknown error when running the prettier-eslint CLI. If it's unclear to you what went wrong, then try this:
      1. Run the script again with the LOG_LEVEL environment variable set to "trace"
      2. Search existing issues on GitHub: https://github.com/prettier/prettier-eslint-cli/issues?utf8=%E2%9C%93&q=Cannot%20read%20property%20'Observable'%20of%20undefined
      3. Make a minimal reproduction in a totally separate repository. You can fork this one: https://github.com/kentcdodds/prettier-eslint-cli-repro
      4. Post an issue with a link to your reproduction to the issues on GitHub: https://github.com/prettier/prettier-eslint-cli/issues/new
    /Users/asafkatz/dev/autodll-webpack-plugin/node_modules/prettier-eslint-cli/dist/uncaught-exception-handler.js:45
      throw err;
      ^
    
    TypeError: Cannot read property 'Observable' of undefined
        at Object.<anonymous> (/Users/asafkatz/dev/autodll-webpack-plugin/node_modules/prettier-eslint-cli/dist/format-files.js:136:26)
        at Module._compile (module.js:573:30)
        at Object.Module._extensions..js (module.js:584:10)
        at Module.load (module.js:507:32)
        at tryModuleLoad (module.js:470:12)
        at Function.Module._load (module.js:462:3)
        at Module.require (module.js:517:17)
        at require (internal/module.js:11:18)
        at Object.<anonymous> (/Users/asafkatz/dev/autodll-webpack-plugin/node_modules/prettier-eslint-cli/dist/index.js:14:20)
        at Module._compile (module.js:573:30)
    It no affecting users, only contributors I believe
    Asaf Katz
    @asfktz
    Should we remove the format task from commit hook till its fixed?
    Jonas Pauthier
    @Nargonath
    That could be an easy fix until we figure out what's the problem behind this
    Suhas Karanth
    @sudo-suhas
    Hey @asfktz, did you take a look at asfktz/autodll-webpack-plugin#89 The issue is very through and even has a repo for reproducing the issue
    Any idea why the source maps are not created?
    Suhas Karanth
    @sudo-suhas
    Okay, inherit: true was missing in the constructor options.. Which as it turns out, isn't documented. Will add docs for it by tmrw.
    Asaf Katz
    @asfktz
    I didn't include inherit in the docs since it's highly experiential, musly because plugins are hard to inherit: plugins are initialiaze with the new keyword, so we ended up inheriting the plugin instances.
    inherit loaders are buggy too, there's a long standing issue about it
    but yeah, in the case on sourcemaps it should be no problem
    This one #37
    Asaf Katz
    @asfktz
    By default, inherit exludes plugins
    autodll-webpack-plugin/blob/master/src/mapParentConfig.js
    Suhas Karanth
    @sudo-suhas
    Okay.. I'll mention that the option is experimental.
    Suhas Karanth
    @sudo-suhas
    Created a PR. See asfktz/autodll-webpack-plugin#92
    Asaf Katz
    @asfktz
    Thanks, @sudo-suhas , I’ll get to it later today
    Suhas Karanth
    @sudo-suhas
    👍
    Suhas Karanth
    @sudo-suhas
    See asfktz/autodll-webpack-plugin#91 too. It improves the inherit mode.
    Kasper Sandin
    @ksandin
    Hi. Is there any known issues with the plugins configuration on AutoDllPlugin?
    I'm trying to add a simple DefinePlugin to define the NODE_ENV in the dll bundle, but it seems like it's being ignored.
    the same define plugin works on my main bundle but not in the dll bundle.
    const definePlugin = new webpack.DefinePlugin({
     'process.env': {
        NODE_ENV: JSON.stringify(options.nodeEnv),
      }
    })
    webpackConfig = {
      plugins: [
        definePlugin,
        new AutoDllPlugin({
          inject: true,
          filename: '[name].dll.js',
          plugins: [definePlugin],
          entry: {
            vendor: ['react', 'react-hot-loader'],
          }
        })
      ]
    }
    Suhas Karanth
    @sudo-suhas
    Hey @asfktz, could you take a look at asfktz/autodll-webpack-plugin#101 I couldn't figure out the cause