Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Vinay Venu
@vinayvenu
Fast refresh in 0.61 in itself is worth the upgrade.
We spend so much time going to the right screen from the beginning each time we make a minor change.
Arjun Khandelwal
@arjunk
what estimate would you throw for this?
i am forgetting what’s the reasoning for generic names in the form mapping table? And if those reasons don’t hold valid today, should we rename entity_id -> program_id, observations_type_entity_id -> encounter_type_id?
Vinay Venu
@vinayvenu
0.59 to 0.63 - 2 days (mostly to deal with the unknowns).
if we have not had the use to extend the meaning in 3 years, its worth naming them for what they are.
Arjun Khandelwal
@arjunk
ok
Vinay Venu
@vinayvenu
const decisionBuilder = new imports.rulesConfig.complicationsBuilder({
    programEncounter: programEncounter,
    complicationsConcept: ""Counsel mother""
});
why is it called a complicationsBuilder?
Arjun Khandelwal
@arjunk
originally it was used for building complications in one of the implementations.. i think we got lazy to rename it
Arjun Khandelwal
@arjunk

From Vivek :

In both data entry app and form designer app - there is a lot of scope for improving the code - from long term maintenance standpoint. A few main issues are spread across the codebase (i.e. in each component). I mainly see 3 main issues.

  1. Folder structure
  2. Lot of code in react JSX components and missed opportunities in creating smaller reusable components causing big files
  3. It is difficult to figure out what the state overall looks like for a higher order component
From me:
how should we go about this.. 2 options 1. identify issues and do them as and when faced in a particular card. or 2. identify cards and fix them together
thoughts, anyone?
Vivek Singh
@petmongrels
Fixing with existing story, annoncing in standup, and keeping refactoring scope small (around 1 day for 4-5 day story) is the best option always.
Arjun Khandelwal
@arjunk
yes, i too think the same
Hiren Thacker
@hithacker
Yeh, same thoughts
Arjun Khandelwal
@arjunk
@petmongrels can you elaborate the first point about Folder structure. also if possible on the 3rd one.
Vivek Singh
@petmongrels
image.png
there are some components grouped and then it seems one gave up trying to group them in folders so they are growing in the root.
Vivek Singh
@petmongrels
image.png
it may be better to use TypeScript for state and also clear pattern established for what to expect in state.
if everything is prefixed with dataEntry then why is dataEntry not the state
Vivek Singh
@petmongrels
it is not expected to see encounterReducer in state. then subjectProfile.subjectProfile these are all smell pointing to lack of high level thinking on what should state look like. This basically becomes we will make it up as we go :-)
Hiren Thacker
@hithacker
Webapp and server released
dinhngocquanghuy
@dinhngocquanghuy
Dear everyone,I just join in avni. Currently I have setup the app locally and connect to hosted API Server. When I start it, it's required with username/password login, how can I get this info?
Hiren Thacker
@hithacker

From Vivek :

In both data entry app and form designer app - there is a lot of scope for improving the code - from long term maintenance standpoint. A few main issues are spread across the codebase (i.e. in each component). I mainly see 3 main issues.

  1. Folder structure
  2. Lot of code in react JSX components and missed opportunities in creating smaller reusable components causing big files
  3. It is difficult to figure out what the state overall looks like for a higher order component

We did some refactoring of creating smaller components for FormWizard avniproject/avni-webapp@6fdce37. In this refactoring we extracted out separate components for WizardButton and WizardHeader. Also we deleted one wrapper component around FormElementGroup called Form.js that was misleading since it was just wrapping the FormElementGroup without doing anything extra and actually representing a group only and not a form.

Hiren Thacker
@hithacker
Also, I have put a card to keep track of tech debts/quality issues in the DEA code. avniproject/avni-webapp#518. We will keep updating this card with the issues for which we don't have time to fix in the current story.
Arjun Khandelwal
@arjunk

Dear everyone,I just join in avni. Currently I have setup the app locally and connect to hosted API Server. When I start it, it's required with username/password login, how can I get this info?

@dinhngocquanghuy you will have to setup an account and have your username / password. you can setup a trial account by signing up here https://avniproject.org/signup/?source=trial

Vinay Venu
@vinayvenu
@arjunk @dinhngocquanghuy wanted to set up project locally.
We can instead use local signin with no password, right?
Arjun Khandelwal
@arjunk
ok, i am not aware of the context. some people don’t want to setup the server locally but want to use the hosted server.
if complete local setup is required, then yes that can be done without sign in. The user needs to be created from admin in local and then start the server with that user to access from mobile client. or start the webapp with that server.
dinhngocquanghuy
@dinhngocquanghuy

Dear everyone,I just join in avni. Currently I have setup the app locally and connect to hosted API Server. When I start it, it's required with username/password login, how can I get this info?

@dinhngocquanghuy you will have to setup an account and have your username / password. you can setup a trial account by signing up here https://avniproject.org/signup/?source=trial

Thank you so much for your help @arjunk @vinayvenu , after hours trying, I find out the username and password right inside the source code project

ravindravs
@ravindravs
Hi All, I need to set up the AVNI setup in windows is that possible to do it. Please suggest
Vivek Singh
@petmongrels
There is no reason why it should not work on windows. We have tried it once and it worked then. Unfortunately we don’t have instructions, so it would require patience from you.
ravindravs
@ravindravs
Please provide the steps to setup the environment
Vivek Singh
@petmongrels
various install guides are here - https://avni.readme.io/docs/environment-setup-guides
ravindravs
@ravindravs
Hello Vivek, After installing the docker in windows I am able to access the App-server in windows from browser but not able to access database url(jdbc:postgresql://localhost:5434/openchs) running in docker and mobile app. Please provide the steps to run the andriod emulator in windows
image.png
image.png
image.png
Vivek Singh
@petmongrels
I think you have to use android studio for windows.
You will find that many of the commands in the makefile have not been written for windows, so you may have to change some of them
Check this link for steps - https://avni.readme.io/docs/developer-environment-setup-ubuntu#field-app-components
ravindravs
@ravindravs
Hi Vivek Please can you please tell me how to check the DB URL to load the database while container is running
Vivek Singh
@petmongrels
For connecting to database from outside the container, you probably have to open ports in docker container. You should refer to docker document for the same.
Joy A
@1t5j0y
Also, trying to connecting to the database from the browser (as shown in the screenshot you shared) will not work. You will need to use pgadmin or similar tool to connect to the database.
vindeolal
@vindeolal
New patch release done for avni-client. Here is list of bug fixes done
https://github.com/avniproject/avni-client/releases/tag/v3.9.6
ravindravs
@ravindravs
image.png
When I try to run the AVNI Server I am getting an datasource exception flyway. I have created a postgres database with the details given in application.properties. Can anyone suggest resolve it
Vivek Singh
@petmongrels
Are you running database on the same OS as the server? Are you able to do psql from the server machine.