Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 01 19:22

    aws-sdk-php-automation on master

    Update models for release 3.252.0 release (compare)

  • Dec 01 19:22

    aws-sdk-php-automation on 3.252.0

    (compare)

  • Dec 01 17:07
    stobrien89 synchronize #2449
  • Dec 01 17:02
    stobrien89 synchronize #2449
  • Dec 01 16:06
    stobrien89 labeled #2585
  • Dec 01 16:05
    stobrien89 commented #2585
  • Dec 01 16:04
    stobrien89 unlabeled #2585
  • Dec 01 16:04
    stobrien89 assigned #2585
  • Dec 01 11:20
    AvinashDalvi89 labeled #2586
  • Dec 01 11:19
    AvinashDalvi89 opened #2586
  • Dec 01 11:19
    AvinashDalvi89 labeled #2586
  • Dec 01 10:18
    annuh synchronize #2477
  • Dec 01 09:29
    phyzerbert labeled #2585
  • Dec 01 09:29
    phyzerbert labeled #2585
  • Dec 01 09:29
    phyzerbert opened #2585
  • Nov 30 23:58
    sashashura commented #2525
  • Nov 30 19:23

    aws-sdk-php-automation on master

    Update models for release 3.251.0 release (compare)

  • Nov 30 19:23

    aws-sdk-php-automation on 3.251.0

    (compare)

  • Nov 29 22:03
    stobrien89 opened #2584
  • Nov 29 19:24

    aws-sdk-php-automation on master

    Update models for release 3.250.0 release (compare)

Jonathan Eskew
@jeskew
The requests have an exponentially increasing delay between them
So that throttled requests will try again after the throttle has been lifted
mikemherron
@mikemherron
Ok thanks - from the timestamps recorded in my logs, it looks like the retries are all being logged at the same second.
In fact, thinking about it now, a retry of "0.05" ms probably doesn't make sense :)
Also, my test script definitely didn't show a delay at all - it just fails when my server returns the 500 due to the uncaught ProvisionedThroughputExceededException.
Jonathan Eskew
@jeskew
Oh so the delay is being calculated but not applied?
mikemherron
@mikemherron
That looks possible - I'm trying to look through the code now, but it's my first time through it so taking me a while!
Jonathan Eskew
@jeskew
Could you open an issue with that log on github?
Might help to get more eyes on it
mikemherron
@mikemherron
Sure
I can see in Waiter.php::getArgsForAttempt() the delay is multipled by 1000 with the comment " // Set the delay. (Note: handlers except delay in milliseconds.)"
I may be in the wrong place entirely, but I wonder if that scaling is being by-passed due to the way that the RetryMiddleware applies the delay
Of course, I might just be in the wrong place altogether.
Will log the issue now.
Jonathan Eskew
@jeskew
The waiter delay should be separate from the retry delay. I'll take a closer look and let you know
mikemherron
@mikemherron
Cheers, thanks a lot. I'm putting together a quick repro script.
mikemherron
@mikemherron
@jeskew Have added the issue: aws/aws-sdk-php#815
Daniel Hensby
@dhensby
Hi, I just opened issue #821 and have a patch at #822 but I'm not really experienced with mock objects so not sure how to write a robust test for this problem
can anyone give me some pointers?
I essentially want to write some data to one session ID, "change the session ID", save the session again, and then check the data was saved
Jonathan Eskew
@jeskew
You can provide an http_handler to a client that verifies expectations instead of making requests
Daniel Hensby
@dhensby
@jeskew thanks; are there any existing examples in the tests I can use as a reference?
Daniel Hensby
@dhensby
thanks, I'll take a look.
Daniel Hensby
@dhensby
@jeskew I'm trying to implement something similar to that example, but it doesn't seem to have the intended effect...
$store = array();
        $client = DynamoDbClient::factory(array(
            'region' => 'us-west-2',
            'http_handler' => function() use(&$store) {
                var_dump(func_get_args());
                echo 'here';
            }
        ));
        $handler = SessionHandler::factory(array(
            'dynamodb_client'  => $client,
         ));
(this is just for debugging) the http_handler never gets called
I am on the 2.8 branch... perhaps it's not available on v2?
Jonathan Eskew
@jeskew
It's not on 2.8
Daniel Hensby
@dhensby
:(
any other pointers on how I can test this, then?
Jonathan Eskew
@jeskew
The session handler tests have a getMockedClient method
That should let you mock out responses
Daniel Hensby
@dhensby
This message was deleted
This message was deleted
ok, cool. I think I'm getting there, slowly. I just need to change my mock response based on the argument passed to the method. how do I do that?
$strategy->expects($this->any())
    ->method('doRead')
    ->will(
        //want callback here that can take doRead argument
    );
Daniel Hensby
@dhensby
basically, I need the doWrite and doRead to work dynamically and store actual values to prove the test
otherwise I'm basically writing a test that goes 1 == 1 and 2 == 2
Jonathan Eskew
@jeskew
You can check that the proper value is provided to doWrite and that the proper action is taken when the right value is returned from doRead
Daniel Hensby
@dhensby
thanks so much @jeskew testReturnCallback is what I needed
Daniel Hensby
@dhensby
tests passing now :)
just in time for me to go home
Miguel Vieira
@apoca
I want change my local files to S3 it is possible?
like uploaded files from users of platform
Daniel Hensby
@dhensby
Miguel Vieira
@apoca
Is possible in last version aws V3 upload files directly from POST
?
I can't find documentation about ..
Jonathan Eskew
@jeskew
@apoca I’m not sure what you mean