aztfmod/community

Hi, I wrote our image gallery module in level1. Its it working fine. We are using our own harded RHEL images.
The output in the tstate file is as follow:

    "shared_image_gallery": {
      "value": {
        "rhel84": {
          "id": "/subscriptions/xxxxxx/resourceGroups/mcdta-rg-image-gallery-ocpe/providers/Microsoft.Compute/galleries/RedHat/images/RHEL_8/versions/8.4.0"
        }

The id of the image is used to create a virtual machine in level2.
A snip of the tfvar file of the virtual server.

        os_disk = {
          name                    = "idm1-os"
          caching                 = "ReadWrite"
          storage_account_type    = "Standard_LRS"
          disk_size_gb            = "40"
          disk_encryption_set_key = "set1"
        }
        custom_image_ids = {
          lz_key           = "shared_image_gallery"
          custom_image_key = "rhel84"
         }

And the config to read the lower tfstate file.

landingzone = {
  backend_type        = "azurerm"
  global_settings_key = "management"
  level               = "level2"
  key                 = "identity_virtual_host"
  tfstates = {
    identity_network = {
      level   = "current"
      tfstate = "identity_network.tfstate"
    }
    shared_image_gallery = {
      level   = "lower"
      tfstate = "shared_image_gallery.tfstate"
    }
  }
}

Unfortunately, the custom_image_ids is not handled properly in the module. I think the problem is in the module of the virtualserver. This one looks like this:

source_image_id = try(each.value.custom_image_id,var.custom_image_ids[each.value.lz_key][each.value.custom_image_key].id, null)

If the module terraform-azurerm-caf/modules/compute/virtual_machine/vm_linux.tf is modified as follows, will the variable from the lower tfstate file be retrieved correctly? Are we missing a landingzone_key ?

source_image_id = try(each.value.custom_image_id,try(var.custom_image_ids[var.client_config.landingzone_key][each.value.lz_key][each.value.custom_image_key].id,var.custom_image_ids[each.value.lz_key][each.value.custom_image_key].id))

Nevertheless, if the custom_image_id is used with the full id:/subscription/.. from the azure configuration, everything works properly. But then we have added a static value to a variable configuration.
How can the module be adapted?
It will help us a lot