These are chat archives for azukiapp/azk

24th
Sep 2015
Slobodan Mišković
@slobo
Sep 24 2015 21:37
hey folks, I get this error with azk 0.15 on Fedora 22:
azk agent start                                                    Thu Sep 24 14:35:45 PDT 2015
azk: Please wait, this process may take several minutes
azk: Loading settings and checking dependencies.
azk: Checking version...
azk: azk 0.15.0 detected
azk: TypeError: Invalid Version: 1.8.1.fc22
azk:     at new SemVer (/usr/lib/azk/node_modules/semver/semver.js:273:11)
azk:     at compare (/usr/lib/azk/node_modules/semver/semver.js:520:10)
azk:     at Function.gte (/usr/lib/azk/node_modules/semver/semver.js:569:10)
azk:     at /azk:0.15.0/src/agent/configure.js:168:43
seems that the version of docker with fedora suffix is confusing the SemVer package
Gullit Miranda
@gullitmiranda
Sep 24 2015 21:40
hey @slobo
I believe we will have to make a normalization in version before passing it by Semver.
What do you think @fearenales ?
Slobodan Mišković
@slobo
Sep 24 2015 21:43
at that point just do your own regex, hehe
i see in semver they have some concept called "loose", maybe that helps?
Gullit Miranda
@gullitmiranda
Sep 24 2015 21:46
Yes, if I'm not mistaken I've used it in the suggestion.
Slobodan Mišković
@slobo
Sep 24 2015 21:48
        var validDockerVersion = semver.gte(currentDockerVersion, minDockerVersion);
i think you add true as another parameter and it should pass
but interesting, i did some system upgrades and it's like problem went away, even when I revert the code, it still works
Gullit Miranda
@gullitmiranda
Sep 24 2015 21:54
good, you can make a PR with the fix?
Slobodan Mišković
@slobo
Sep 24 2015 21:59
#527
Gullit Miranda
@gullitmiranda
Sep 24 2015 22:00
cool. tks