These are chat archives for baconface/php-webkit

2nd
Apr 2015
Austin Turnage
@wookiecooking
Apr 02 2015 01:30
dope
thats gonna be a interesting build in its self. I sent a PR with your recommendations. Like i said I dont see tests being extremely important at the moment while we work out kinks, the one test in there just makes sure phpbridge exists. But this could also be a excellent time to discuss this, because as we start to discuss porting things over, we can make unit tests for them.
Brad Metcalf
@baconface
Apr 02 2015 03:02
Just got home. Will try and work on session/cookie issues.
Accepted the PR. I agree, not a big issue. Just good we found a cross platform solution that isn't causing issues.
Brad Metcalf
@baconface
Apr 02 2015 03:14
Austin Turnage
@wookiecooking
Apr 02 2015 12:47
Thats a pretty impressive project, sqlite support too
Brad Metcalf
@baconface
Apr 02 2015 14:52
@wookiecooking I made you a member of the repo. This way I can submit PRs and you can do a code review on them as well as you send a PR and I do a review.
Brad Metcalf
@baconface
Apr 02 2015 18:58
I got sqlite support into php-webkit. Added bin directory for php and sqlite. PHP-webkit will shell sqlite if a sqlite binary is found. Will submit a a PR tonight after I test on my Linux box at home.
Brad Metcalf
@baconface
Apr 02 2015 20:00
Which I am not gonna do. Lulz.
SQLlite is supported by PHP out of the box.
I got confused and thought April 1st was today.
My lame attempt at a joke.
Austin Turnage
@wookiecooking
Apr 02 2015 20:03
lololololololol
its cool
Brad Metcalf
@baconface
Apr 02 2015 20:06
Out of All seriousness though I am adding a bin folder. I am considering making it look for php in it. If not found it defaults to shelling 'php-cgi'. What do you think?
Austin Turnage
@wookiecooking
Apr 02 2015 20:10
awesome
because even if, we can branch out this project to other languages
maybe even make a "company" type account and just have different variants
but yeah i like that idea
Brad Metcalf
@baconface
Apr 02 2015 20:12
Yeah. I bet with a little modification it will interface with other fast-cgi languages like python and Ruby.
I don't have experience with either language to know what would be required env settings to run it on express. But I really believe it is doable.
Brad Metcalf
@baconface
Apr 02 2015 22:20
If I put this in the PHP folder would this ignore all files and folders but my readme and gitignore?
*
!readme.md
!.gitignore
!README.md is going to be renamed to README.md by the way.
Austin Turnage
@wookiecooking
Apr 02 2015 22:29
for .gitignore?
But yes, that is correct, you could ignore a folder, say dist/*, but if you do something like !dist/readme.md it wont ignore it
Brad Metcalf
@baconface
Apr 02 2015 22:36
So I should do this in the main .gitignore then?
bin/php/*
!bin/php/README.md
Austin Turnage
@wookiecooking
Apr 02 2015 22:37
yes
Brad Metcalf
@baconface
Apr 02 2015 22:37
Cool, thanks
Austin Turnage
@wookiecooking
Apr 02 2015 22:37
np
I also work on another project called ignite, its a scaffolding cli similar to yeoman, Im gonna make a structure for php-webkit, this way people can scaffold applications for it easier as well.
Brad Metcalf
@baconface
Apr 02 2015 22:39
Awesome.
Austin Turnage
@wookiecooking
Apr 02 2015 22:39
I was also considering a yeoman generator as well
Im gonna make issues for them and self-assign
Brad Metcalf
@baconface
Apr 02 2015 23:34
So this doesn't change the bin that is executed when file isn't found. Is this a closed scope for the bin var?
fs.stat(bin, function(err, stats) { 
    if(err || !stats.isFile()) { 
        bin = 'php-cgi';
    }
});
I can send it to console so I know it works. Just my executed bin is still my invalid file.
Austin Turnage
@wookiecooking
Apr 02 2015 23:37
most likely closed, can you pass it to a global?
weird
Brad Metcalf
@baconface
Apr 02 2015 23:38
Yeah, I just confirmed it is a closed scope.
Austin Turnage
@wookiecooking
Apr 02 2015 23:38
figures
Brad Metcalf
@baconface
Apr 02 2015 23:40
It is the module scope. Good to know for this one.