Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Nipuna Ransinghe
    @NipunaRanasinghe

    i really have doubts how it will behave if the same LanuageClientComponent is registered as ApplicationComponent by many plugins :(

    I've discussed this matter with one of our architects as well and as I've mentioned before, both approaches have their pros and cons... Although Making this a plugin will solve the potential of conflicting with the other plugins, we may lose the most useful feature of this project, which is extendability of the LSP for custom requirements. (One of the main reasons why we had to deviate from our good old scala plugin :/ )

    Therefore the our decision was to maintain both (library and a wrapper plugin). So in addition to the language client, we can maintain the wrapper plugin in the same repo and publish to the jetbrains plugin repository on each new lang client release. WDYT?
    Nipuna Ransinghe
    @NipunaRanasinghe

    Have we done a release with all the new changes?

    Yeah! 0.93.0 release is available on jitpack with all the new changes (I'll add the release note soon)

    gayanper
    @gayanper
    @NipunaRanasinghe great wrapper plugin looks like a good idea. Lets move forward with this.
    Nipuna Ransinghe
    @NipunaRanasinghe
    @gayanper great! I can start working on this during the next 2 weeks :) Let's get this done before the 1.0
    Oliver Nybroe
    @olivernybroe
    Hi, just found this plugin and it looks pretty promising.
    We have a new language we are starting to create and was thinking of going the LSP way.
    However, when I look at the example in the docs, there are no color highlighting, is this not supported or just not part of the example?
    Oliver Nybroe
    @olivernybroe
    I know that LSP does not have highlighting. Just wondering if you guys have made some easy way to add it through this package?
    gayanper
    @gayanper
    @olivernybroe you can use TextMate templates with the TextMate plugin for intelliJ
    gayanper
    @gayanper
    @NipunaRanasinghe here a small PR to improve symbol support when there are duplicate names. ballerina-platform/lsp4intellij#133
    Oliver Nybroe
    @olivernybroe
    Thanks! Helps a lot.
    gayanper
    @gayanper
    @NipunaRanasinghe here is another PR ballerina-platform/lsp4intellij#134. May be this might be the reason some of our friends had problems with Diagnostics (just a wild guess)
    gayanper
    @gayanper
    I automated unofficial build pipeline to build lsp4intellij from my fork. This was done to support the development of sts4 intellij extension. If you are interested you can grab latest builds from https://dl.bintray.com/gayanper/maven/
    Please note that there are not snapshots but rather timestamped release due to bintray not supporting snapshots
    gayanper
    @gayanper
    @NipunaRanasinghe I have added some more PRs over this weekend while working on the STS4 plugin. Please look at them and see if they are fit to merge.
    gayanper
    @gayanper
    add support for icon provider ballerina-platform/lsp4intellij#144
    gayanper
    @gayanper
    @NipunaRanasinghe Another PR for renaming watched files ballerina-platform/lsp4intellij#147 and NPE fix the symbol contributor ballerina-platform/lsp4intellij#146
    gayanper
    @gayanper
    @NipunaRanasinghe @rasika any update on this project ? You guys busy with bal again ?
    gayanper
    @gayanper
    Another PR for support adding clickable links in quick docs and navigating to source files ballerina-platform/lsp4intellij#149
    Nipuna Ransinghe
    @NipunaRanasinghe
    Hi folks
    We have some good news
    WSO2 Inc. has identified @gayanper as a very active contributor since the project initiation and he has significantly contributed to some of the key library features, improvements and fixes so far. His current contributions include 25+ reported issues and 30+ pull requests.
    Nipuna Ransinghe
    @NipunaRanasinghe
    So after having the external committership evaluation process, we are pleased to announce @gayanper as a lsp4intellij committer :)
    @gayanper I'll send you the WSO2 Contributor License Agreement soon
    gayanper
    @gayanper
    Thanks @NipunaRanasinghe
    gayanper
    @gayanper
    @NipunaRanasinghe are you planning on implementing DSP (Debug Server Protocol) client as well ? isn't it going to be needed by the ballerina language support for IDEA ?
    Nipuna Ransinghe
    @NipunaRanasinghe
    @gayanper We don't have any immediate plans on adding DAP support for Lsp4IntelliJ as I'm assigned with few other prioritized works in our ballerina language implementation, but we have already implemented DAP-based debugging support for our ballerina plugin sometimes back.
    If you are planning to work on adding DAP client implementation, you can also refer our current DAP client implementation at https://github.com/ballerina-platform/ballerina-lang/tree/master/tool-plugins/intellij/src/main/java/io/ballerina/plugins/idea/debugger
    gayanper
    @gayanper
    Hi All,
    i need some help, did you found any licensing issue when including libs which are under EPL into a Apache License project ?
    i'm trying to start a spring tools project consuming the spring language server which is EPL, and i thought to have my intellij plugin to be apache since it matches with intellij community licesensing
    Nipuna Ransinghe
    @NipunaRanasinghe
    gayanper
    @gayanper
    @NipunaRanasinghe are still live in this project ? i'm trying to spend time on spawning up Spring Tools for idea using this project. I need to know that you will maintain this project as this is part of ballerina tools as well
    Nipuna Ransinghe
    @NipunaRanasinghe
    @gayanper Yeah absolutely! We'll continue this project as this is a crucial component for our ballerina IDEA plugin. I'm not sure whether I'll be able to work on new features in the coming few weeks (as I've been assigned to few other works), but we'll be maintaining the project with fixes/improvements. So your contributions will be more than welcome, if any.
    gayanper
    @gayanper
    @NipunaRanasinghe we have some compatibility issues with IJ 2020 release train. I reported a issue. I try to provide some PR during this week if you are not planning to take it. WDYT ?
    Andrei Biasprozvanny
    @biaspro
    Hi, I am writing an intelliJ plugin for a custom language (with existing language server written in JS/Node) using this amazing library
    code completion now works, but I'm stuck on go to definition for a few days now, was wondering maybe someone could give me some pointers in how to move on
    basically, when I ctrl - click, it seems to send the right event in Either<List<? extends Location>, List<? extends LocationLink>> definition = request.get(getTimeout(DEFINITION), TimeUnit.MILLISECONDS); but keeps throwing the TimeoutException
    maybe it's possible somehow output the logs somewhere when starting the server? as you can see, I'm quite new to all the IntelliJ plugin development :)
    gayanper
    @gayanper
    Logging depends on your language server. Try to see if can debug the langauge server and see what happens. Also make sure the language server you are using is under which lsp protocol version
    Logging and debugging should be controllable from your lspserver definition
    You should be able to do the same when you build your rawcommand server definition
    Andrei Biasprozvanny
    @biaspro
    @gayanper cool thanks, I'll give it a go
    Cary Robbins
    @carymrobbins
    Heads up, cut an issue for migrating from plugin components - ballerina-platform/lsp4intellij#192
    In my own plugin I'm seeing how well I can just adapt the existing component into an application service, but long term we should migrate the lsp4intellij code to use services instead.
    Cary Robbins
    @carymrobbins
    How does the icon get registered? Does this happen automatically by adding IntelliJLanguageClient in the plugin.xml? Does this work the same for project-level LSP definitions?
    I'm also unsure of how/if lsp4intellij logs output from the connected server
    Cary Robbins
    @carymrobbins
    Ok, I was able to get the icon thing working, seems it does automatically get added by the IntellijLanguageClient application component
    Cary Robbins
    @carymrobbins
    Is there a better way to configure the INIT timeout for an LSP server than doing this?
      override def runActivity(project: Project): Unit = {
        // TODO: Oh man this is bad, but I need to make lsp4intellij wait longer than
        // the default INIT timeout of 10 seconds, so overriding it as 5 minutes.
        Timeout.getTimeouts.put(Timeouts.INIT, 5 * 60 * 1000)
    Cary Robbins
    @carymrobbins
    actually i was able to get around that
    Next: the diagnostics seem out of sync, does this happen to anyone? the diagnostics i am seeing in the source seem to be from a few edits ago
    Cary Robbins
    @carymrobbins
    May be related to this - ballerina-platform/lsp4intellij#193