Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Aaron Rosenberg
    @agrberg

    Same problem :-( the biggest changes all look like the following:

    Metrics/AbcSize:
      Exclude:
        - 'app/controller/…'
        - 'app/controller/…'

    is changed to

    Metrics/AbcSize:
      Max: 341
    The other changes seem fine and if I discard all those changes I can run rubocop without failures
    Benjamin Quorning
    @bquorning
    That indeed looks like exclude-limit not working. Did you double check that the dashed aren’t long dashes (- vs –). Perhaps add a = before 500?
    Aaron Rosenberg
    @agrberg
    My potentially incorrect assumption is that --exclude-limit should stop that from happening. I don't recall needing another option to get the file list ages ago when it was first made.
    Benjamin Quorning
    @bquorning
    Hi again @agrberg – I usually have Metrics cops disabled. But I had an idea – I enabled my Metrics counts, and re-ran auto-gen-config. And indeed, all Metrics cops just had a Max limit, and no list of Exclude files.
    I don’t know if this is a bug or a feature, and when it was introduced.
    Aaron Rosenberg
    @agrberg
    Did rubocop still report offenses with the Max limit added?
    Benjamin Quorning
    @bquorning
    I didn’t try, but I would assume not.
    Which cops did you get offense reported from after you recreated the todo?
    Aaron Rosenberg
    @agrberg
    It was definitely the metrics ones. I can get you a full list but it'll take a sec.
    Aaron Rosenberg
    @agrberg
    Actually quite a lot more than I thought. I'm not sure why they disappear when it's only the listing of files under the metrics cops that are changing. I'm going to look into a few of them and see if I can't get a better picture of what's happening.
    Benjamin Quorning
    @bquorning
    :+1:
    Aaron Rosenberg
    @agrberg
    I also posted issue #5576 today about the other Rubocop abnormality I was experiencing. I'm not sure if I have something odd with my system since I didn't see any other issues or StackOverflow posts of people with similar problems.
    Aaron Rosenberg
    @agrberg
    I was mistaken, besides a number of Lint/UnneededDisable due to the increased Max the rest were RSpec/MultipleExpectations cops from older tests
    Which is one of the groups that had a list of files replaced by a Max
    Bill Mill
    @llimllib
    I found a bug in rubocop and am attempting to repro with a test in the official repo; what's the best way to run rubocop on itself?
    Mailo Světel
    @roolo
    @llimllib https://github.com/bbatsov/rubocop/blob/master/Rakefile#L48 seems like way to go (rake internal_investigation)
    Steven Zeck
    @stevenzeck
    Hi all. Question, is there a way to get the contents from --auto-correctwhile using --stdin apart from the end of stdout? I'm having trouble splitting the string between the report and the corrections, due to ==================== followed by a newline being different based on the OS and, seemingly, editor settings
    Csaba Apagyi
    @thisismydesign
    hi, i just wrote a post on making parallel auto-correct work, i wonder what you think about it? https://medium.com/@csaba.apagyi/how-to-rubocop-parallel-auto-correct-8d4b68a22d8b
    Pedro Paulino
    @localhostpedro
    Hello everyone

    Rubocop keeps warning me about a decimal number:
    Vagrantfile:36:58: C: Style/NumericLiterals: Use underscores(_) as decimal mark and separate every 3 digits with them.
    config.vm.network :forwarded_port, guest: 27017, host: 27017 # mongodb

    But its actually a port in Vagranfile setup. Is there any way to override this setup not to identify ports as decimal numbers ?

    In order to test, I made something like this:

    config.vm.network :forwarded_port, guest: 270_17, host: 270_17 # mongodb

    And Rubucop identify as a valid setup, returning no offenses detected

    Benjamin Quorning
    @bquorning
    If Vagrantfile is Ruby, then 27017 is a numeric. And in Ruby, 27017 and 27_017 are the same number.
    Pedro Paulino
    @localhostpedro
    @bquorning I made some tests with Vagrant , and it really does forward the port without problems. I ' ll run more tests with MongoDB later on.
    Daniel Vandersluis
    @dvandersluis
    I opened a PR last week that I'd love to get some review on, how can I go about doing that?
    Jonas Arvidsson
    @jonas054
    @thisismydesign I think it's the right approach. It's difficult to combine those options within RuboCop, so a wrapper outside RuboCop is the way to go. You could also do something similar in the shell with rubocop --parallel --format files | xargs rubocop --auto-correct.
    Renato Marinho
    @renatomarinho
    This message was deleted
    Dave Anderson
    @dlanderson
    Is there a way to run a Cop with Autocorrect programmatically within Ruby against a string containing ruby code?
    Mailo Světel
    @roolo
    @dlanderson I think https://github.com/rubocop-hq/rubocop/blob/master/lib/rubocop/runner.rb#L111 Would be good starting point. Of course it'll require some playin' with it
    Dave Anderson
    @dlanderson
    Thanks @roolo I got it working
    Mailo Světel
    @roolo
    @dlanderson Through the do_inspection_loop ?
    Dave Anderson
    @dlanderson
    Would be nice to have an easier, 'official' way to do that.
    Alfonso Perez
    @alfonsoperez
    Hi there!!, I was writing a custom cop and having trouble checking of indexasgn with def_node_matcher
    there seems not to be a callback for that?
    does anybody know how to do this?
    Alfonso Perez
    @alfonsoperez
    ups whitequark/parser@7d72eba
    might then perhaps be my version
    Renato Marinho
    @renatomarinho
    This message was deleted
    Renato Marinho
    @renatomarinho
    This message was deleted
    John Vandenberg
    @jayvdb
    @renatomarinho pls stop spamming every room on gitter
    Evan Brodie
    @ecbrodie

    Hello rubofriends. Is there a way to disable an entire family/group/namespace of cops for a particular set of files?

    For example, in my project, I want to disable all "Metrics" cops for my tests, but keep them enabled for all other code. I could just disable each Metrics cop for the test files as the violations pop up, but I want to see if this functionality already exists or requires a new feature.

    Thanks

    Okay, the correct term was "department", according to the documentation. So, the "Metrics" department.

    Also, I think I just discovered that it is indeed already existing, I was able to just use Metrics:... in my YAML and it worked. Still, not entirely sure if this is the correct approach because I can't find this case mentioned in the docs.

    Simon
    @stoivo

    Hi

    We want to try follow 10 lines per method. I think is is a good rule.
    In most controllers(Rails) we have strong params and with more then 8 agrument is expands over 10 lines.
    I wonder if there is a way to tell rubocop to not check method length for methids with params in it?

    Dominic Sayers
    @dominicsayers
    @ecbrodie So something like this works?
    Metrics:
      Exclude:
        - test/**/*
    Simon
    @stoivo
    anyone?
    Mailo Světel
    @roolo
    @stoivo I don't think it can be based on content of method, but you can disable the rule for that particular method. I would rather split the something_params method or look for another way to slim it
    Simon
    @stoivo

    The think is that we want to write it like

      def file_params
        params
          .require(:file)
          .permit(
            :description, 
            :user_id, 
            :content_type, 
            :created_at, 
            :updated_at, 
            :unit_id, 
            :document_id, 
            :document_type, 
            :sort_id, 
            :is_deleted
          )
      end

    I know I could write it on one line but we want to have it like this.
    In generall we think to 10 lines method like is good. For some controllers we have more then 10 parameters and need more then 10 lines.