Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Pedro Paulino
    @localhostpedro

    In order to test, I made something like this:

    config.vm.network :forwarded_port, guest: 270_17, host: 270_17 # mongodb

    And Rubucop identify as a valid setup, returning no offenses detected

    Benjamin Quorning
    @bquorning
    If Vagrantfile is Ruby, then 27017 is a numeric. And in Ruby, 27017 and 27_017 are the same number.
    Pedro Paulino
    @localhostpedro
    @bquorning I made some tests with Vagrant , and it really does forward the port without problems. I ' ll run more tests with MongoDB later on.
    Daniel Vandersluis
    @dvandersluis
    I opened a PR last week that I'd love to get some review on, how can I go about doing that?
    Jonas Arvidsson
    @jonas054
    @thisismydesign I think it's the right approach. It's difficult to combine those options within RuboCop, so a wrapper outside RuboCop is the way to go. You could also do something similar in the shell with rubocop --parallel --format files | xargs rubocop --auto-correct.
    Renato Marinho
    @renatomarinho
    This message was deleted
    Dave Anderson
    @dlanderson
    Is there a way to run a Cop with Autocorrect programmatically within Ruby against a string containing ruby code?
    Mailo Světel
    @roolo
    @dlanderson I think https://github.com/rubocop-hq/rubocop/blob/master/lib/rubocop/runner.rb#L111 Would be good starting point. Of course it'll require some playin' with it
    Dave Anderson
    @dlanderson
    Thanks @roolo I got it working
    Mailo Světel
    @roolo
    @dlanderson Through the do_inspection_loop ?
    Dave Anderson
    @dlanderson
    Would be nice to have an easier, 'official' way to do that.
    Alfonso Perez
    @alfonsoperez
    Hi there!!, I was writing a custom cop and having trouble checking of indexasgn with def_node_matcher
    there seems not to be a callback for that?
    does anybody know how to do this?
    Alfonso Perez
    @alfonsoperez
    ups whitequark/parser@7d72eba
    might then perhaps be my version
    Renato Marinho
    @renatomarinho
    This message was deleted
    Renato Marinho
    @renatomarinho
    This message was deleted
    John Vandenberg
    @jayvdb
    @renatomarinho pls stop spamming every room on gitter
    Evan Brodie
    @ecbrodie

    Hello rubofriends. Is there a way to disable an entire family/group/namespace of cops for a particular set of files?

    For example, in my project, I want to disable all "Metrics" cops for my tests, but keep them enabled for all other code. I could just disable each Metrics cop for the test files as the violations pop up, but I want to see if this functionality already exists or requires a new feature.

    Thanks

    Okay, the correct term was "department", according to the documentation. So, the "Metrics" department.

    Also, I think I just discovered that it is indeed already existing, I was able to just use Metrics:... in my YAML and it worked. Still, not entirely sure if this is the correct approach because I can't find this case mentioned in the docs.

    Simon
    @stoivo

    Hi

    We want to try follow 10 lines per method. I think is is a good rule.
    In most controllers(Rails) we have strong params and with more then 8 agrument is expands over 10 lines.
    I wonder if there is a way to tell rubocop to not check method length for methids with params in it?

    Dominic Sayers
    @dominicsayers
    @ecbrodie So something like this works?
    Metrics:
      Exclude:
        - test/**/*
    Simon
    @stoivo
    anyone?
    Mailo Světel
    @roolo
    @stoivo I don't think it can be based on content of method, but you can disable the rule for that particular method. I would rather split the something_params method or look for another way to slim it
    Simon
    @stoivo

    The think is that we want to write it like

      def file_params
        params
          .require(:file)
          .permit(
            :description, 
            :user_id, 
            :content_type, 
            :created_at, 
            :updated_at, 
            :unit_id, 
            :document_id, 
            :document_type, 
            :sort_id, 
            :is_deleted
          )
      end

    I know I could write it on one line but we want to have it like this.
    In generall we think to 10 lines method like is good. For some controllers we have more then 10 parameters and need more then 10 lines.

    Thomas Volkmar Worm
    @tvw
    What is a reasonable default for Metrics/AbcSize? As soon as a method contains a few conditions, rubocop starts complaining. In order to satisfy rubocop, I had to split a method into two methods, though the code belongs together and makes much more sense in one method.
    Also Metrics/LineLength: I think VT100s are absolutely history. My lines are most of the time below 80, but when using a logger, a line could be longer and splitting the line just to satisfy rubocop makes the code looking very poor.
    Thomas Thomassen
    @thomthom
    Hi all. I'm working on a RuboCop extension - to aid SketchUp developers using our Ruby API. I'm currently reviewing the severity property of the custom departments we are adding. I was wondering if there was some insight to what the various levels available means?
    I've seen the list in the code, and in the docs: https://github.com/rubocop-hq/rubocop/blob/master/manual/configuration.md#severity
    But I'm curious to when to use what. In particular, is "error" supposed to be used only when RuboCop encounter an internal error processing?
    I've been using error for one department, this one have a set of cops that check for some hard requirement in order to get a SketchUp extension submitted to our Extension Warehouse (basically our app store for extensions to SketchUp)
    But is this severity level misleading?
    Found some older github issues where it seemed to be somewhat unclear exactly what severity should be applied to the different type of reporters: rubocop-hq/rubocop#633
    Steve Whittaker
    @swhitt
    P
    Casper Christensen
    @casperc91_gitlab

    Hi. I have tried to search in the docs and on the web for a Rubocop rule to use <= and < instead of > or >= in comparison, example:

    # bad
    a > 2
    3 >= b
    
    #good
    2 < a
    b <= 3
    4 < c && c <= 7

    Does anyone know if this exist or not? Can't seem to find it.

    andre francois
    @francoisa
    I have installed rubocop 0.62.0 in my rails application, but when I run "bundle exec rake new_cop[dept/name]"
    I get the error : "Don't know how to build task 'new_cop'"
    How do I create a new cop?
    Tejas Bubane
    @tejasbubane
    @francoisa That rake task is for running inside the rubocop project directory itself. For contributing new cop.
    Brandon Weaver
    @baweaver

    Bit of an out there idea I'd be interested in a sanity check on. Javascript has the idea of codemods, I kinda want to try and make the same thing in Ruby. Rubocop already has a lot of work done on top of parser, including the NodePattern syntax and autocorrect capabilities.

    Is there a possibility of generalizing the autocorrect capability into a code rewrite gem?

    This gem does some of that already - https://github.com/jonatas/fast
    Well, rather is there interest in doing that? I'd be willing to pitch in on it if so, but I'd rather not jump on an idea that's either already been done or isn't of interest to the contributors
    MrAtheist
    @MrAtheist
    Hey all, would someone be able to address this issue for me? rubocop-hq/rubocop#6567 For me specifically the exclude in Allcops doesnt work at all. Wondering if it's the inheritance thats messing it up.
    Oppen
    @Oppen
    Hi, I have a possibly dumb question.
    I've seen in the changelog people refer to their PR. How can I have the PR address before sending it?
    I mean, I'm working in my changeset, I then upload it to a branch on my fork and create a PR, but then I can't go back and change it to use the proper id afterwards.
    (I could in a different commit, after creating the PR, but I've seen it done in a single one)
    John Vandenberg
    @jayvdb
    @Oppen after you create the PR, you can add another commit to your branch and it will be included in the PR. You can also 'amend' (replace) the initial commit
    Oppen
    @Oppen
    OK. I thought of amend, but that always carried weird consequences when I forced pushed.