How can I reproduce your issue exactly?
Or you can just run: rspec on rubocop-packaging with rubocop v0.86 and v0.87.
With v0.86, the tests pass. With v0.87, the tests fail :disappointed:
Hey!
Two quick questions:
Is 0.89 going to be released soon? My hands are itching to merge the PR (in rubocop-rspec) fixing offences raised by newly introduced cops.
WDYT of bumping the version in version.rb to the next patch version? We have an edge-rubocop CI job, and it fetches RuboCop from master. It's somewhat confusing to see Using rubocop 0.88.0 from https://github.com/rubocop-hq/rubocop.git (at master@ca9483a) and failures from cops that didn't exist in 0.88.0.
I'd like a release of
rubocop-ast too.
Hi, I have a specific question:
Some additional gems, like
Some additional gems, like
rubocop-performance or rubocop-rails may be used with different versions of rubocop, can they have different cop lists in such cases? E.g.: In the first case I have rubocop-rspec version 1.42.0 and rubocop version 0.87; in the second case I have rubocop-rspec version 1.42.0 and rubocop version 0.89. Will I get the same cops in both cases?
@Pr0p1k You'll have the same RSpec cops, and you'll have a different set of base cops.
0.89 was an especially productive release with over a dozen of new cops. You can check what has been changed on the releases page https://github.com/rubocop-hq/rubocop/releases or in the https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md
0.89 was an especially productive release with over a dozen of new cops. You can check what has been changed on the releases page https://github.com/rubocop-hq/rubocop/releases or in the https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md
I am doing
corrector.remove(node.loc.expression)at the moment, but it leaves behind an empty line. I want to remove the empty line as well.
And I am not sure how to do that?
@utkarsh2102 You're probably looking for
range_by_whole_lines https://github.com/rubocop-hq/rubocop/blob/master/lib/rubocop/cop/mixin/range_help.rb#L69
Thanks a lot! This was precisely what I needed! \o/
@marcandre I think
%CONST in nodepattern doesn't work in ruby 2.4 if it's a Set (and it doesn't seem to work at all with an array). There's no test for that in rubocop-ast, but I'm getting this failure in rubocop-performance: https://app.circleci.com/pipelines/github/rubocop-hq/rubocop-performance/341/workflows/528ddd46-d4f6-4dc5-883c-fc02cc002540/jobs/2155
I'm going to open an issue on rubocop-ast
This is an example of a cop removing a method and leaving blank and empty lines behind. https://github.com/rubocop-hq/rubocop/blob/07c21d32408ecd5713578d50445387c89341815d/spec/rubocop/cop/lint/useless_method_definition_spec.rb#L103
A well-known LineLength cop relies on a number of other cops to further format the code https://github.com/rubocop-hq/rubocop/blob/07c21d32408ecd5713578d50445387c89341815d/lib/rubocop/cop/layout/line_length.rb#L20
I don't have a good understanding how
rubocop --only <dirty-cop-that-relies-on-others-to-clean-it-all-up> is supposed to work though.
Sure, indentation isn't a strict requirement. The rest should be easy but taking care of comments and heredocs makes it non trivial; there probably should be a helper for that.
In any case, I gave up doing the right thing, hacked something for my use and delegated 😆 rubocop-hq/rubocop#8724
In any case, I gave up doing the right thing, hacked something for my use and delegated 😆 rubocop-hq/rubocop#8724
Hi, when Rubocop is used by another tool, it works fine for highlighting issues, but it doesn't provide info about autocorrectability, and if the tool wants to provide option to fix the offence on the highlighted area, it has to know whether the exact offence can be corrected (may depend on context) to avoid false-positives and so on. Do you have any plans or concerns regarding this? It may be just an option like
--autocorrect-info to include it in JSON report
@Pr0p1k You can set a different output format with
rubocop --format json, and e.g. this JSON format gives you information if it's auto-correctable or not. Excerpt:{"path":"lib/rubocop/cop/rspec/describe_class.rb","offenses":[{"severity":"convention","message":"Extra blank line detected.","cop_name":"Layout/EmptyLines","corrected":false,"correctable":true,"location":{"start_line":51,"start_column":1,"last_line":52
Not really. Too many chats for me. :D
At some point it seemed to me that Gitter was declining as many projects moved their chats to other Platforms and I stopped using it.
@marcosdemelo Not sure how this option can be added to
But you should definitely give
I would suggest loading
.rubocop.yml, even though it's mentioned in the docs https://github.com/rubocop-hq/rubocop/blame/c1b7dce1fc7af1ad13ab1fa975b31312925f6109/docs/modules/ROOT/pages/usage/basic_usage.adoc#L259But you should definitely give
RUBOCOP_OPTS a try.I would suggest loading
RUBOCOP_OPTS with https://github.com/direnv/direnv, but it's only my personal preference.
Hi everyone :)
We at Codacy use rubocop ( it works very well, I have to say ).
Now we're adding a feature to comment on PRs with the suggested changes by tools.
I'm trying to integrate this with rubocop.. Is there a way to have the autocorrection for a cop inside the json report? The only way out I see is to run the autocorrect, generate a diff, and manually match the diff to the cops in the json report..
Do think it's doable to add the modified line or the changes to the json report ?
We at Codacy use rubocop ( it works very well, I have to say ).
Now we're adding a feature to comment on PRs with the suggested changes by tools.
I'm trying to integrate this with rubocop.. Is there a way to have the autocorrection for a cop inside the json report? The only way out I see is to run the autocorrect, generate a diff, and manually match the diff to the cops in the json report..
Do think it's doable to add the modified line or the changes to the json report ?