Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 01:34
    multimeric commented #3618
  • May 18 23:06
    w-gao synchronize #3597
  • May 18 23:06

    w-gao on 2131-configurable-metrics-port

    Review comments (compare)

  • May 18 17:18
    adamnovak edited #3618
  • May 18 17:18
    adamnovak commented #3618
  • May 18 09:56
    unito-bot edited #3620
  • May 18 09:56
    multimeric opened #3620
  • May 18 08:38
    mr-c commented #3619
  • May 18 07:51
    multimeric commented #3618
  • May 18 07:47
    multimeric commented #3619
  • May 18 07:47
    mr-c commented #3618
  • May 18 07:45
    mr-c commented #3619
  • May 18 06:09
    unito-bot edited #3619
  • May 18 06:09
    multimeric opened #3619
  • May 18 02:18
    multimeric commented #3618
  • May 18 02:16
    unito-bot edited #3618
  • May 18 02:16
    multimeric opened #3618
  • May 18 02:02
    unito-bot edited #3617
  • May 18 02:01
    multimeric opened #3617
  • May 17 18:25
    adamnovak edited #3599
karma29
@karma29:matrix.org
[m]

hello! just curious about the code here : https://github.com/DataBiosphere/toil/blob/master/src/toil/cwl/cwltoil.py#L736

mutable is by default set to false, which means that there is no downloaded copy of the file (and a link to it is created instead). in the function call examples, there wasn't any explicit declaration of mutable to true, so do they exhibit "streamable" properties? what more changes should we make here?

karma29
@karma29:matrix.org
[m]
actually i'm a gsoc'21 applicant so i wasn't sure if it would be more suitable to reply to the comment threads on github or join the irc. what's recommended though? i'm fine with either! 😃
Lon Blauvelt
@DailyDreaming
[Adam Novak, UCSC GI] We watch Github issues, and the chat here, but not really Github code comments. Either there or here is fine; here is maybe better fro questions that are not themselves bugs.
[Adam Novak, UCSC GI] I think the idea behind CWL streamable is that you will get a pipe (a FIFO) presented to the tool instead of a normal file? I'm not really sure.
Peter Amstutz
@tetron
yes
Lon Blauvelt
@DailyDreaming
[Adam Novak, UCSC GI] Anyway, readGlobalFile produces an ordinary file, with a filename and all the data on disk. It might be given via a symlink, and the lack of mutable means the user code isn't allowed to modify it, as other jobs may be using the same copy.
Peter Amstutz
@tetron
and if the data is coming from a remote location, it can be streamed incrementally instead of waiting for a full download
Lon Blauvelt
@DailyDreaming
[Adam Novak, UCSC GI] Toil already has a file_store.readGlobalFileStream function, but that returns a Python file object, and doesn't currently produce a FIFO on disk. So I think getting CWL streamable support would involve handling streamable requests from CWL by using file_store.readGlobalFileStream and producing a FIFO and a thread to fill it with data.
Michael R. Crusoe
@mr-c
Or by using a third party utility to achieve the same thing, given the s3 url
karma29
@karma29:matrix.org
[m]

okay, i see! thank you 👍️ so we need to implement a FIFO process for

  1. a sequence of files (irrespective of whether they're downloaded or not, because i think right now it waits for all the input files to be processed to release the outputs?)
  2. a sequence of data within the file, in case the file comes from a remote location or s3 url (so we don't need to download it)
  3. combination of the above two, if there are more files from a remote location or s3 url in the pipe

is that correct?

Lon Blauvelt
@DailyDreaming
@karma29:matrix.org I'm sorry, it seems the matrix.org connection doesn't sync to our slack channel, so your message was missed. In general, this will need to be one FIFO per file. I would focus on the AWS s3 functionality alone first.
I'll try to check the gitter manually more often.
Michael R. Crusoe
@mr-c
@DailyDreaming does your slack connection sync via gitter? Maybe switch to directly syncing your slack channel with the matrix version?
Lon Blauvelt
@DailyDreaming
I'll try that.
Thanks!
karma29
@karma29:matrix.org
[m]
Okay! Is there a link to the slack group i can join?
1 reply
I'd be grateful if you could give feedback on it! I'm a bit confused regarding how we would actually implement streamable properties, except for the part where we change file_store.readGlobalFileStream so any inputs regarding that would be much appreciated
karma29
@karma29:matrix.org
[m]
Also is a "job class" a Python class? I have heard of text files getting pickled. So does a job class getting pickled mean that the job class is being implemented as an object and then their contents being pickled to a file?
Lon Blauvelt
@DailyDreaming
[Adam Novak, UCSC GI] The jobs in Toil are instances of various "job classes", like CWLJob and JobFunctionWrappingJob. We do indeed instantiate these classes and then pickle the resulting objects into files.
karma29
@karma29:matrix.org
[m]

Okay, thank you for the feedback!

I've made some changes - if it looks good, may I go ahead and submit the proposal?

karma29
@karma29:matrix.org
[m]

Hello!

Just a follow-up to my previous message, since there's ~ 2 hours for the submission to end 😃 crusoe @DailyDreaming

1 reply
karma29
@karma29:matrix.org
[m]
Thank you, just updated with another query. Can you please check the doc? Thank you crusoe @DailyDreaming
Dennis R Kennetz
@drkennetz
Is it appropriate to post job openings in here? We have a more senior position open that is CWL/toil related for bioinformatics.
Michael Milton
@TMiguelT
Is there any interest in my suggestion here: https://github.com/DataBiosphere/toil/issues/1768#issuecomment-818475173 ? I'd be happy to give it a go if it's okayed by a maintainer
Lon Blauvelt
@DailyDreaming
[Adam Novak, UCSC GI] It sounds like a good idea to me!
Lon Blauvelt
@DailyDreaming
@drkennetz That's fine by me.