w-gao on 2131-configurable-metrics-port
Review comments (compare)
hello! just curious about the code here : https://github.com/DataBiosphere/toil/blob/master/src/toil/cwl/cwltoil.py#L736
mutable is by default set to false, which means that there is no downloaded copy of the file (and a link to it is created instead). in the function call examples, there wasn't any explicit declaration of mutable to true, so do they exhibit "streamable" properties? what more changes should we make here?
streamableis that you will get a pipe (a FIFO) presented to the tool instead of a normal file? I'm not really sure.
file_store.readGlobalFileStreamfunction, but that returns a Python file object, and doesn't currently produce a FIFO on disk. So I think getting CWL streamable support would involve handling streamable requests from CWL by using
file_store.readGlobalFileStreamand producing a FIFO and a thread to fill it with data.
okay, i see! thank you 👍️ so we need to implement a FIFO process for
is that correct?
file_store.readGlobalFileStreamso any inputs regarding that would be much appreciated
Okay, thank you for the feedback!
I've made some changes - if it looks good, may I go ahead and submit the proposal?