Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Benjamin Kampmann
@gnunicorn
the persona system?
Ethan Miller
@ezmiller
Yes.
Benjamin Kampmann
@gnunicorn
yeah. I strongly think so. it was one of the major shortcomings of most systems.
(like … discourse. no difference between their system-bot and any logged in person – is just awkward.)
though I am sure this will come a with a range of other complications :D
Ethan Miller
@ezmiller
what doesn’t!
Benjamin Kampmann
@gnunicorn
ahaha! yes, that's the spirit!
Benjamin Kampmann
@gnunicorn
@ezmiller I’m adding some tests, because this persona stuff is complex and easy to mess with.
those are tests in between the total unit-tests and the functional tests we had before – running a fake app context
(with a database and all)
Ethan Miller
@ezmiller
Okay, look forward to seeing them on the PR>
Benjamin Kampmann
@gnunicorn
if you want to do some tests for the pagination, I think that’d be a great way to not only ensure you are understanding what is happening but also to make sure it stays that way :D
Benjamin Kampmann
@gnunicorn
pushed. here is an example – beavyHQ/beavy@aab2581
Benjamin Kampmann
@gnunicorn
and having tests already fixed a bug in my implementation beavyHQ/beavy@3784598 \o/
Ethan Miller
@ezmiller
Sounds like a good idea. I was thinking about testing the schema the other day to see how things were working.
Regarding test location: I saw you put those in beavy/tests
What’s our guide here?
Though I read in the docs that you suggested putting them in the same location as the file being tested...
Benjamin Kampmann
@gnunicorn
well. so. I think pytest looks in a tests/ folder for the configtest.py, that’s why I did that.
that previous suggestion was for very small tests of only that one module, that’s where that idea originated from. the tests I just added are multi-module, more complex tests, and I didn’t want them messing in the normal code base
I can the argument of moving everything into the tests subfolder. though for beavy_modules and apps that might be overkill. everything ending with “test.py” will be found anyways.
Benjamin Kampmann
@gnunicorn
one argument I could see for having a top-level tests/ folder is because we could exclude those from the deploy easily. However – this is neglectable size so, what would be the point?
@ezmiller where and when tonight?
Ethan Miller
@ezmiller
@ligthyear dinner tonight around 8 in mitte?
Benjamin Kampmann
@gnunicorn
I am (currently) at Co-Up in xBerg. Can also can do closer to your home, if you want.
Ethan Miller
@ezmiller
Oh, okay, that might be good. I’m tired of all the places I go eat, though. Thoughts?
Korean?
I hear there are some good spots, but dont’ know them.
Benjamin Kampmann
@gnunicorn
I have no extensive knowledge of places here though ;)
north mitte is more my place of expertise..
there is kimchi princess / angry chicken.
Ethan Miller
@ezmiller
Do you know either of them? Any good?
Benjamin Kampmann
@gnunicorn
kimchi princess is nice, angry chicken is only korean chicken.
for berlin standards they are pretty good.
but also hipster-ish and loud, so not really the place I’d suggest for tonight.
Ethan Miller
@ezmiller
Kimchi Pricess?
Anywhere you want to go? North mitte is fine as well.
Benjamin Kampmann
@gnunicorn
lemme do some research and get back to you :)
Ethan Miller
@ezmiller
Okay
Benjamin Kampmann
@gnunicorn
oh. wait. it is thursday! isn’t it markthalle neun’s food day today?
\o/
Yes. Let’s go there
Sound good?
I’d suggest a little earlier though, if you don’t mind.
Benjamin Kampmann
@gnunicorn
ok. I have little bit of a pickle now. the way we were handeling the database migrations doesn’t actually work as I thought it was.
because you can only declare dependencies into one direction, but not declare that one migration has to run before another, the dependencies of our private messages on the user model are breaking the migrations in the persona branch now.
looks like I have to re-evaluate that part of the architecture.
Ethan Miller
@ezmiller
Good question.
Benjamin Kampmann
@gnunicorn
the way that could be solved for now is (as we are already excepting the personas as a breaking change) scratch all migrations and start with a blank-slate and the offline state .