Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Benjamin Kampmann
@gnunicorn
Yes. Let’s go there
Sound good?
I’d suggest a little earlier though, if you don’t mind.
Benjamin Kampmann
@gnunicorn
ok. I have little bit of a pickle now. the way we were handeling the database migrations doesn’t actually work as I thought it was.
because you can only declare dependencies into one direction, but not declare that one migration has to run before another, the dependencies of our private messages on the user model are breaking the migrations in the persona branch now.
looks like I have to re-evaluate that part of the architecture.
Ethan Miller
@ezmiller
Good question.
Benjamin Kampmann
@gnunicorn
the way that could be solved for now is (as we are already excepting the personas as a breaking change) scratch all migrations and start with a blank-slate and the offline state .
but that doesn’t help is, when this happens again in the futurre.
Benjamin Kampmann
@gnunicorn
ok. so, while I can ensure the order of migrations that would have to run now, I can’t make the one in the branch follow in the same order.
Benjamin Kampmann
@gnunicorn
ok. so. I don’t think what we want to do is actually reliably possible.
instead, we will have to have all migrations in one place and have each migration know itself whether it has to do stuff for a certain feature or not. Which would mean that you can’t activate any plugin later any anymore as we might have run and applied empty migrations they relied on.
which is a major drawback and key point of even having the migrations split up in the first place.
that is not ok.
the other question I derive right now is: aside from this major change in architecture, are we really expecting further such big changes? How often?
because if not, than this is the lesser problem to solve. then we split it here and recreate the base.
Benjamin Kampmann
@gnunicorn
lunch time !
Ethan Miller
@ezmiller
Will read up on all this before we meet tonight.
Markthalle sounds good, although it can be loud I suspect. If so, though, there are palces to head to nearby. The Egypianplace by Goerli, the Markethalle restaurant (with good schnitzel) etc…
Benjamin Kampmann
@gnunicorn
:)
Benjamin Kampmann
@gnunicorn
I see your point. But I want that food. I am happy to move into a quieter place right after. It is street food after all. 10min and you are done. Different in a restaurant like Kimchi Princess. Let’s say 7 there? (or 7h30 if you need more time)?
Ethan Miller
@ezmiller
Need a bit more I suspect, have some calls. So 7:30 okay?
Looking forward!
Benjamin Kampmann
@gnunicorn
7-30 works. see ya then.
Benjamin Kampmann
@gnunicorn
I think it might be an unsolvable problem. I’ll elaborate that tonight.
Ethan Miller
@ezmiller
is this migrations issue threatening the basic modularity principle then?
Benjamin Kampmann
@gnunicorn
only on the database level.
specifically the migration of that layer.
Ethan Miller
@ezmiller
Right, which is an important level :)
Benjamin Kampmann
@gnunicorn
no. not at all.
Yes. Yes it is.
Ethan Miller
@ezmiller
Haha
Benjamin Kampmann
@gnunicorn
but that is also one of the things we are doing with this frameworks. Don’t shy away from these complicated problems, but provide actual solutions to them.
Ethan Miller
@ezmiller
Yes
Benjamin Kampmann
@gnunicorn
Like migrations path between modules/plugins and core development.
Ethan Miller
@ezmiller
Problem being a bit that existing migration libraries aren’t flexible enough for such a versatile app?
Benjamin Kampmann
@gnunicorn
as said, I think it might be unsolvable in the bigger sense.
I can explain here or tonight, as you want.
Ethan Miller
@ezmiller
Okay
Benjamin Kampmann
@gnunicorn
beavyHQ/beavy#100 is fixed BTW
thx
Ethan Miller
@ezmiller
Late sorry!
Ethan Miller
@ezmiller
Arrived
Or that rather very early!!!
Haha
Ethan Miller
@ezmiller
At the bat in the corner nearby
/bar
Tante Lisbeth
Benjamin Kampmann
@gnunicorn
@ezmiller back when I was doing the first iteration of the JSON-API implementation, there was little in libs out there and I settled with marshmallow-jsonapi for that reason. but looking around now, I see so much better stuff. I’ll check out and play with http://ripozo.readthedocs.org/en/latest/ and maybe rebuild our backend with that.