Currently, you will need to pass those props explicitly to the component since it gets generated outside of the component lifecycle (see
pager.jsx); I would recommend creating constants for pageIndex, pageSize, and making dataSource a utility that you can import. Since sort and filterFields can be managed as external state variables, there's not an awesome way to get those incorporated as props without the user explicitly passing them.
That being said, I could see the grrid passing
stateKey and pageSize as default props to the custom component.
I do think that
pageIndex will probably need to be managed by your custom component, since that behavior will no longer be triggered by the default grid pager.
Let me know what you think, and if you'd like to open an issue to get some of these props by default, that sounds good to me, but like I said there are some limitations to what we can probably pass.
ok, thanks for the answer. i'm already pass them explicitly, it works fine for me.
One more question, I have a problem with cyrillic symbols. When I pass them in columns for grid I have an error:
keyGenerator.js:21 Uncaught DOMException: Failed to execute 'btoa' on 'Window': The string to be encoded contains characters outside of the Latin1 range
there is an answer on stackoverflow:
http://stackoverflow.com/questions/23223718/failed-to-execute-btoa-on-window-the-string-to-be-encoded-contains-characte
it says:
If you have UTF8, use this (actually works with SVG source), like:
btoa(unescape(encodeURIComponent(str)))
And it helped
One more question, I have a problem with cyrillic symbols. When I pass them in columns for grid I have an error:
keyGenerator.js:21 Uncaught DOMException: Failed to execute 'btoa' on 'Window': The string to be encoded contains characters outside of the Latin1 range
there is an answer on stackoverflow:
http://stackoverflow.com/questions/23223718/failed-to-execute-btoa-on-window-the-string-to-be-encoded-contains-characte
it says:
If you have UTF8, use this (actually works with SVG source), like:
btoa(unescape(encodeURIComponent(str)))
And it helped
Hi.
There is function setPageAsync in pagerActions where after api request you call dispatch({
type: PAGE_REMOTE,
pageIndex: pageIndex,
stateKey
});
it may be necessary to add the same dispatch in setPageIndexAsync after dataSource call, because now when I call setPageIndexAsync action pager doesn't change.
And also in ColumnManager there is an error in doSort function:
const pageIndex = pagerState
&& pagerState.get(pageIndex)
? pagerState.get(pageIndex)
: 0;
so pageIndex always equals 0, so we need to change to like this:
const pageIndex = pagerState
&& pagerState.get('pageIndex')
? pagerState.get('pageIndex')
: 0;
after all this fixes we will have an actual pageIndex. And what do you think about passing pageIndex in to dataSource call in doRemoteSort function?
Also there is almost the same error in ColumnManager in doSort function:
const pageSize = pagerState
&& pagerState.pageSize
? pagerState.pageSize
: DEFAULT_PAGE_SIZE;
pageSize always eq to DEFAULT_PAGE_SIZE, I can fix it to. As you advised me I created constant pageSize and use it everywhere I need, but why don't you store it in Pager as well as pageIndex? I can add it as well if it won't break anything.
There is function setPageAsync in pagerActions where after api request you call dispatch({
type: PAGE_REMOTE,
pageIndex: pageIndex,
stateKey
});
it may be necessary to add the same dispatch in setPageIndexAsync after dataSource call, because now when I call setPageIndexAsync action pager doesn't change.
And also in ColumnManager there is an error in doSort function:
const pageIndex = pagerState
&& pagerState.get(pageIndex)
? pagerState.get(pageIndex)
: 0;
so pageIndex always equals 0, so we need to change to like this:
const pageIndex = pagerState
&& pagerState.get('pageIndex')
? pagerState.get('pageIndex')
: 0;
after all this fixes we will have an actual pageIndex. And what do you think about passing pageIndex in to dataSource call in doRemoteSort function?
Also there is almost the same error in ColumnManager in doSort function:
const pageSize = pagerState
&& pagerState.pageSize
? pagerState.pageSize
: DEFAULT_PAGE_SIZE;
pageSize always eq to DEFAULT_PAGE_SIZE, I can fix it to. As you advised me I created constant pageSize and use it everywhere I need, but why don't you store it in Pager as well as pageIndex? I can add it as well if it won't break anything.
I don't think it's irrelevant, would you liked it passed as props to the custom pager component? The reason currently no props are passed is that I didn't want to make an assumption about what props a user would want -- however, I'm fine with passing default props like
pageSize, pageIndex, and perhaps dataSource.
Here is a explanation from Dan Abramov https://medium.com/@dan_abramov/two-weird-tricks-that-fix-react-7cf9bbdef375#.pa1vz1phv