These are chat archives for beniz/deepdetect

13th
Jun 2018
Emmanuel Benazera
@beniz
Jun 13 2018 16:24
@cchadowitz-pf hi, FYI, your PR #425 is fine. We're setting proper CI on our side and linking it to github. This should not take too long to reach the master branch, and I'll start merging pending PRs then.
cchadowitz-pf
@cchadowitz-pf
Jun 13 2018 16:25
cool, thanks!! I think the only potentially outstanding question I'd have regarding #425 is if there is a better way to grab the correct version of dlib at build time. currently it's configured to simply grab the latest from the master branch, although dlib does have proper tagged releases. If you know of a way to always link to the latest 'release' tag on github I can switch to that instead, which would probably be good...
Emmanuel Benazera
@beniz
Jun 13 2018 16:41
It is best to freeze on a release tag if dlib is changing quickly
the only lib for which we fetch the latest is xgboost since it's mature, and it still breaks every three months
another way we use for Caffe2 is to temporarily freeze on a commit hash
I don't know how to fetch the latest release
cchadowitz-pf
@cchadowitz-pf
Jun 13 2018 16:55
:+1: i will change it to either point at the current latest release (and update it as necessary as new releases come out) or use a commit hash
Emmanuel Benazera
@beniz
Jun 13 2018 18:05
Ok thanks, sounds the most secured and up to date as well.
cchadowitz-pf
@cchadowitz-pf
Jun 13 2018 18:06
:+1: