Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Rashad Aliyev
    @sambua
    Will be thankfull if you could checkout new changes and left feedbacks ))
    Also Oliver, I need your support, when I’m user will make fullscreen and try to out from this button with exit_fullsize will work ok, only issue occurr when they will try to exit wiht Esc
    I’ve added new eventListener, when fullscreened but it works only in second press
    Probably it’s browser related issue, but maybe I’m not using correct way. Please when you have time just look these line [https://github.com/betajs/betajs-media-components/blob/master/src/dynamics/video_player/player/player.js#L290]
    Oliver Friedmann
    @oliverfriedmann
    Of course, will check the updates.
    Will check the ESC as well - but isn’t ESC handled by the browser itself?
    Rashad Aliyev
    @sambua
    Hi Oliver, yes sure, it’s handle by browser, but I also had to let know to player that it’s in minimized view not full screen. So why I’m trying to add some listener for ESC press action in fullscreen mode.
    Oliver Friedmann
    @oliverfriedmann
    maybe you can use this:
    Oliver Friedmann
    @oliverfriedmann
    Yup, that works
    Rashad Aliyev
    @sambua
    yes, perfect :+1: now it’s working as expected
    Oliver Friedmann
    @oliverfriedmann
    yeah - sharing looks great, too, thanks!
    Bane
    @Bane-D
    Just my personal opinion on something that looks great - if we change CSS a bit to "transition: all 0.3s ease-in-out 0.2s;" in ".ba-videoplayer-theme-modern-share-action-container" for the share option, it has enough of delay to not go out if you just move the mouse over it however it also seems more fluid when it goes out. At least for me it seems as if I am waiting for it to open/as if it is trying to push something to get opened, and the above is neither too fast nor too slow :)
    Oliver Friedmann
    @oliverfriedmann
    Agreed - @sambua can you have a look?
    Rashad Aliyev
    @sambua
    Hi Bane, Oliver, yes sure. Will change in all themes. :smile:
    Oliver Friedmann
    @oliverfriedmann
    great, thx!
    Bane
    @Bane-D
    Thank you Rashad :)