Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Rakesh Kumar Shardiwal
    @shardiwal
    JY please add this repo to coverall, i am not able to sync this repo
    Jean-Yves Sireau
    @jy-binary
    done
    Rakesh Kumar Shardiwal
    @shardiwal
    @kavehmz for Cache::RedisDB, i need to use new environment variable "REDIS_CACHE_SERVER" in place of "BOM_CACHE_SERVER". Is it possible to change it ?
    @kavehmz if yes then where should i change in my branch ? if not then can i create this new environment variable in my custom class, where i will use BOM_CACHE_SERVER to assign in REDIS_CACHE_SERVER ?
    Jean-Yves Sireau
    @jy-binary
    @shardiwal done, added to coveralls.io
    Rakesh Kumar Shardiwal
    @shardiwal
    @jy-binary you mean Fayland repo ? right
    Jean-Yves Sireau
    @jy-binary
    both added to coveralls
    Rakesh Kumar Shardiwal
    @shardiwal
    @jy-binary Great thanks
    Kaveh Mousavi Zamani
    @kavehmz
    @shardiwal I am not able to find the var, where is it?
    Rakesh Kumar Shardiwal
    @shardiwal
    @kavehmz new environment variable "REDIS_CACHE_SERVER" is used inside our CPAN module Cache::RedisDB, i am planning to use this module in BOM code base, so i would need "REDIS_CACHE_SERVER"
    Kaveh Mousavi Zamani
    @kavehmz
    Rakesh based on documents REDIS_CACHE_SERVER defaults to 127.0.0.1:6379 that is valid for us, why should we set it?
    I think we can simply leave it deafult
    Kaveh Mousavi Zamani
    @kavehmz
    Rakesh let me know if I am missing something
    Rakesh Kumar Shardiwal
    @shardiwal
    @kavehmz Ok if we are using the same settings, then we don't need it. Thanks
    Jean-Yves Sireau
    @jy-binary
    @shardiwal Rakesh, see my comment in the pull request. We are moving BOM::Utility::Cache to CPAN, so the test t/BOM/Utility/cache.t should also be moved entirely to CPAN.
    If there are any other test scripts related only to that module, they should also be moved to CPAN
    Rakesh Kumar Shardiwal
    @shardiwal
    @jy-binary test script is already there in CPAN
    @jy-binary its a duplication, i should remove it from BOM repo. I will do it today and i will keep that in my note :) thanks for verifying it.
    Jean-Yves Sireau
    @jy-binary
    thx. Indeed lets never have any duplicated code.