Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Matt Gillette
    @mattglet_twitter
    Catalin - I have more names to add to the MaleFirstNames list: Devante, Francois, Edouard
    Can I be added as a contributor to the project? That way I can create pull requests for you to review and merge.
    My github username is mattglet
    Catalin Hatmanu
    @binaryfog
    Sure, just added you as collaborator.
    Matt Gillette
    @mattglet_twitter
    Thanks Catalin, I created a PR for you to review.
    Catalin Hatmanu
    @binaryfog
    1.3.2 is now on Nuget and includes Matt hot fix for Male Names
    Tony Gravagno
    @TonyGravagno
    Still haven't reconciled all the enhancements I made with the huge changes that were made afterward. Sorry. :) I need to just go back to square one and retrofit the functionality rather than the code. This includes new parsers, names, and handling for non-english names like Del Gado or De La Fuentes-Garcia, and some cases where it's tough to figure out if a name is a middle name or a non-hyphenated lastname. I spoke with a few people who have other name lists and they were happy to contribute data to this project. I'll get that stuff together at some point too. Ciao.
    Catalin Hatmanu
    @binaryfog
    Anyone has any experience with .Net Core ? Shouldn't we upgrade the NameParser to .Net Core too?
    Tony Gravagno
    @TonyGravagno
    I think the world is going in that direction, but until there is more demand I don't think too much effort should be channelled into supply.
    Catalin Hatmanu
    @binaryfog
    Updated dependencies and bumped version number, but no package published on NuGet
    Catalin Hatmanu
    @binaryfog
    Started a new related project Nameparser.Dataset on github as a repository for names and parsed names.
    Tony Gravagno
    @TonyGravagno
    It's obvious to me that I won't have time to invest again in this code, and I'm not even using it now either. I'm working on other Git/FOSS projects and just don't have more time. So I'm going to back out of here and notices from the repo. If you think the changes I noted above are of any value, please let me know and I'll post them for your retrieval. Otherwise on your confirmation I'll back out here. Thanks for creating this fine project. I wish you well.
    Catalin Hatmanu
    @binaryfog
    Hey Tony, Sorry to hear about your leaving. If is not to much trouble for you, send me the notes , I'll post them on project wiki , maybe someone, sometime, will have the time to implement them . Wish you all the best , on your future endeavors. Thanks for all the help! C.
    Tony Gravagno
    @TonyGravagno
    TY
    Matt Gillette
    @mattglet_twitter
    Hi Catalin - I think I found an unsupported pattern: Two initials with a suffix. Here are two examples:
    R. J. Shelton Jr.
    B. J. Johnson III
    Catalin Hatmanu
    @binaryfog
    @mattglet_twitter Fixed in version 2.1.1
    Matt Gillette
    @mattglet_twitter
    Awesome, thanks @binaryfog ! I just created a new PR with a new last name too.
    Matt Gillette
    @mattglet_twitter
    Thanks again @binaryfog - can you bump the nuget version number?
    Catalin Hatmanu
    @binaryfog
    @mattglet_twitter Done.
    Matt Gillette
    @mattglet_twitter
    @binaryfog I'm having an issue that hopefully you can help with
    image.png
    This person has 2 results, one with a score of 35 and the other with a score of 200
    image.png
    image.png
    As you can see, the first result doesn't populate the LastName - but the second result does.
    Do you know why this would happen, and have any suggestions around how I should handle this?
    Catalin Hatmanu
    @binaryfog
    Identify the patterns that produces these results , increase the score of the pattern ; re-run all tests
    bhegerho
    @bhegerho
    Is this project still distributed under the Microsoft public License (Ms-PL)?
    Catalin Hatmanu
    @binaryfog
    Yes.
    mguinness
    @mguinness
    Parsing "John T. Hancock, Jr." didn't work, but "John T. Hancock Jr." did. Having a comma before the suffix causes it not to match.
    mguinness
    @mguinness

    Would it be a case of replacing:
    @"^" + First + Space + Initial + Space + Last + Space + Suffix + @"$"

    in FirstInitialLastSuffixPattern.cs to:
    @"^" + First + Space + Initial + Space + Last + OptionalCommaSpace + Suffix + @"$"

    Catalin Hatmanu
    @binaryfog
    @mguinness Fixed in the 2.2 version
    mguinness
    @mguinness
    @binaryfog Thanks for the commit and publish, I can confirm that works now. Awesome library, parsing completes on 99.655% of my records. Some names failed due to having suffixes of CPA, PhD & MD - those are in PostNominals file, but that hasn't been implemented yet.
    Catalin Hatmanu
    @binaryfog
    @mguinness Glad you like it ! All the best , Catalin
    Cloudmersive
    @Cloudmersive
    Great library!
    I am seeing though that this name is failing to parse: "Mr. Jon A. van der Waal Jr."
    Indeed, it appears that name parser does not support middle initials in general
    Opened an issue here: binaryfog/NameParser#15
    Also found a regression, logged here: binaryfog/NameParser#16
    @here any thoughts?
    Catalin Hatmanu
    @binaryfog
    @Cloudmersive Thank you for the interest in Name Parser. I'll look into the issues and working on them this week.
    Catalin Hatmanu
    @binaryfog
    @Cloudmersive Version 2.4 has been released to address the latest issues.
    mguinness
    @mguinness
    I have an issue with abbreviated first names that are 2 characters like Al or Ed. If you parse "Al Bundy" or "Ed Rooney" you get two results with the higher score setting the first name as the first character and the middle name as the second character, i.e. "A. l. Bundy" and "E. d. Rooney". I'm not sure which pattern the higher score is using but if it's TwoInitialsFirstLastSuffixPattern then maybe it should only match when both initials are uppercase?
    mguinness
    @mguinness
    I noticed a minor issue. If you try to parse a name with a trailing space, no matches are found. A possible solution is that you do a trim before parsing the string.
    Catalin Hatmanu
    @binaryfog
    @mguinness Sorry for the late reply; I'll look into it soon; been on vacation
    @mguinness I'll do that.
    Catalin Hatmanu
    @binaryfog
    @mguinness 2.5 with fixes for these issues has just been uploaded on nuget
    mguinness
    @mguinness
    @binaryfog No problem I hope your vacation was good. I can confirm that both those issues are now resolved so thank you!
    Paul Forness
    @ptforness

    @binaryfog Hi Catalin, I think I found an unsupported patten: "Last, First MI.".

    For example, my own name: "Forness, Paul T." does not get parsed.

    Catalin Hatmanu
    @binaryfog
    @ptforness The issue has been fixed in 2.5.1 version .Thank you for your help.