Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Matt Gillette
    @mattglet_twitter
    Hi Catalin - I think I found an unsupported pattern: Two initials with a suffix. Here are two examples:
    R. J. Shelton Jr.
    B. J. Johnson III
    Catalin Hatmanu
    @binaryfog
    @mattglet_twitter Fixed in version 2.1.1
    Matt Gillette
    @mattglet_twitter
    Awesome, thanks @binaryfog ! I just created a new PR with a new last name too.
    Matt Gillette
    @mattglet_twitter
    Thanks again @binaryfog - can you bump the nuget version number?
    Catalin Hatmanu
    @binaryfog
    @mattglet_twitter Done.
    Matt Gillette
    @mattglet_twitter
    @binaryfog I'm having an issue that hopefully you can help with
    image.png
    This person has 2 results, one with a score of 35 and the other with a score of 200
    image.png
    image.png
    As you can see, the first result doesn't populate the LastName - but the second result does.
    Do you know why this would happen, and have any suggestions around how I should handle this?
    Catalin Hatmanu
    @binaryfog
    Identify the patterns that produces these results , increase the score of the pattern ; re-run all tests
    bhegerho
    @bhegerho
    Is this project still distributed under the Microsoft public License (Ms-PL)?
    Catalin Hatmanu
    @binaryfog
    Yes.
    mguinness
    @mguinness
    Parsing "John T. Hancock, Jr." didn't work, but "John T. Hancock Jr." did. Having a comma before the suffix causes it not to match.
    mguinness
    @mguinness

    Would it be a case of replacing:
    @"^" + First + Space + Initial + Space + Last + Space + Suffix + @"$"

    in FirstInitialLastSuffixPattern.cs to:
    @"^" + First + Space + Initial + Space + Last + OptionalCommaSpace + Suffix + @"$"

    Catalin Hatmanu
    @binaryfog
    @mguinness Fixed in the 2.2 version
    mguinness
    @mguinness
    @binaryfog Thanks for the commit and publish, I can confirm that works now. Awesome library, parsing completes on 99.655% of my records. Some names failed due to having suffixes of CPA, PhD & MD - those are in PostNominals file, but that hasn't been implemented yet.
    Catalin Hatmanu
    @binaryfog
    @mguinness Glad you like it ! All the best , Catalin
    Cloudmersive
    @Cloudmersive
    Great library!
    I am seeing though that this name is failing to parse: "Mr. Jon A. van der Waal Jr."
    Indeed, it appears that name parser does not support middle initials in general
    Opened an issue here: binaryfog/NameParser#15
    Also found a regression, logged here: binaryfog/NameParser#16
    @here any thoughts?
    Catalin Hatmanu
    @binaryfog
    @Cloudmersive Thank you for the interest in Name Parser. I'll look into the issues and working on them this week.
    Catalin Hatmanu
    @binaryfog
    @Cloudmersive Version 2.4 has been released to address the latest issues.
    mguinness
    @mguinness
    I have an issue with abbreviated first names that are 2 characters like Al or Ed. If you parse "Al Bundy" or "Ed Rooney" you get two results with the higher score setting the first name as the first character and the middle name as the second character, i.e. "A. l. Bundy" and "E. d. Rooney". I'm not sure which pattern the higher score is using but if it's TwoInitialsFirstLastSuffixPattern then maybe it should only match when both initials are uppercase?
    mguinness
    @mguinness
    I noticed a minor issue. If you try to parse a name with a trailing space, no matches are found. A possible solution is that you do a trim before parsing the string.
    Catalin Hatmanu
    @binaryfog
    @mguinness Sorry for the late reply; I'll look into it soon; been on vacation
    @mguinness I'll do that.
    Catalin Hatmanu
    @binaryfog
    @mguinness 2.5 with fixes for these issues has just been uploaded on nuget
    mguinness
    @mguinness
    @binaryfog No problem I hope your vacation was good. I can confirm that both those issues are now resolved so thank you!
    Paul Forness
    @ptforness

    @binaryfog Hi Catalin, I think I found an unsupported patten: "Last, First MI.".

    For example, my own name: "Forness, Paul T." does not get parsed.

    Catalin Hatmanu
    @binaryfog
    @ptforness The issue has been fixed in 2.5.1 version .Thank you for your help.
    Catalin Hatmanu
    @binaryfog
    Out of curiosity , on how many projects is NameParser used ? Please leave a note to tally the numbers.
    wesleybordelon
    @wesleybordelon
    Hello, I have an issue with using the name 'Caelleigh N Downer De Gutierrez' in the name parser. Could this be an unsupported name pattern?
    Catalin Hatmanu
    @binaryfog
    @wesleybordelon It is very possible, don't remember having a pattern for 3 last names. Let me see what I can do about it.
    Jamin Quimby
    @JaminQuimby
    This name used to work "President Ulysses(Hiram) S. Grant". Also I created a PR to upgrade to .NET 3.1
    Matt Gillette
    @mattglet_twitter

    @JaminQuimby @binaryfog I'm getting this error when trying to install v3.1.0: Could not install package 'BinaryFog.NameParser 3.1.0'. You are trying to install this package into a project that targets '.NETFramework,Version=v4.7.2', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.

    Is this no longer available for .NETFramework projects?

    Jamin Quimby
    @JaminQuimby
    Get the previous version, the newest version is Core. 3.1 no other changes.
    Might be better served if it were converted to .net standard. I was thinking of doing some more work in this repo to support more name formats.
    Matt Gillette
    @mattglet_twitter
    @JaminQuimby Yeah, .net standard would be MUCH more compatible (.NET Framework is not going away anytime soon :) )
    Jamin Quimby
    @JaminQuimby
    Well @mattglet_twitter I put in a PR for .net standard 2.1... standard 2.1 is still not compatable with framework only Mono/Xamarin. And .net standard is going away as their merging core and standard and calling it net5.0 Your best bet is to target a specific version, the previous 2.x versions support framework. There really is no functional diffrence at this time. 3.1 works with .net core 3.1 and the 2.x works with framework and .net core 2.x
    Matt Gillette
    @mattglet_twitter

    "no functional difference at this time" - until there is, and then @binaryfog has a maintenance problem on his hands trying to support two different versions.

    I don't have any Core experience just yet, but it seems... unlikely... that a package can't be used in both Core and Framework environments. Again, that might be my ignorance talking.

    Alejandro Guardiola
    @aleGuardiola
    Hi I have a name that I am getting everything null:
    SAWYER, JONATHAN DAVID JR
    Catalin Hatmanu
    @binaryfog
    @aleGuardiola The issue has been fixed in version 3.2.0 .Thanks for reporting it.
    dsapoznik
    @dsapoznik
    Hi, I have a name which an unexpected output: L Spaulding Richard