These are chat archives for biojs/biojs

31st
Jan 2019
Ramakrishna Pattnaik
@rkpattnaik780
Jan 31 02:44
Yeah, I have made it an exact replica of the navbar menu, do suggest changes.
Ankit Kumar
@ankits.kvmdam_gitlab
Jan 31 07:51
It would be nice if you add some thing more, like logo, some useful links
Ramakrishna Pattnaik
@rkpattnaik780
Jan 31 09:23
Okay!
And I have detected a minor bug, which I would like to fix. Do I need to create an issue before making a pull request?
Yo Yehudi
@yochannah
Jan 31 10:01
Please do make the issue, yes!
Yo Yehudi
@yochannah
Jan 31 10:20
@ankits.kvmdam_gitlab @rkpattnaik780 you two have been so busy! :heart_eyes: hopefully we'll get to the PRs over the weekend
Ramakrishna Pattnaik
@rkpattnaik780
Jan 31 12:00
Waiting :)
Ankit Kumar
@ankits.kvmdam_gitlab
Jan 31 12:43
@rkpattnaik780 are you working on footer?
Ankit Kumar
@ankits.kvmdam_gitlab
Jan 31 12:51
Screenshot 2019-01-31 at 6.20.35 PM.png
Screenshot 2019-01-31 at 6.20.49 PM.png
I am working on biojs/biojs-frontend#28 (Improve mobile nav UI). I have attached images. Please review it.
Yo Yehudi
@yochannah
Jan 31 12:57
@ankits.kvmdam_gitlab we can probably look this weekend!
Ankit Kumar
@ankits.kvmdam_gitlab
Jan 31 13:00
Should I create a pull request?
Sarthak Sehgal
@sarthak-sehgal
Jan 31 16:53
@ankits.kvmdam_gitlab I have reviewed the PR
Dennis Schwartz
@DennisSchwartz
Jan 31 17:00
Hi guys! Thanks a lot for all the PRs. Something is wrong with our CI at the moment and it’s not running the tests. I will look at it tonight and we can get it merged soon.
Ramakrishna Pattnaik
@rkpattnaik780
Jan 31 18:40
@ankits.kvmdam_gitlab , yes I am working on the footer.
Yo Yehudi
@yochannah
Jan 31 20:10
One small comment with regard to that screenshot - Google Plus is shutting down in a month or two :)