These are chat archives for biojs/biojs

21st
Feb 2019
Shubham Awasthi
@awasthishubh
Feb 21 07:24
Is anyone working on biojs/biojs-frontend#62 ?
Yo Yehudi
@yochannah
Feb 21 09:34
@awasthishubh maybe ask on the ticket is they'd mind if you pick it up?
Shubham Awasthi
@awasthishubh
Feb 21 09:46
Sure! ✌️
Nikhil Vats
@Nikhil-Vats
Feb 21 13:06
@yochannah Can you check out this issue page - biojs/biojs-frontend#58 I have added some screenshot and description of the styling issues.
Nikhil Vats
@Nikhil-Vats
Feb 21 13:14
There are 3 search components on the website -
  1. On the homepage, in the visualisation component.
  2. On the homepage, below the popular components area.
  3. On components page
    And the first one results in many styling issues as you can see on the github issue page, so I think we can remove it. What do you think @sarthak-sehgal, @yochannah?
Shubham Awasthi
@awasthishubh
Feb 21 13:21

You can use this kind of search UI

instead of appending results of existing div, you can generate search results in an overlay so that existing content won't get affected.

Yo Yehudi
@yochannah
Feb 21 13:38
That sounds sane, but I'd like to hear what @DennisSchwartz and/or @sarthak-sehgal think first ;)
Nikhil Vats
@Nikhil-Vats
Feb 21 13:41
@yochannah I think you misunderstood what I meant here - biojs/biojs-frontend#58, I have explained, can you please see the explanation and suggest what should I do?
Sarthak Sehgal
@sarthak-sehgal
Feb 21 14:41
@Nikhil-Vats let's have a search bar on homepage and try to fix the styling as per our needs.
Maybe you can try out the UI @awasthishubh suggested and see how it looks on our website.
Shubham Awasthi
@awasthishubh
Feb 21 20:03
On the edu website, as I told it's having github icon, which need to be changed to gitlab.
But site uses fontAwsome icons version 4.3.0 which doesn't have any gitlab icon.
these are the only suported icons.
Can I upgrade fontawsome library file?
Nikhil Vats
@Nikhil-Vats
Feb 21 20:19
@sarthak-sehgal @yochannah I have fixed biojs/biojs-frontend#58 and sent a PR biojs/biojs-frontend#87. This fixes all the styling issues I mentioned on the issue page without removing any component. Also, there was no link in NavBar in mobiles to go to homepage so that is also added. This fixes issue 58 and 69.
Nikhil Vats
@Nikhil-Vats
Feb 21 20:27
I am working on biojs/biojs-frontend#36 @sarthak-sehgal @yochannah.