Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Yo Yehudi
    @yochannah
    ping
    Nikhil Vats
    @Nikhil-Vats
    Thanks for this :)
    Yo Yehudi
    @yochannah
    :D
    Nikhil Vats
    @Nikhil-Vats
    I planned to do the following things in Week 1 and 2 -
    1. Improving the existing generator.
    2. Removing bugs from the Yeoman generator.
    3. Adding unit tests and e2e tests for the existing generator.
    4. Improving the tutorial for using the Yeoman generator.
    5. Adding initial features for creating new components (question to ask whether the user wants to create a new component or old component and follow-ups)
    I already updated the tutorial once and I would like to start early by adding tests (unit and e2e) for the existing generator. There are already some tests that check linting. I will search and read about various alternative we can use for tests (Yeoman-test, Jest, Mocha) and complete writing tests in 3 days hopefully. :smile:
    Nikhil Vats
    @Nikhil-Vats
    That's my plan. Any suggestions are welcome. :smiley:
    Yo Yehudi
    @yochannah
    that sounds great!
    Nikhil Vats
    @Nikhil-Vats
    biojs/generator-biojs-webcomponents#10 - I sent a PR to change generator's name from "@biojs/generator-biojs-webcomponents" to "generator-biojs-webcomponents" since the criteria for a generator to appear in Yeoman's registry is that the name should begin with "generator-".
    Yo Yehudi
    @yochannah
    :+1: Merged!
    Sarthak Sehgal
    @sarthak-sehgal
    Hey Yo, I’ve asked Nikhil to write an introductory blog at biojs.github.io
    Can you review it once (and suggest other things which we can include if needed)?
    Nikhil Vats
    @Nikhil-Vats
    I have answered these questions and sent a PR.
    Yo Yehudi
    @yochannah
    that looks fabulous!
    Nikhil Vats
    @Nikhil-Vats
    Hey guys, I sent a PR biojs/generator-biojs-webcomponents#12 to update package.json because the dependencies were outdated.
    Sarthak Sehgal
    @sarthak-sehgal
    I think Yo has already merged the PR. Just a suggestion: try giving meaningful names to the branches too. It’s a good practice. For instance, if the branch is dedicated to updating dependencies, just give it a name update-dep or update-dependencies.
    Nikhil Vats
    @Nikhil-Vats
    Sure, I will keep this in mind.
    Nikhil Vats
    @Nikhil-Vats
    Hey guys I sent a PR to fix a bug - biojs/generator-biojs-webcomponents#13
    About the bug - The logic for converting a string to camel case was wrong due to a silly mistake of me, this fixes that.
    Nikhil Vats
    @Nikhil-Vats
    Screenshot 2019-05-27 at 3.55.20 PM.png
    This image contains two new tests I wrote. I think these are sufficient considering the features we have now. If I have forgotten some test cases, please let me know. These will pass after the previous on Travis CI after the previous PR fixing the bug will be merged. I have tested them locally, all of the tests passed.
    Nikhil Vats
    @Nikhil-Vats
    I sent another PR to fix a small typo - biojs/generator-biojs-webcomponents#14. I will sent the PR for unit tests after the PR fixing the camelCase bug will be merged.
    Sarthak Sehgal
    @sarthak-sehgal
    Hey @Nikhil-Vats, thanks for the PRs. I'll review them tonight. :)
    Nikhil Vats
    @Nikhil-Vats
    Cool, thanks.
    Nikhil Vats
    @Nikhil-Vats
    Hey all, I sent a new PR - biojs/generator-biojs-webcomponents#15. This adds two unit tests. :D
    That's all the important test cases, I could think of. Please let me know if there is anything that I left.
    Screenshot 2019-05-28 at 3.25.07 PM.png
    This is the workflow I made for the generator. Please have a look and suggest improvements. I would like to discuss this asap, if you guys are free sometime so that I can work further on this.
    Yo Yehudi
    @yochannah
    that looks nicely thought out - @sarthak-sehgal anything to add?
    shall we set time for a call this week?
    Nikhil Vats
    @Nikhil-Vats
    I am free for the call.
    Yo Yehudi
    @yochannah
    @sarthak-sehgal let us know when you might be free - I'm (oddly) meeting-free this week :)
    Sarthak Sehgal
    @sarthak-sehgal
    I’m also free for a call. I had a glance at the workflow - looks good to me. Will have a detailed look once and discuss it in the call.
    @Nikhil-Vats can you update the Travis config to run the test script?
    Nikhil Vats
    @Nikhil-Vats
    Travis CI is already running the tests, I don't think I need to update the config file.
    Sarthak Sehgal
    @sarthak-sehgal
    @Nikhil-Vats the question in which you’re asking for release/commit/branch, is there a standard way to get any of them? Like if I enter “develop”, you’ll auto detect that it seems like a branch so get the latest commit/release in that branch?
    Also, when you finally put in the questions in the CLI, make sure they’re concise. For instance, to ask for a version, simply ask “Version (not required):”
    We can include in the docs that if version is not entered, latest version will be fetched.
    @yochannah any suggestions on this?
    Nikhil Vats
    @Nikhil-Vats
    Yes, I will add it in the docs for sure and will also add whether it is mandatory or not when I ask those questions.
    Nikhil Vats
    @Nikhil-Vats
    About the release and commits, I am planning to use jsDelivr which fetches the latest release/commit if not provided and I will fetch from the branch which user enters. In case, the branch name is wrong we can show him a message, something like - "this branch does not exist, do you want me to import from master branch or enter branch name again". The same thing stands for versions (npm) and commits and releases.
    Let me know if something is still unclear. I will try to present a detailed structure if possible or else I will explain and discuss it with you guys in the video call.
    Sarthak Sehgal
    @sarthak-sehgal
    @yochannah just a random thought: why don’t we shift to Slack? Gitter app is really a headache.
    Yo Yehudi
    @yochannah
    for private conversations that's fine, so long as we keep public conversations on gitter (which is easier to join publicly, unlike slack).
    let me see if I have invite rights for the biojs slack