Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Oct 11 2022 12:39
    jaytaph opened #214
  • Oct 11 2022 10:49

    jaytaph on master

    (compare)

  • Oct 11 2022 10:49

    jaytaph on main

    Redoc (#34) * Added redoc depl… (compare)

  • Oct 11 2022 10:46
    jaytaph opened #213
  • Oct 11 2022 10:45
    jaytaph opened #212
  • May 12 2022 12:19

    jaytaph on copyright-year-update

    (compare)

  • May 12 2022 12:19

    jaytaph on main

    Updated copyright year Merge pull request #211 from bi… (compare)

  • May 12 2022 12:19
    jaytaph closed #211
  • May 12 2022 12:12
    coveralls commented #211
  • May 12 2022 12:12
    coveralls commented #211
  • May 12 2022 12:09
    jaytaph closed #209
  • May 12 2022 12:09
    jaytaph commented #209
  • May 12 2022 12:09
    sonarcloud[bot] commented #211
  • May 12 2022 12:08
    jaytaph opened #211
  • May 12 2022 12:08

    jaytaph on copyright-year-update

    Updated copyright year (compare)

  • May 12 2022 12:06

    jaytaph on main

    (compare)

  • May 12 2022 12:00

    jaytaph on ci-flow

    (compare)

  • May 12 2022 12:00

    jaytaph on develop

    Fixing to a specific addlicense… documenting 1.17 requirement Merge pull request #210 from bi… (compare)

  • May 12 2022 12:00
    jaytaph closed #210
  • May 08 2022 09:16
    jaytaph edited #210
Joshua Thijssen
@jaytaph
can you check the incoming directory?
somehow, it returns to the retry queue after delivery... not sure why,.. but that we can figure out
let's try and find a time where we both are online.. that makes things much easier... i have to go now for a while
acalatrava
@acalatrava
Yes, I do have a retry for the older messages.
I’ll check incoming
Incoming is empty
I tried to send a message to you without success
time="Sep 19 13:04:39" level=debug msg="Resolving 88667a68d0976d6c9106d4a68b4097026f0daeaec1aeb8351b096637679cf350"
time="Sep 19 13:04:39" level=debug msg="POST /incoming (Returned: 202)"
time="Sep 19 13:04:39" level=trace msg="execution time: 639.129µs"
time="Sep 19 13:04:39" level=debug msg="Message ced2448c-fd74-4b0b-933f-fda94272cb25 is remote, transferring to bitmaelum.noxlogic.nl"
time="Sep 19 13:04:39" level=trace msg="getting ticket for c30ec1b200e45b413d118f66a0f3591a883f2b9cc3e95a497e7cf9da1071b4cc:88667a68d0976d6c9106d4a68b4097026f0daeaec1aeb8351b096637679cf350:"
time="Sep 19 13:04:39" level=warning msg="cannot deliver message ced2448c-fd74-4b0b-933f-fda94272cb25 remotely to 88667a68d0976d6c9106d4a68b4097026f0daeaec1aeb8351b096637679cf350. Retrying."
I’m sorry about formatting but I’m not at the computer
Joshua Thijssen
@jaytaph
No prob. Ill try to reproduce the setup here locally.
acalatrava
@acalatrava
What are your logs telling?
It seem that it’s not finding the ticket as before
Joshua Thijssen
@jaytaph
at my side..
let's check
"Returning error (412): ticket not found"
it tries to upload something with a ticket that is not valid (anymore)
Joshua Thijssen
@jaytaph
ok.. this is good.. i can replicate the issue locally... i can do some debugging to see what's going on...
Joshua Thijssen
@jaytaph
the issue seems to be with the ticket and redis storage
Joshua Thijssen
@jaytaph
it seems that I have GetLocalTicket and GetRemoteTicket mixed up
i need some better naming for this.. it's confusing
ok.. need to think a bit about this flow.. there is something not completely correct code-wise...
Joshua Thijssen
@jaytaph
yeah.. ticket generation is a bit off for tickets.. it works fine for local->local, but not for local->remote
Joshua Thijssen
@jaytaph
It seems to try to fetch an unvalidated ticket, but the system tries to look up this ticket first. The flow is a bit off here. Will newd to refactor this a bit to make more sense.. ill try to get this sorted tonight
acalatrava
@acalatrava
Great! At least you found the bug quick enough. Also I think we should get rid of external dependencies like Redis, don’t you think?
Joshua Thijssen
@jaytaph
Yes. I want to, but we prob use sqlite or something. Its pretty easy to write a new driver for those parts
Just implement the repository interface and were done :)
Ive already got the keyserver as a sqlite driver as well. Mostly for e2e testing later on
I think i only store invitation tokens and sending tokens in redis. We came up with a way to validate invitation tokens with storing them, so that is probably one datasource gone
acalatrava
@acalatrava
Use this , that way everything is Go ;)
https://github.com/boltdb/bolt
I used it in the past and it’s fast and easy to implement
Joshua Thijssen
@jaytaph
Would be easy enough to implement
Joshua Thijssen
@jaytaph
Something you would like to trybto implement?
acalatrava
@acalatrava
I’d love to! But I need to get familiar with the code first
I could try to implement the bolt thing
Also I’d like to implement the decentralized stuff for the keyserver
Joshua Thijssen
@jaytaph
the bolt is the easiest I guess
i can help you start
(i have no notifications from gitter, so i miss communication :( )
you can check out internal/ticket/redis.go. That's the implementation of the interface found in internal/ticket/ticket.go (just 3 functions)
to actually use the new bolt-code, you need to add it as a dependency to the container (internal/container/ticket.go)
(i only thing you need to change "NewRepository" to "NewRedisRepository" and "NewBoltDbRepository"
just send PR's for code review otherwise.. i can help you out
Joshua Thijssen
@jaytaph
ooh..
i've got it working!
I think that when you pull the latest version, you can send me a message... :-)
acalatrava
@acalatrava
🎉
I’ll try tonight
acalatrava
@acalatrava
time="Sep 19 21:15:55" level=trace msg="message completed for ticket e7d2c58a-27bf-44d3-8921-6e8250767245"
Joshua Thijssen
@jaytaph
hang on..
i have 2 messages in my inbox
image.png