Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 18 15:11
    kvark commented #3097
  • Nov 18 05:15
    bors[bot] closed #3097
  • Nov 18 05:15
    bors[bot] commented #3097
  • Nov 18 05:15

    bors[bot] on hal-0.4

    Backport of #3096 to hal-0.4 br… Bump gfx-backend-dx11 to 0.4.3 Merge #3097 3097: Backport of … (compare)

  • Nov 18 04:56

    bors[bot] on staging.tmp

    (compare)

  • Nov 18 04:56

    bors[bot] on staging

    Merge #3097 3097: Backport of … (compare)

  • Nov 18 04:56

    bors[bot] on staging.tmp

    Backport of #3096 to hal-0.4 br… Bump gfx-backend-dx11 to 0.4.3 [ci skip][skip ci][skip netlify… (compare)

  • Nov 18 04:56

    bors[bot] on staging.tmp

    [ci skip][skip ci][skip netlify] (compare)

  • Nov 18 04:56
    kvark commented #3097
  • Nov 18 04:12
    moxian edited #3097
  • Nov 18 04:11
    moxian opened #3097
  • Nov 18 01:54
    bors[bot] closed #3095
  • Nov 18 01:54

    bors[bot] on master

    Upgrade to smallvec 1.0 Merge #3095 3095: Upgrade to s… (compare)

  • Nov 18 01:54
    bors[bot] commented #3095
  • Nov 18 01:14

    bors[bot] on staging.tmp

    (compare)

  • Nov 18 01:14

    bors[bot] on staging

    Upgrade to smallvec 1.0 Merge #3095 3095: Upgrade to s… (compare)

  • Nov 18 01:14

    bors[bot] on staging.tmp

    Upgrade to smallvec 1.0 [ci skip][skip ci][skip netlify… (compare)

  • Nov 18 01:14

    bors[bot] on staging.tmp

    [ci skip][skip ci][skip netlify] (compare)

  • Nov 18 00:56
    bors[bot] closed #3096
  • Nov 18 00:56
    bors[bot] closed #3092
Chip Collier
@photex
so when iterating over the collection, you now have to check for a generation that equals LAST_GENERATION
if it does, then this is a disabled cell, so we skip it
did I misunderstand this?
Dzmitry Malyshau
@kvark
@photex that's correct, yes, but when are you going to actually iterate the valid handles? I don't see it in your code.
Chip Collier
@photex
you would presumably be iterating over the data that the handle refers to
now you have to include the handle generations in that work
this code wasn't entirely worked out either :)
Dzmitry Malyshau
@kvark
@photex wait, wait. "iterating over the data that the handle refers to"?
Each handle has 1 data associated. What iteration do you mean exactly?
Chip Collier
@photex
well, these handles are related to a Vector, when a system in the game performs it's update loop it's over that Vector
the iterator hasn't been implemented yet
Chip Collier
@photex
lunch time :)
Dzmitry Malyshau
@kvark
@photex oh well, so you are describing something outside of the code... I'll need to see that to understand. Perhaps, @bjz knows better what you have in mind?..
My understanding is that nothing (outside of, possibly, some debug functionality) will need to iterate the valid handles (where different types of handles are used for, to say, vertex buffers, shaders, meshes, materials, etc). The game (or for some handles - the render thread) keeps track of the handles it uses, and iterates over its own structures.
Chip Collier
@photex
nothing will iterate the handles
but they will iterate what the handles point to
if you can't make a new handle
then you can't effectively make a new item in the collection
anyway, there is clearly a problem with this design. Perhaps we should redesign it from first principles
Brendan Zabarauskas
@brendanzab
so what is the problem?
this is with the data-oriented way of doing things?
Dzmitry Malyshau
@kvark
@photex could you explain it on an example with a particular handler type?
@cmr ohi!
Brendan Zabarauskas
@brendanzab
@cmr o/
@cmr: still keeping this pretty quiet seeing as we have lots still to figure out
Dzmitry Malyshau
@kvark
@bjz I'm trying to get what's the problem with my proposal according to @photex , and so far it seems that I misunderstand the whole concept of handler management.
Brendan Zabarauskas
@brendanzab
@photex do you think this is something we can re-engineer later? It would be awesome just to get something rendering. I know this is pretty fundemental though.
@kvark gw might be on IRC soon
@kvark perhaps you could ask him - he has tons of experience with this design
Dzmitry Malyshau
@kvark
@bjz ok, will try to catch him
@bjz btw, the whole handler management thing is not required to get something rendering
Brendan Zabarauskas
@brendanzab
@kvark I reckon just implement something then we can squabble over it in a PR :)
It will probably be easier with something more concrete
Dzmitry Malyshau
@kvark
@bjz you know, I'm on my way to it...
Brendan Zabarauskas
@brendanzab
:D
sorry
Dzmitry Malyshau
@kvark
@bjz it's cool, I understand your position
Dzmitry Malyshau
@kvark
@bjz halp! Even if I introduce GlProvider trait, I can only implement it for Glfw, but we have a Window, not the context.... And the reason we are not capturing the whole context is because we want to leave event management to the user (which makes perfect sense). Piston doesn't have this problem since they are managing events internally, so they are just capturing the whole thing...
Dzmitry Malyshau
@kvark
@bjz Ok, I kinda worked my way through it, but it break a bit of platform abstraction. Passing a reference to Glfw (under my trait) as the initialization option now.
Dzmitry Malyshau
@kvark
Sadly no-one is here to share my joy,.. but the sacred triangle achievement is unlocked! See #8
Dzmitry Malyshau
@kvark
@bjz @photex Please also have a look (and express your opinion on) #9
Off for today... G'night!
Brendan Zabarauskas
@brendanzab
Sorry - just got back from a night out! This looks sooo cool. :) But I am not in the state to review right now. I will look tomorrow!
Dzmitry Malyshau
@kvark
@bjz Get a good rest, there is a lot of work ahead.
Also let me know what you think about #10. I believe that if #9 and #10 were implemented before I got the triangle, my path to it would be sufficiently more clear ;). I marked both as milestone because they are directly related to the topic of the speech at Game Tech.
Brendan Zabarauskas
@brendanzab
g'morning!
@photex are you around? :)
Brendan Zabarauskas
@brendanzab
@kvark sorry - just correcting some misconceptions on HN :P
Brendan Zabarauskas
@brendanzab
@kvark added lots of comments
@kvark I can push some changes if you like?
Brendan Zabarauskas
@brendanzab
@kvark I might implement those fixes myself and make a new PR