Where communities thrive

Join over 1.5M+ people
Join over 100K+ communities
Free without limits
Create your own community

Explore more communities

bjz/gfx-rs

A lightweight graphics device manager for Rust

People

Repo info

Activity

Jan 27 23:42

Gordon-F commented #3112
Jan 27 14:30

bors[bot] closed #3618
Jan 27 14:30

bors[bot] on master

[vk] Remove Pin usage from pipe… Merge #3618 3618: [vk] Remove … (compare)
Jan 27 14:30

bors[bot] commented #3618
Jan 27 14:15

kvark commented #3617
Jan 27 14:13

bors[bot] on staging.tmp

(compare)
Jan 27 14:13

bors[bot] on staging

Merge #3618 3618: [vk] Remove … (compare)
Jan 27 14:13

bors[bot] on staging.tmp

[vk] Remove Pin usage from pipe… [ci skip][skip ci][skip netlify… (compare)
Jan 27 14:13

bors[bot] on staging.tmp

[ci skip][skip ci][skip netlify] (compare)
Jan 27 14:13

kvark commented #3618
Jan 27 14:13

kvark synchronize #3618
Jan 27 14:11

bors[bot] commented #3618
Jan 27 14:11

alula commented #3617
Jan 27 14:10

kvark commented #3617
Jan 27 14:08

kvark commented #3617
Jan 27 14:05

bors[bot] on staging.tmp

(compare)
Jan 27 14:05

bors[bot] on staging

[vk] Remove Pin usage from pipe… Merge #3618 3618: [vk] Remove … (compare)
Jan 27 14:05

bors[bot] on staging.tmp

[vk] Remove Pin usage from pipe… [ci skip][skip ci][skip netlify… (compare)
Jan 27 14:05

bors[bot] on staging.tmp

[ci skip][skip ci][skip netlify] (compare)
Jan 27 14:04

kvark commented #3618

Coraline Sherratt

@removed~csherratt

If every string in the pipeline that is the same always points to the same memory address, we can avoid the cache miss in the case for a string compare. Pointer A == Pointer B, no point in comparing their content.

This is also 8 bytes, vs 24 that @kvark has proposed.

Brendan Zabarauskas

@brendanzab

these cached pipelines would be immutable?

like, once you commit to building them, you can't alter them?

Coraline Sherratt

@removed~csherratt

I meant gfx-rs as a pipeline, not any one object in the pipeline.

Brendan Zabarauskas

@brendanzab

ah ok

Coraline Sherratt

@removed~csherratt

I think this might be preemptive, but if we place everything behind a type that looks feels and acts like a String. We can play with optimizing it via inline strings like @kvark has proposed or some other mechanism.

Brendan Zabarauskas

@brendanzab

@csherratt what would be your transition plan in terms of moving snowmew to gfx-rs?

oh, btw - tried an oculus rift today - not with Rust, just the bundled demo.... <3 <3 awesome

Coraline Sherratt

@removed~csherratt

Snowmew is broken up into half a dozen crates, the render sits in it's own crate. So I just need to add a new crate and write a render for gfx-rs separately of the old one.

Brendan Zabarauskas

@brendanzab

nice!

it was interesting watching people use cgmath today -_-

Coraline Sherratt

@removed~csherratt

I had plans on adding an OpenGL ES render at some point, so I had the feeling I would needs some flexibility.

Good, bad, reactions?

Brendan Zabarauskas

@brendanzab

yeah that would be cool

Coraline Sherratt

@removed~csherratt

I mean, reactions to cgmath :P

Brendan Zabarauskas

@brendanzab

ohh

yeah, just some confusion

traits and stuff

I think it might be better to re-export things at the top level

Coraline Sherratt

@removed~csherratt

matrix::Matrix is a bit noisy, I can see that

Dzmitry Malyshau

@kvark

@csherratt the experience itself that you may get through porting to gfx-rs is going to be extremely valuable for us

Dzmitry Malyshau

@kvark

@csherratt sure, we can match the input-outputs and store just indices, but this caching spawns more questions than it solves

That's half-truth. In fact, we don't want (of course) to match these strings at runtime, even if the comparison cost is low, because we'd still need to walk those mesh attributes for each shader attribute. instead, we just need to have that target index baked in somewhere. Perhaps, a single HashMap<(ProgramHandle,MeshHandle), IndexSequence> will suffice.

Coraline Sherratt

@removed~csherratt

@kvark for sure.

Brendan Zabarauskas

@brendanzab

@kvark fixed #25!

Dzmitry Malyshau

@kvark

@bjz awesome! next one is the real issue - binding that at runtime

kvark @kvark is off for today

Dzmitry Malyshau

@kvark

cheers!

Brendan Zabarauskas

@brendanzab

Coraline Sherratt

@removed~csherratt

bjz, have you thought about what type of render you want to build?

Brendan Zabarauskas

@brendanzab

@csherratt we will mainly wanting to be doing procedural stuff

http://37.media.tumblr.com/tumblr_m0ww7apvCk1qgurm4o1_1280.png

http://38.media.tumblr.com/tumblr_lxkcc7WqYN1qgurm4o1_1280.png

http://37.media.tumblr.com/tumblr_lyannkY9pg1qgurm4o1_r1_1280.png

@csherratt ^

Coraline Sherratt

@removed~csherratt

how did you make these bjz?

Brendan Zabarauskas

@brendanzab

the first two are in photoshop

the last one is a mockup over an old screenshot

like, this is all my little thing could do: http://38.media.tumblr.com/tumblr_lxm7q4mHQi1qgurm4o1_1280.png

Coraline Sherratt

@removed~csherratt

So how photo realistic do you want?

Brendan Zabarauskas

@brendanzab

stuff like reflections and stars were added in later

Coraline Sherratt

@removed~csherratt

or do you want a specific style

Brendan Zabarauskas

@brendanzab

basically what you see in the first one, but I think I could push it further, and add more detail

I am heavily pushing 'ambiance' though, so it would be awesome if big mountains cast shadows that moved during the day

I mean, fields of grass waving around would be amazing

Coraline Sherratt

@removed~csherratt

Part of the long term goals of snowmew is to build a None-photo realistic render. I have an artist friend who is pushing his dream of how he wants and some of it is a pretty difficult problem.

Brendan Zabarauskas

@brendanzab

a vast plain of long grass, shimmering in the breeze - cloud systems, with layers up into the stratosphere, little villages

this is not the quality of render I want, but it gives a rough idea of a village http://38.media.tumblr.com/tumblr_lvelb6mVgz1qgurm4o1_500.png

Coraline Sherratt

@removed~csherratt

Have you played anything by "That game company" ?