bjz/gfx-rs

A lightweight graphics device manager for Rust

ember arlynx

@emberian

And getting a real slice from this would borrow.

Destructor would decrease the refcount

I think this is like a DST Rc<[T]> but I am not sure...

Dzmitry Malyshau

@kvark

@cmr If only we had a test-case for it, but we really do not. I'd come back to this problem after @bjz (or anyone else) implements the terrain example, where the buffer is updated every frame.

@cmr but Rc<> can not be sent between tasks, no?

ember arlynx

@emberian

@kvark It would have to be Arc, right.

kvark @kvark didn't know GH closes referred issues automatically

ember arlynx

@emberian

Anyone mind if I take #80?

Dzmitry Malyshau

@kvark

@cmr that would be great

ember arlynx

@emberian

Hum. Moving the backends out of device will require device to expose a lot more of its internals.

Not sure we should actually do it -- @bjz?

Brendan Zabarauskas

@brendanzab

it would be nice to componentise the backends

not sure what it would look like

perhaps we should look to piston?

ember arlynx

@emberian

oh, also, @bvssvni was asking in #rust-gamedev earlier about gfx-rs's plans, to help plan for piston.

Dzmitry Malyshau

@kvark

I see he's got some ideas on the high-level interfaces (catching up on reddit...)

ember arlynx

@emberian

Hm, it's very difficult to break the circular dependency between device and gldevice.

Due to the lack of associated types.

device uses types gldevice defines, gldevice implements traits device defines...

Dzmitry Malyshau

@kvark

macro gods are kind to me today, I've got the shader link construction implemented:

struct Params {
    b: gfx::BufferHandle,
    x: int,
    t: gfx::TextureHandle,
}
struct _ParamsLink {
    b: ::gfx::BlockVarId,
    x: ::gfx::UniformVarId,
    t: ::gfx::TextureVarId,
}
#[automatically_derived]
impl ::gfx::ShaderParam<_ParamsLink> for Params {
    fn create_link<S: ::gfx::ParameterSink>(__arg_0: &S) ->
     Result<_ParamsLink, ::gfx::ParameterLinkError> {
        ::std::result::Ok(_ParamsLink{b: __arg_0.find_block("b").unwrap(),
                                      x: __arg_0.find_uniform("x").unwrap(),
                                      t: __arg_0.find_texture("t").unwrap(),})
    }
}

It's not processing the result properly yet though

Brendan Zabarauskas

@brendanzab

@cmr yeah, the circular dependency concerns me

@kvark ooh neat

Dzmitry Malyshau

@kvark

@bjz it may seem so trivial if you look at this, but the amount of code (and effort) is stunning

ember arlynx

@emberian

@kvark can I take #50?

Just trying to find something to do

Can't write useful code with it until your shader parameter stuff is done :P

Or maybe I will try and set up a blog...

Oh yes that was what I wanted to do.

@bjz create a gfx-rs organization and migrate the repos to it?

org created

you two are owners I think

Dzmitry Malyshau

@kvark

@cmr sure, feel free to tackle #50. I'm gonna be busy with shader parameters for some time... BTW, the current system still works, so you should be able to write useful code.

ember arlynx

@emberian

bbl, dinner.

Dzmitry Malyshau

@kvark

@bjz how do we move gfx-rs into the organization?

funny how we, members, are listed: Brendan, Corey, Dzmitry. Don't you think we are missing an A here (Andrey @ozkriff) ? ;)

Coraline Sherratt

@removed~csherratt

:/ I don't think Cargo is mature enough for gfx-rs yet

It assumes that there is only one library per crate I think

ember arlynx

@emberian

@csherratt one crate per project, but you can put multiple Cargo.toml, one for each subdirectory.

It will look in the right place.

Brendan Zabarauskas

@brendanzab

@cmr you have the org now?

I am wondering if we should have an org per project...

ember arlynx

@emberian

@bjz you are also an owner

of the org

Dzmitry Malyshau

@kvark

@cmr is it possible to "transfer" the project? or do we need to re-create it?

ember arlynx

@emberian

Yes.

@bjz can go into the repo admin page and do a transfer

Dzmitry Malyshau

@kvark

I suppose the same happened to rust at some point. I kinda like the automatic redirection that happened afterwards

Dzmitry Malyshau

@kvark

Got the proper parameter link errors now:

#[automatically_derived]
impl ::gfx::ShaderParam<_ParamsLink> for Params {
    fn create_link<S: ::gfx::ParameterSink>(__arg_0: &S) ->
     Result<_ParamsLink, ::gfx::ParameterLinkError<'static>> {
        ::std::result::Ok(_ParamsLink{b:
                                          match __arg_0.find_block("b") {
                                              Some(_p) => _p,
                                              None =>
                                              return ::std::result::Err(::gfx::LinkMissingBlock("b"))
                                          },
                                      x:
                                          match __arg_0.find_uniform("x") {
                                              Some(_p) => _p,
                                              None =>
                                              return ::std::result::Err(::gfx::LinkMissingUniform("x"))
                                          },
                                      t:
                                          match __arg_0.find_texture("t") {
                                              Some(_p) => _p,
                                              None =>
                                              return ::std::result::Err(::gfx::LinkMissingTexture("t"))
                                          },})
    }
}

Where communities thrive

People

Repo info

Activity