Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 25 2017 14:00

    davidroberts63 on 1.5.3

    (compare)

  • Oct 25 2017 14:00

    davidroberts63 on master

    Trying to fix travis build (compare)

  • Oct 25 2017 13:59

    davidroberts63 on 1.5.3

    (compare)

  • Oct 24 2017 14:19

    davidroberts63 on 1.53.3

    (compare)

  • Oct 24 2017 14:18

    davidroberts63 on master

    Version bump (compare)

  • Oct 24 2017 14:13

    davidroberts63 on 1.53.3

    (compare)

  • Oct 24 2017 14:10

    davidroberts63 on 1.53.3z

    (compare)

  • Oct 24 2017 13:48

    davidroberts63 on 1.53.3

    (compare)

  • Oct 24 2017 13:43

    davidroberts63 on master

    Update edit-step-as-json to han… Remove unused param Merge pull request #96 from mat… (compare)

  • Oct 24 2017 13:43
    davidroberts63 closed #96
  • Oct 24 2017 13:43
    davidroberts63 closed #94
  • Oct 24 2017 13:43

    davidroberts63 on master

    Add eslint, fix up errors in vi… Re-write to not use underscorej… Merge branch 'master' into fix-… and 1 more (compare)

  • Oct 24 2017 13:43
    davidroberts63 closed #97
  • Oct 24 2017 13:43
    davidroberts63 closed #95
  • Sep 23 2017 07:06
    matt-richardson synchronize #97
  • Sep 23 2017 07:05
    matt-richardson review_requested #97
  • Sep 23 2017 07:05
    matt-richardson opened #97
  • Sep 23 2017 05:40
    matt-richardson synchronize #96
  • Sep 13 2017 14:07
    davidroberts63 labeled #92
  • Sep 13 2017 14:07
    davidroberts63 labeled #95
David Roberts
@davidroberts63
Ooh looks interesting, thanks for sharing.
Matt Richardson
@matt-richardson
Pushed an updated version of the variable filtering
Not that happy with the code, but lacking in ideas how to fix it
But functionally I think it's there
As long as variables and roles work together the way I think they do...
David Roberts
@davidroberts63
Okay I'll try to look at it tomorrow evening. I just sent off a PR to fix the update all template problem. Small fix but look it over when you get a few. See if you can think of any other properties that might need to be in the list. That'll make sense in the code.
Matt Richardson
@matt-richardson
I've looked at it, but alas I don't have enough context on the problem to make more sense than "it works"
I've stepped through it, and i can completely understand your desire to avoid that loop.
I wonder if its worth doing in reverse...?
ie, its probably less likely that the step templates will change than the steps themselves?
Matt Richardson
@matt-richardson
Want me to merge the PR?
David Roberts
@davidroberts63
Yeah go ahead. I like what you said about reversing it. I'll look into that later. I'll publish later this evening.
I need to write up and check with you on pre-release and release process.
Matt Richardson
@matt-richardson
Cool. Big fan of "automate all the things" :)
David Roberts
@davidroberts63
I don't want to get to formal (used to that during day job) but want to get a set of docs so we can both publish at some point.
Matt Richardson
@matt-richardson
just went to merge, and doesn't appear I've got access to do so
David Roberts
@davidroberts63
Well darn.
I'll fix that.
Matt Richardson
@matt-richardson
Looks like build status button is broken now
random thought - I'm thinking that its probably better to do small, separate server side plugins, rather than a single one
the thought being that you can opt in via installing the plugin rather than some kind of config / admin page
David Roberts
@davidroberts63
I knew I'D miss something transferring.
Okay looked like I can't manage teams while mobile. I can try the full site but I'll just wait till I get back home this evening.
And yeah thinking something similar.
Matt Richardson
@matt-richardson
no worries
David Roberts
@davidroberts63
I really appreciate your work on Bluefin. It's a fun project to work on.
Matt Richardson
@matt-richardson
I'm finding it fun :)
I'm finishing up my current role next week... Really hoping that next gig uses OD
Something that a mate mentioned that he'd done some work on - https://github.com/TimButterfield/OctopusNotifier
very rough and ready, and still a work in progress
but interesting nonetheless
David Roberts
@davidroberts63
Just by the name and sub title I've been thinking of something like that for bluefin. I think I have an issue in github for it.
David Roberts
@davidroberts63
I like it being a system tray notifier. May help out on that.
David Roberts
@davidroberts63
Sweet! I got a browser test working with loading the Bluefin extension. See the prototype test here: https://saucelabs.com/beta/tests/7557a2fc5a85474792ae4e679f91950e/commands
Okay, but really, I need to do what I said and look at your branch.
David Roberts
@davidroberts63
Took a look at your filtering. Looks good. This is a very helpful part. The overall view resultant variables. Filtering like this will make it easier.
Matt Richardson
@matt-richardson
Any feedback on the code structure?
It doesn't feel great the way it's structured, especially without tests...
(I'm having a stab at sorting out some tests for the angular stuff, but it's not a simple refactor)
David Roberts
@davidroberts63
I'm letting it settle in my mind overnight to chew on it. I like the general structure yes.
David Roberts
@davidroberts63
I see your PR. Multi octopus version testing is under construction. I'm using the azure dev test labs at the moment. I hope to have something by end of this week.
Matt Richardson
@matt-richardson
Cool. Sounds interesting - looking forward to seeing how it's done.
Just (finally) took a look at the saucelabs test - looks useful. Never played with saucelabs.
David Roberts
@davidroberts63
Okay, decent progress on the devtest lab vm. I have a VSTS build (prototype) that creates the VM with two artifacts that install octopus and then restore a database copy. That part works, small bit is getting Octopus Deploy to start after the DB restore. The service isn't starting in a timely manner. Going to check on that. Once I get this going reliably I'll figure out a way to get the github repository to hook into VSTS to initiate the 'Browser Test' build.
I'm also trying to figure out how to make an 'organization' in VSTS like done on github. Right now all the Azure stuff is happening in my 'davidroberts63' account. I want to separate that and then add you to it.
Matt Richardson
@matt-richardson
Hmmm... I wonder if its worth thinking about tying it into the AppVeyor build...
(keep it all in the same spot and all that)
Did you see https://github.com/Azure/azure-quickstart-templates/blob/master/octopusdeploy3-single-vm-windows/Install-OctopusDeploy.ps1 for installing octopus from scratch? Thats where I got my "inspiration" from :)
Which database version are you using?
and which app version are you using?