Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 14 2020 19:42
    florimondmanca closed #334
  • Mar 14 2020 19:41
    florimondmanca commented #334
  • Mar 14 2020 19:39

    florimondmanca on pip

    (compare)

  • Mar 14 2020 19:39
    dependabot-preview[bot] commented #342
  • Mar 14 2020 19:39
    florimondmanca closed #342
  • Mar 14 2020 02:00

    dependabot[bot] on npm_and_yarn

    (compare)

  • Mar 14 2020 02:00
    dependabot[bot] commented #343
  • Mar 14 2020 02:00
    florimondmanca closed #343
  • Mar 13 2020 23:34
    codecov-io commented #343
  • Mar 13 2020 23:33
    codecov-io commented #343
  • Mar 13 2020 23:32
    codecov-io commented #343
  • Mar 13 2020 23:29
    dependabot[bot] labeled #343
  • Mar 13 2020 23:29
    dependabot[bot] opened #343
  • Mar 13 2020 23:29

    dependabot[bot] on npm_and_yarn

    Bump acorn from 6.1.1 to 6.4.1 … (compare)

  • Mar 09 2020 05:28
    codecov-io commented #342
  • Mar 09 2020 05:28
    florimondmanca commented #342
  • Mar 09 2020 05:27
    codecov-io commented #342
  • Mar 09 2020 05:26
    codecov-io commented #342
  • Mar 09 2020 05:23
    dependabot-preview[bot] labeled #342
  • Mar 09 2020 05:23
    dependabot-preview[bot] opened #342
Florimond Manca
@florimondmanca
Hi! Merry Christmas to peeps over here! 🎅 Enjoy your families, celebrate!
toastmasterbee
@bevennyamande
And a happy new year
Florimond Manca
@florimondmanca
Yep, happy new year to those who already entered 2019! 🎉 Still 4 hours to go here in France.
Ivan
@iovanom
Hello guys! I'm glad to work on your project!
But I have a problem, when I run the tests I got an error
FileNotFoundError: [Errno 2] No such file or directory: 'boca': 'boca'
Florimond Manca
@florimondmanca
Hi!
Ah! Try this: pip install -e .?
I see this step is missing in the contributing guidelines; it installs the package locally along with the boca CLI utility, which your error is apparently about
Ivan
@iovanom
yes, with this it will work ;)
but the pyenv install --dev can do this install ?
I didn't work with pyenv but I can investigate this
Florimond Manca
@florimondmanca
pyenv, you mean pipenv? :)
Ivan
@iovanom
oh, sorry
yes, pipenv
Florimond Manca
@florimondmanca
I believe it is possible to write pipenv install —dev ‘-e .’ to have pipenv add the local package to dev dependencies, and not have to manually pip install -e .
Would you mind taking a look? If you figure it out a PR would be delightful :)
Ivan
@iovanom
the pipenv install --dev -e . working
;)
Ivan
@iovanom
should I open an issue first?
or for this small fix is not necessary
Florimond Manca
@florimondmanca
Nice! Yes let’s skip the issue since we’ve just discussed it here :)
Ivan
@iovanom
ok
toastmasterbee
@bevennyamande
@florimondmanca howfar with that issue we discussed
Florimond Manca
@florimondmanca
Hi, @bevennyamande, are you referring to the blog example app? Unfortunately didn’t have the time to dig into it during the holidays... and it actually kind of collides with #16. Plus, I’m not sure a blog is the kind of app that Bocadillo and async would provide a significant benefit to.
So I was thinking, what if we merged the two, ie use the blog example for a how-to guide explaining how to plug an async ORM with Bocadillo?
It’s kind of all tangled together, that’s what complicated. The blog example is really just a support and I’m not sure it should be done as a standalone, separate from a how-to guide or a tutorial...
toastmasterbee
@bevennyamande
Yes true the blog can be a guide
Tobias SN
@TobiasSN
Does anyone know how to use a wildcard in a route path?
Something like this:
import bocadillo

api = bocadillo.API()

@api.route("*")
async def index(req, res):
    res.text = "Hello, world!"

if __name__ == "__main__":
    api.run()
Florimond Manca
@florimondmanca
Hi @TobiasSN , I don’t believe this is something we support at the moment. However, we’re using parse to match routes (https://pypi.org/project/parse/) and my guess is you should be able to use “/{}” 🤔
Tobias SN
@TobiasSN
Yeah I tried that. Doesn’t work with empty
Florimond Manca
@florimondmanca
So it works when accessing /foo but not /?
Anyway I think that’s a valuable usage hint and there’s perhaps something to fix there. I’ll create an issue for a quick howto guide on that :)
Tobias SN
@TobiasSN
Exactly.
Florimond Manca
@florimondmanca
Yes, I was able to replicate that, I pushed a fix in #129, will release 0.10.3 later today :)
Tobias SN
@TobiasSN
In that case, I'll be waiting.
Florimond Manca
@florimondmanca
@TobiasSN 0.10.3 just released to PyPI ;-)
Tobias SN
@TobiasSN
:D
Florimond Manca
@florimondmanca
Let me know how that goes, although the tests say it should now work ;)
Tobias SN
@TobiasSN
Yeah seems to work now.
Florimond Manca
@florimondmanca
👍
Florimond Manca
@florimondmanca
Hey, what’s everyone opinion on #124? How is the API class name relevant or irrelevant? We’re not specifically targetting REST APIs and this is a very early-days design choice, so now is a good time to challenge that :-)
Tobias SN
@TobiasSN
Yeah I think that App would be a much better choice. The
Tobias SN
@TobiasSN
Say you had a Recipe for your API. Now, you would most likely have named the main object api just because that’s how it is in the snippets. But what would you then name your Recipe? You could name it api_recipe or rest_api, but that’s a bit verbose. So you could rename the main object to app, and your recipe to api, but now people will see routes decorated with @api.route(“/foo”) and think they be accessible bypage/foo, instead of something likepage/api/foo` which it would actually be. Worst case, they'll make new routes decorated with the API Recipe and not the main object, and end up putting those under the API path, getting confused when they can’t access it from the exact path they specified.
Florimond Manca
@florimondmanca
A recipe for a REST API could be named api, yes, although I think that could also be a totally different app that you would mount onto the main one.
The idea is that we update references to api as the main object too. For example, app = App(). I’m also concerned that might be confusing to some people, but I don’t think they have an api recipe (since that name was already taken by the main object).
Florimond Manca
@florimondmanca
Hey! I got to fiddle with logos this weekend and posted an attempt on #24. What do you guys think? Does it fit the project? :-)