by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 07:56
    tinko92 synchronize #739
  • 03:08
    QigangZhong starred boostorg/geometry
  • Aug 10 22:34
    awulkiew synchronize #743
  • Aug 10 22:30
    awulkiew synchronize #743
  • Aug 10 21:01
    awulkiew commented #741
  • Aug 10 20:53
    barendgehrels commented #741
  • Aug 10 20:46
    awulkiew commented #741
  • Aug 10 19:16
    awulkiew synchronize #743
  • Aug 10 19:06

    awulkiew on develop

    [strategies] Add missing #inclu… (compare)

  • Aug 10 18:52
    awulkiew synchronize #743
  • Aug 10 18:48
    awulkiew milestoned #743
  • Aug 10 18:48
    awulkiew labeled #743
  • Aug 10 18:48
    awulkiew review_requested #743
  • Aug 10 18:48
    awulkiew review_requested #743
  • Aug 10 18:48
    awulkiew review_requested #743
  • Aug 10 18:48
    awulkiew opened #743
  • Aug 10 18:46

    barendgehrels on develop

    [turns] if the touch-interior t… [turns] handle ii-situation in … Merge pull request #741 from ba… (compare)

  • Aug 10 18:46
    barendgehrels closed #741
  • Aug 10 18:45
    barendgehrels commented #741
  • Aug 10 18:27

    awulkiew on develop

    [algorithms] Fix dangling refer… Merge pull request #740 from aw… (compare)

tinko92
@tinko92

Hi, I've looked into #585 , which you said is an annoying bug. I have no complete understanding of how to solve it, unfortunately, so I cannot create a PR or post a solution to the issue, but I hope that giving you this partial analysis of the issue here, may help you to solve it:

I noticed that https://www.boost.org/doc/generate.php?page=libs/libraries.htm&version=1.73 shows geometry extensions and https://www.boost.org/doc/generate.php?page=libs/libraries.htm&version=develop does not. After running generate.php locally, I think that it is based on a db of libraries that is generated by update-doc-list.php and represented in this xml file: https://www.boost.org/doc/libraries.xml. It has multiple entries for "geometry/extensions", the entry for develop has hidden status, the entry for "1.70" does not. Notably, "geometry index" has an entry for 1.70 without status hidden and one for 1.72 with status hidden.

What I think, may happen here, is that the generate.php-script just uses the latest numbered entry if version=1.73 is passed. Manipulating the data structure like this in generate.php
$libs->db['geometry/extensions']['1.73.0'] = $libs->db['geometry/extensions']['1.70.0'];
$libs->db['geometry/extensions']['1.73.0']->details['status'] = 'hidden';
makes the "geometry extensions" entry go away, if I run it locally.

So, if the metadata would be added again for the next version with the status being properly set to "hidden", I believe that could make the "geometry extension"-entry go away.
So TL;DR: I think the list of libraries for releases may use the latest meta data for a numbered version and because of that having a non-hidden "geometry extensions"-entry for 1.70 and no entry (deleted) afterwards may cause the entry to reappear in all versions since then.

Mateusz Łoskot
@mloskot
@tinko92 This is awesome finding, thank you so much. I will look into that tonight.
@sudo-panda I'm sorry, still haven't looked at your PR. The Boost .173 pre-release tasks are taking over.
tinko92
@tinko92
@mloskot the more i think abou this, the more it seems to be a website issue rather than a boostorg/geometry issue to me. I opened an issue with this question at boostorg/website: boostorg/website#497 . I hope this is not considered inappropriate, if it is, I will delete the issue.
tinko92
@tinko92
Manipulating the history would not be satisfactory, including metadata to mask metadata from a previous version that should just be gone completely in master seems not satisfactory either, so that's my reasoning for inquiring whether it should be considered a website bug. But adding the metadata like in my linked branch in the issue may still be reasonable if it solves the issue, to have the entry gone in version 1.73 because I doubt that he website will change to quickly, even if the website is determined to be at fault.
tinko92
@tinko92
I guess glenfe resolved it.
Mateusz Łoskot
@mloskot
Yes, I'm thankful Glen was able to help.
I had to take kids for two days in woods,
Let them spend energy accumulated during lock out due to covid
Without you and Glen, the I could do anything for the issue.
Thanks a lot
sudo-panda
@sudo-panda
It's fine @mloskot . It's a global pandemic I understand your situation, it's fine. I am in bit of a problem regarding #693 tho. There is no fill for 2d plots in plotly and the 3d mesh plots can only be made by mentioning explicitly which vertices form a triangle. But the polygon type doesn't check if the rings form proper faces. Should I check for faces in the polygon or should I let the user decide if his data can be a mesh plot and if he wants it to be a mesh plot.
sudo-panda
@sudo-panda
Why do append m_ to class variables, like m_geometry? What does it stand for?
tinko92
@tinko92
Generally, in C++ development, the "m_" prefix is often used to designate class/struct members.
sudo-panda
@sudo-panda
Does it have a full form?
member I guess?
tinko92
@tinko92
Yes, I think the "m" is short for "member"
sudo-panda
@sudo-panda
Congrats
@tinko92
tinko92
@tinko92
Thanks. Also thanks for the renewed trust @vissarion
tinko92
@tinko92
And, of course, thanks to everybody else at Boost.Geometry who was involved in the project selection.
Digvijay Janartha
@digu-007
Congrats @tinko92 !!
Vissarion Fisikopoulos
@vissarion
We had very good proposals this year and the selection was very difficult.
Congrats @tinko92 !
Thank you all for your proposals, discussions and contributions.
Aditya Mohan
@spacewafer
Congrats @tinko92
Great working with you guys! :)
tinko92
@tinko92
Thanks, everyone!
Mateusz Łoskot
@mloskot
Congratulations!
@tinko92 Boost.Geometry is an intimidating piece of software (it is to me!) and it does not stop you to keep ploughing. I want to say, you're an exceptional contributor.
sudo-panda
@sudo-panda
Is strategy necessary when differentiating between CSs because in the plotly extension I don't see a reason to keep strategies and not make the decision internally everytime. Is there some other reason why strategy is used other than letting user make the choice?
Frédéric Simonis
@fsimonis
Hi there, I am developer of the project preCICE.
We are currently writing our next major reference paper and would like to cite our dependencies to give them the credit they deserve. This paper will be the goto citation for quite some time.
We use boost.geometry especially for the spacial index trees.
How should we cite your project?
Mateusz Łoskot
@mloskot
@fsimonis I don't see any guide on this. It may be a good idea to open an issue on GitHub
Frédéric Simonis
@fsimonis
@mloskot will do.
Frédéric Simonis
@fsimonis
Abhishek Mahakal
@Master-Chief1
Hello everyone, I am Abhishek Mahakal, currently in 3rd year of computer engineering. I am thrilled to be a part of Boost C++ community and contribute to it!
tinko92
@tinko92
Misunderstandings with regard to the meaning of spatial predicates seem to be a recurring thing (just today there was one on the mailing list again). @awulkiew Do you think it may be beneficial to have the DE-9IM masks and little illustrations of valid and invalid spatial relationships in the documentation? After GSoC I would have time to generate some images that could illustrate the spatial relationships.
Mateusz Łoskot
@mloskot
@tinko92 This is something I had in mind for very long time. Something like the PostGIS docs have.
tinko92
@tinko92
I see. Then I will try to make a PR later in the year after GSoC. I believe with the great SVG-Mapper generating the graphics should be easy, but it's probably worth it to give some thought to making particularly instructive illustrations (it would probably be good to have examples for which the predicates return true and some for which they do not return true).
Mateusz Łoskot
@mloskot
Yes, my idea was to have collection of programs run as part of CI job (so they are validated) and producing the graphics for the documentation.
RkSinghDeo
@RkSinghDeo
Hi everybody! I am Ramneek Singh ,currently in 2nd year of CSE . It's been 7 messed up days looking, how to get started to contribute to Boost community as beginner can find a way. Hope someone helps me out to get out of this mess, thanks
Mateusz Łoskot
@mloskot
@RkSinghDeo
https://www.boost.org/users/faq.html 5th question
and general how to contribute to open source apply https://opensource.guide/how-to-contribute/
If you have specific questions, ask on https://lists.boost.org/mailman/listinfo.cgi/boost
tinko92
@tinko92
Also, note that there is a label called "good first issue" which you can filter for on the Boost.Geometry issue list: https://github.com/boostorg/geometry/labels/good-first-issue
I also found the Boost.Geometry Contribution tutorial helpful for a specific guide for contributing a piece of code: https://github.com/boostorg/geometry/wiki/Contribution-Tutorial
RkSinghDeo
@RkSinghDeo
@mloskot @tinko92 is my basic C++ DS and Algo is enough to contribute and understand code??
i was looking forward to contribute in Boost for GSOC if anyone can give contact to help me get started it will be bliss for me
Mateusz Łoskot
@mloskot
@RkSinghDeo Such question if C++ DS and Algo is enough is impossible to answer.
There are people with PhD who may have problems and people with no degree who can see all details clear :-)
Just dive in, start reading the code, start using/running it, and you will see yourself
If you want to start contributing, @tinko92 's suggestion to look for the good first issues is an excellent one
Regarding Boost for GSoC, you're welcome to submit a project for GSoC 2021
Just remember to start discussing it as early as possible, e.g. near December
Meanwhile, getting started with Boost Geometry is a great ideae
RkSinghDeo
@RkSinghDeo
@mloskot thanks buddy !! Really appreciate your help!!