Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 16:35
    lpranam synchronize #614
  • 16:35

    lpranam on cmakelists

    Add a Boost-friendly subproject… (compare)

  • 16:34
    lpranam synchronize #614
  • 16:34

    lpranam on cmakelists

    Add a Boost-friendly subproject… (compare)

  • 15:32
    pdimov commented #614
  • 15:26
    lpranam commented #614
  • 11:39
    pdimov commented #614
  • Sep 04 23:08
    KONAKONA666 starred boostorg/gil
  • Sep 03 19:13
    YashK773 commented #625
  • Sep 03 19:13
    YashK773 reopened #625
  • Sep 03 19:13
    YashK773 commented #625
  • Sep 03 19:11
    YashK773 closed #625
  • Sep 03 19:11
    YashK773 commented #625
  • Sep 03 12:56
    sdebionne commented #625
  • Sep 02 20:05
    YashK773 opened #625
  • Sep 02 20:00
  • Aug 31 19:06
    YashK773 commented #605
  • Aug 31 18:17
    mloskot commented #605
  • Aug 31 15:39
    meshtag commented #605
Mateusz Łoskot
@mloskot
e.g. if you have any not versioned files like customised CMakeSettings.json or .vs or .vscode folders, etc.
and you want to keep it, then you need to comment those two lines, otherwise they will be nuked
All your branches and committed changes are safe though.
That is why the script is called start-over :-)
Olzhas Zhumabek
@simmplecoder
roger that, thanks
MIRAL SHAH
@miralshah365

@miralshah365 , could you please try running b2 libs/gil/test/core/point/ from a windows machine? I currently don't have a compiler on a windows machine

tried this but same result

Mateusz Łoskot
@mloskot
@miralshah365 So, what is the current problem?
MIRAL SHAH
@miralshah365
Same errors
Mateusz Łoskot
@mloskot
Do you mean CI builds still failing? Link?
MIRAL SHAH
@miralshah365
No, I have not built on the CI yet but after applying changes you suggested in the comment I still get the same error on the local machine.
Mateusz Łoskot
@mloskot
I suggest you push your changes anyway, so the PR is updated and we can all observe what CI says.
Don't worry about breaking CI builds for your PRs. It happens in your branch, you can break it. You/We will always have chance to fix it :)
Feel free to mess up your PR.
MIRAL SHAH
@miralshah365
pushed
Mateusz Łoskot
@mloskot
@miralshah365 I will check it tonight yet
Mateusz Łoskot
@mloskot
@miralshah365 I had quick look and explained the issue in new review comment, https://github.com/boostorg/gil/pull/393#discussion_r332104768
renaissance69
@renaissance69
Hey, I am just starting out with open source and since I know a bit about image processing, I felt that GIL would be a nice project to contribute to. I would like some help in running the sample examples. I have set up b2 as given in the instructions in https://boostorg.github.io/build/manual/develop/index.html#bbv2.overview.invocation. It is showing an error that it is unable to find png.h. I am currently using windows subsystem for Linux, running ubuntu 18.04. Could you please help me solve this issue?
Mateusz Łoskot
@mloskot

@renaissance69 Welcome!
In order to contribute to GIL, for 90% of cases, you do not need to look at the Boost.Build docs at all.

For anyone interested to start contributing to GIL, I suggest to read through the following, in this order:

  1. https://github.com/boostorg/gil/blob/develop/README.md
  2. https://github.com/boostorg/gil/blob/develop/CONTRIBUTING.md

Then, you may also have a look at some additional guidelines on the Wiki, https://github.com/boostorg/gil/wiki/Guidelines

@renaissance69 Be aware, this channel is for ad-hoc real-time communication, not everyone involved monitors it all the time.
So, if you don't receive answer for too long, then re-post your question to the mailing list at https://lists.boost.org/mailman/listinfo.cgi/boost-gil, which is the primary communication channel for Boost.GIL, for both, users and developers.
renaissance69
@renaissance69
Will do. Thanks a ton.
Mateusz Łoskot
@mloskot
@renaissance69 To give you quick pointers,
  1. Complete the three steps from this section https://github.com/boostorg/gil/blob/develop/CONTRIBUTING.md#1-clone-boost-super-project
  2. Install dependencies required for GIL I/O features , optional and not strictly required but you will most likely need them as contributor
    sudo apt-get install libjpeg-dev libpng-dev libtiff5-dev libraw-dev
  3. Jump to https://github.com/boostorg/gil/blob/develop/CONTRIBUTING.md#using-cmake
That should work for WSL, which I also use (FYI, This workflow works very well with CLion)
I have just realised CONTRIBUTING.md says this TODO: Explain I/O dependencies (libjpeg, etc.).
Essentially, it is meant to explain the apt-get install command above.
If you will have questions, just ask
Important hint: If you are going to use CMake, then always use the latest CMake release :-)
Olzhas Zhumabek
@simmplecoder
is there a way to somehow make flat image object layout? E.g. [metadata, image_contents]
I want to try to rewrite some of my algorithms in cuda, but am wondering how I could move the data around, as just writing an allocator won't work (writing into that memory from CPU is not allowed). I am just doing it for my personal project, not to submit PR
Olzhas Zhumabek
@simmplecoder
I believe I finally figured out what was the problem with my PR. I was passing unsigned pixel to build a signed image. @mloskot , @stefanseefeld , if you don't have any other requests for changes, I would like to merge it after tests pass
Mateusz Łoskot
@mloskot
@simmplecoder You mean #392?
Olzhas Zhumabek
@simmplecoder
@mloskot , yes, sorry for not embedding the link
Mateusz Łoskot
@mloskot
OK, I'll have a look in a moment
renaissance69
@renaissance69
@mloskot I was able to compile and run a few example programs on boost, I will go through the tutorial and try and understand how those programs are written, thanks for the help!
Mateusz Łoskot
@mloskot
@renaissance69 Good to hear. If you have any questions feel free to ask, on list or here
Olzhas Zhumabek
@simmplecoder
@mloskot, there is a message from a weird email (bot?) about breaking GIL test. I believe it is expected since boostorg/gil#394 is not merged to master, right? Should I respond to it or just ignore the message? Is there anything I can do to help?
Mateusz Łoskot
@mloskot
There where?
The #394 is merged to master as expected
image.png
@simmplecoder You mean #395? I'm looking
Mateusz Łoskot
@mloskot
@simmplecoder Thanks for pointing that out. I have just dealt with it.
I have no idea who @spacelg is but it does not look like a bot to me.
From the issue description, it suggests she/he just built all Boost tests locally
Olzhas Zhumabek
@simmplecoder
I guess I’m just not used to notification system (gets passed through gh’s notification email, not through personal ones). Thanks for dealing with it so quickly. I thought it is one of those Boost release problems so I thought I should try to help as well
Mateusz Łoskot
@mloskot
My diagnosis is that things may have changed a bit by the merge to master, but that only helped to reveal incomplete setup used by @spacelg
Anyone who builds tests or examples is supposed to have all deps in place.
MIRAL SHAH
@miralshah365
@mloskot I have pushed the median filter implementation with tests that works now. I think the implementation can be optimized suggest me if you see any improvements.
Mateusz Łoskot
@mloskot
@miralshah365 Thanks. I will have a look over the weekend
Olzhas Zhumabek
@simmplecoder
How can I link to GIL in CMake? I believe if I will just do add_library then target_include_directories, other parts of boost used in GIL will not be found by it, right?
Pranam Lashkari
@lpranam
For library linking you'll need to use target_link_libraries
What are tou trying to do?
Olzhas Zhumabek
@simmplecoder
I want to create a project that uses Boost GIL. I do not want to install boost, and would like to work directly with upstream version
target_link_libraries requires gil being created as a library, which I believe GIL's CMakeLists.txt doesn't do. I checked out conan version, but I got weird issue with settings.compiler is not defined
Pranam Lashkari
@lpranam
Then the function you mentioned earlier is way to go cause you don't have to build anything it's header only so...
Olzhas Zhumabek
@simmplecoder
it seems like GIL has dependencies into boost, which makes that approach a bit hard. I'm not sure if there is a complete list of the dependencies. There are also io extensions which I would like to carry over as well, but those need linkage to libpng, libjpeg
Olzhas Zhumabek
@simmplecoder
I've picked up iterator and mp11, but not sure where boost/assert.hpp comes from