Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Apr 15 16:31
    Scramjet911 commented #576
  • Apr 15 15:14
    mloskot commented #576
  • Apr 15 15:13
    mloskot commented #576
  • Apr 15 14:56
    Scramjet911 commented #576
  • Apr 15 14:55
    Scramjet911 edited #588
  • Apr 15 14:49
    mloskot commented #576
  • Apr 15 14:02
    Scramjet911 commented #576
  • Apr 15 14:00
    Scramjet911 edited #588
  • Apr 15 10:49
    codecov[bot] commented #581
  • Apr 15 09:49
    codecov[bot] commented #581
  • Apr 15 09:49
    meshtag synchronize #581
  • Apr 15 09:42
    meshtag ready_for_review #583
  • Apr 15 09:30
    codecov[bot] commented #583
  • Apr 15 07:44
    meshtag synchronize #583
  • Apr 15 07:26
    meshtag synchronize #583
  • Apr 14 07:17
    mloskot commented #51
  • Apr 14 02:54
    pdimov commented #51
  • Apr 13 15:01
  • Apr 12 22:08
    lpranam commented #596
  • Apr 12 19:25
    mloskot commented #596
Mateusz Łoskot
@mloskot
I wish I could help, but zero experience with CUDA here.
You may have much better luck on channels of cpplang.slack.com, #cuda, #gpu etc
Olzhas Zhumabek
@simmplecoder
thanks! I believe I'll be able to take it from here. May be create a cpp file that I could just link to, and compile only once
Olzhas Zhumabek
@simmplecoder
I have a question: is there any reason why add_deref functions need type specified in the type itself? I believe making the function a template would make it so much easier to use, because I found that I have to write auto deref_fn = [](...){...}; auto deref_view = ...::add_deref<decltype(deref_fn)>(view, deref_fn); instead of just writing the lambda inline
it might be a breaking change though, and I believe it will break ABI as template parameter will get mangled into the name
I believe one solution would be to just write a global function that would just place the right types. May be there is already something similar?
Mateusz Łoskot
@mloskot

@simmplecoder

is there any reason why add_deref functions need type specified in the type itself?

I have never analysed / considered that myself. Possibly C++98 kind of legacy.
I'm not aware of any 'factory' function deducing the types.

IMHO, breaking API/ABI is fine, especially if it will help to modernise GIL as well as GIL users codebase.
If it is not possible to extend/overload existing functions, then breaking is the only way.

What I'd suggest is: get your idea implemented, submit PR for review, and let's see.

Mateusz Łoskot
@mloskot
@miralshah365 & @simmplecoder :point_right: https://lists.boost.org/boost-gil/2019/10/0314.php
Olzhas Zhumabek
@simmplecoder
roger that
Mateusz Łoskot
@mloskot
It's certainly not a request, rather FYI :)
Pranam Lashkari
@lpranam
are we going to release any GSoC work with this release?
Mateusz Łoskot
@mloskot
Yes, as stated in the thread
Pranam Lashkari
@lpranam
I have a few comments I'll share in the mail
BTW have we decided till wich commit we are going to release?
Mateusz Łoskot
@mloskot
I think @stefanseefeld will do the grand merge of everything in develop
@lpranam If you want to share any feedback, objection, suggestion, please do it ASAP following up to the boost-gil thread
Pranam Lashkari
@lpranam
@mloskot just sent the mail
Pranam Lashkari
@lpranam
it awaits approval
Mateusz Łoskot
@mloskot
Looks like you are not subscribed. I will accept your post this time
Pranam Lashkari
@lpranam
This is my first email to GIL-list that's why
Mateusz Łoskot
@mloskot
Indeed. I did not realise the moderation flag is on by default for new posters
Mateusz Łoskot
@mloskot

@stefanseefeld Since time will run short soon, I have to nudge you to ensure you got this on time. Please, have a look at

Thanks @lpranam for heads up!

Stefan Seefeld
@stefanseefeld
@mloskot Thanks. https://lists.boost.org/boost-gil/2019/10/0316.php is referring to a commit to develop, no ? Is there anything left to do ? (other than merge develop to master, I mean ?)
I can certainly do the merge once you confirm that develop is complete, i.e. there are no other expected commits targeted for 1.72.
Mateusz Łoskot
@mloskot
Yes, I made those adjustments in develop only.
Outstanding is this one PR by @simmplecoder waiting for your review https://github.com/boostorg/gil/milestones/Boost%201.72
Once that is merged to develop
Or postponed after 1.72 (milestone removed)
Then develop is ready for merge into master, I think
Mateusz Łoskot
@mloskot
@stefanseefeld :point_up:
Pranam Lashkari
@lpranam
Wait I'll send a PR to close #391 in a few hours
Almost ready just a minor bug needa to be resolved
Pranam Lashkari
@lpranam
@mloskot just created a new PR for the same
Mateusz Łoskot
@mloskot
Approved. Thanks for speedy PR!
Pranam Lashkari
@lpranam
:)
Olzhas Zhumabek
@simmplecoder
should I hide my code under detail too, since it depends on the convolve_2d?
Olzhas Zhumabek
@simmplecoder
it is weird that in my PR the public interface returns class from detail
Pranam Lashkari
@lpranam
@simmplecoder your argument makes sense to me..
Mateusz Łoskot
@mloskot
@simmplecoder It all depends on what "since it depends on class from detail" mean, I think
Since it is about returning, then you and @lpranam rightly observe it smells
But, it also can be fine and indicate user that type is internal and avoid using the type in own interfaces
While using instances of the type in user's code is perfectly fine
Mateusz Łoskot
@mloskot
After all, auto x = foo() ignores the type, user does not have to care type of x lives in detail
So, I'd not rush with hiding your code
I'd rather like to hear what others think, what @stefanseefeld thinks
Mateusz Łoskot
@mloskot
@simmplecoder if you prefer to open an issue referenced to my PR hiding the stuff, by all means, feel free to do so, mentioning me, @stefanseefeld and whoever you'd like to consult. Then let's discuss it there (you know here things are easily overlooked, Stefan is not here all the time)
Mateusz Łoskot
@mloskot
@lpranam Can I merge #398?
Pranam Lashkari
@lpranam
@mloskot sure
Mateusz Łoskot
@mloskot
@lpranam Done, thanks
Olzhas Zhumabek
@simmplecoder
@mloskot, feel free to ping me if you see anything suspicious in my PR. I believe the tests should pass now