Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Apr 10 15:31
    codecov[bot] commented #573
  • Apr 10 14:36
    codecov[bot] commented #573
  • Apr 10 14:36
    lpranam synchronize #573
  • Apr 10 14:06
    codecov[bot] commented #573
  • Apr 10 14:06
    Build #147 passed
  • Apr 10 13:11
    lpranam synchronize #573
  • Apr 10 11:29
    mloskot commented #583
  • Apr 10 07:59
    meshtag converted_to_draft #583
  • Apr 10 07:59
    meshtag commented #583
  • Apr 10 07:20
    Scramjet911 edited #588
  • Apr 10 07:17
    Sayan-Chaudhuri commented #392
  • Apr 10 07:12
    Scramjet911 edited #576
  • Apr 10 06:08
    codecov[bot] commented #583
  • Apr 10 06:01
    meshtag synchronize #583
  • Apr 10 06:00
    codecov[bot] commented #582
  • Apr 10 05:07
    codecov[bot] commented #581
  • Apr 10 04:16
    codecov[bot] commented #582
  • Apr 10 04:16
    meshtag synchronize #582
  • Apr 10 03:43
    meshtag synchronize #581
  • Apr 10 03:17
    codecov[bot] commented #581
Mateusz Łoskot
@mloskot
Yes, I made those adjustments in develop only.
Outstanding is this one PR by @simmplecoder waiting for your review https://github.com/boostorg/gil/milestones/Boost%201.72
Once that is merged to develop
Or postponed after 1.72 (milestone removed)
Then develop is ready for merge into master, I think
Mateusz Łoskot
@mloskot
@stefanseefeld :point_up:
Pranam Lashkari
@lpranam
Wait I'll send a PR to close #391 in a few hours
Almost ready just a minor bug needa to be resolved
Pranam Lashkari
@lpranam
@mloskot just created a new PR for the same
Mateusz Łoskot
@mloskot
Approved. Thanks for speedy PR!
Pranam Lashkari
@lpranam
:)
Olzhas Zhumabek
@simmplecoder
should I hide my code under detail too, since it depends on the convolve_2d?
Olzhas Zhumabek
@simmplecoder
it is weird that in my PR the public interface returns class from detail
Pranam Lashkari
@lpranam
@simmplecoder your argument makes sense to me..
Mateusz Łoskot
@mloskot
@simmplecoder It all depends on what "since it depends on class from detail" mean, I think
Since it is about returning, then you and @lpranam rightly observe it smells
But, it also can be fine and indicate user that type is internal and avoid using the type in own interfaces
While using instances of the type in user's code is perfectly fine
Mateusz Łoskot
@mloskot
After all, auto x = foo() ignores the type, user does not have to care type of x lives in detail
So, I'd not rush with hiding your code
I'd rather like to hear what others think, what @stefanseefeld thinks
Mateusz Łoskot
@mloskot
@simmplecoder if you prefer to open an issue referenced to my PR hiding the stuff, by all means, feel free to do so, mentioning me, @stefanseefeld and whoever you'd like to consult. Then let's discuss it there (you know here things are easily overlooked, Stefan is not here all the time)
Mateusz Łoskot
@mloskot
@lpranam Can I merge #398?
Pranam Lashkari
@lpranam
@mloskot sure
Mateusz Łoskot
@mloskot
@lpranam Done, thanks
Olzhas Zhumabek
@simmplecoder
@mloskot, feel free to ping me if you see anything suspicious in my PR. I believe the tests should pass now
Mateusz Łoskot
@mloskot
@simmplecoder OK. The only thing we are missing now is review from @stefanseefeld , I think
Olzhas Zhumabek
@simmplecoder
yeah, the likelihood of tests not passing is going down every minute. I don't think I will be able to respond rapidly in the following 5 or so days though, so hopefully I will be able to deal with all problems today
Mateusz Łoskot
@mloskot
No problem. You have different priorities now
Mateusz Łoskot
@mloskot
Olzhas Zhumabek
@simmplecoder
@mloskot, one of the builds broke due to some changes in the OS or something similar, I think
Mateusz Łoskot
@mloskot
Restarting the job. If does not help, we will ignore it.
Olzhas Zhumabek
@simmplecoder
great, seems like it worked. Thanks!
Mateusz Łoskot
@mloskot
Awesome!
I will keep nudging @stefanseefeld :-)
Olzhas Zhumabek
@simmplecoder
merged, thanks @stefanseefeld !
Mateusz Łoskot
@mloskot
@simmplecoder Do you mind if I run apply some of the corrections/changes I suggested in my review?
Stefan Seefeld
@stefanseefeld
OK, so I could merge to master now ?
Olzhas Zhumabek
@simmplecoder
@mloskot , sure, if we've got time
Stefan Seefeld
@stefanseefeld
Oh, OK, I'll wait a little longer, then.
:-)
Mateusz Łoskot
@mloskot
It's not critical for release, I can do it after merge, for example https://github.com/boostorg/gil/pull/392#discussion_r338236303
Stefan Seefeld
@stefanseefeld
I'll merge no later than tonight (EST)
Mateusz Łoskot
@mloskot
I'm also a bit :confused: about the length namin https://github.com/boostorg/gil/pull/392#discussion_r338234886
Stefan Seefeld
@stefanseefeld
Either is fine. If you expect to do this in the next couple of hours I can wait. Otherwise we can do it later and merge as "minor changes and improvements" :-)
Mateusz Łoskot
@mloskot
Finally, it would be nice to stick in some asserts https://github.com/boostorg/gil/pull/392#discussion_r338237322
@stefanseefeld Let's merge it now
Stefan Seefeld
@stefanseefeld
OK, fair enough. Let me do it while I'm looking at it...
Mateusz Łoskot
@mloskot
We better give ourselves time for master CI
Olzhas Zhumabek
@simmplecoder
I'm a bit tired for today, did a lab and two reading reports. If the deadline is on Monday, I can incorporate the changes on weekends