should I hide my code under detail too, since it depends on the convolve_2d?
it is weird that in my PR the public interface returns class from detail
@simmplecoder your argument makes sense to me..
@simmplecoder It all depends on what "since it depends on class from detail" mean, I think
Since it is about returning, then you and @lpranam rightly observe it smells
But, it also can be fine and indicate user that type is internal and avoid using the type in own interfaces
While using instances of the type in user's code is perfectly fine
After all, auto x = foo() ignores the type, user does not have to care type of x lives in detail
So, I'd not rush with hiding your code
I'd rather like to hear what others think, what @stefanseefeld thinks
@simmplecoder if you prefer to open an issue referenced to my PR hiding the stuff, by all means, feel free to do so, mentioning me, @stefanseefeld and whoever you'd like to consult. Then let's discuss it there (you know here things are easily overlooked, Stefan is not here all the time)
@mloskot, feel free to ping me if you see anything suspicious in my PR. I believe the tests should pass now
@simmplecoder OK. The only thing we are missing now is review from @stefanseefeld , I think
yeah, the likelihood of tests not passing is going down every minute. I don't think I will be able to respond rapidly in the following 5 or so days though, so hopefully I will be able to deal with all problems today