These are chat archives for boostorg/hana

11th
Jan 2016
Jason Rice
@ricejasonf
Jan 11 2016 00:42
jason@jason-nuc:/usr/lib/gcc/x86_64-linux-gnu/5.1.0$ readelf -sV libstdc++.so | sed -n 's/.*@@GLIBCXX_//p' | sort -u -V | tail -1
3.4.21
Jason Rice
@ricejasonf
Jan 11 2016 23:37
@ldionne It occurred to me that I could give you push access to my fork if that is easier than having a branch in the upstream repo. (wrt #226)
Louis Dionne
@ldionne
Jan 11 2016 23:39
Or I could just create that damn branch on the upstream. I’m sorry it’s been so long. The thing is that this PR is actualy a huge chunk; it’s hard to tell whether we’re improving or not, and there are also other approaches (hashing) available. 1 minute
Jason Rice
@ricejasonf
Jan 11 2016 23:40
I'm not in a hurry or anything so no rush. ;)
We could always have multiple branches with different tweaks to run benchmarks on and contrast and compare.
I was actually thinking about making another PR to attempt to improve hana::pair. (maybe it would be faster if it wasn't a wrapper for a basic_tuple idk)
Louis Dionne
@ldionne
Jan 11 2016 23:43
Yes, in retrospect I think that would be better. You can see my (rather extensive) changes here
I also removed the fast lane for looking up hana::types, since it was broken (the specialization would never match), and I did not take time to reimplement it properly.
I also rebased the branch on top of develop. Check the changes out, then we’ll discuss them.
Louis Dionne
@ldionne
Jan 11 2016 23:55
@ricejasonf I added comments. In retrospect, some of my changes should be reverted to what you did, or a slight variation of it.