These are chat archives for boostorg/hana

27th
Jan 2016
Jason Rice
@ricejasonf
Jan 27 2016 01:02
#226 and #242 are squashed down now and not on top of each other
the appveyor build appears to be failing because it is missing boost/core/demangle.hpp
Jason Rice
@ricejasonf
Jan 27 2016 01:11
sorry I just rebased #226 on boostorg develop and pushed it again
idk if that creates a bunch of dangling build jobs :sweat_smile:
Louis Dionne
@ldionne
Jan 27 2016 02:02
@ricejasonf It all looks fine, except for the Appveyor failure. One of your tests (test/hash.cpp) seems to be including <boost/hana/experimental/printable.hpp>, even though it is not using it. Try removing this include. Otherwise, FYI, tests that depend on the rest of Boost can be excluded when Boost is not available in test/CMakeLists.txt by adding them to the EXCLUDED_UNIT_TESTS list.
Jason Rice
@ricejasonf
Jan 27 2016 02:05
sorry that was left in by mistake
Louis Dionne
@ldionne
Jan 27 2016 02:05
No problem, really.
Louis Dionne
@ldionne
Jan 27 2016 18:04
@ricejasonf Nitpick: Please avoid referring to issues from commits unless you know the commit won’t be modified and pushed several times again. Otherwise, it clutters issues like boostorg/hana#223. Instead of referring to an issue from a commit, you can refer to it from a comment in the pull-request you wish to link to the issue. Also, when merging the PR would close an issue, you can let me close it in the merge commit that will be done only once when the PR is merged.
Of course, this is just a rule of thumb and it does not always apply.
Jason Rice
@ricejasonf
Jan 27 2016 18:19
Understood, though I am pretty sure I didn't make it say "Resolves"
idk
Louis Dionne
@ldionne
Jan 27 2016 18:20
No, no, you didn’t use “Resolves”. My point is just that it would be better to avoid cluttering issues list with WIP commits. I do it myself too sometimes, and it’s just bad hygiene for GitHub issues.
Jason Rice
@ricejasonf
Jan 27 2016 18:21
Yes, I see what it did.
Louis Dionne
@ldionne
Jan 27 2016 18:23
In all cases, it’s not a big deal. Thanks a lot for rebasing and cleaning up #226 and #242, it’s much appreciated. I’ll review them and give you my thoughts. Btw, your work on this improvement is much welcome, since it’s a complex beast.
Jason Rice
@ricejasonf
Jan 27 2016 18:24
Cool, I learned a lot from it. C++, Hana, and Git
Louis Dionne
@ldionne
Jan 27 2016 18:25
I can imagine. What we do here (in terms of C++) is very different from anything else I’ve seen so far, lol.