ldionne on gh-pages
Update benchmarks to 490dbf6 fo… (compare)
ldionne on gh-pages
Update benchmarks to 490dbf6 fo… (compare)
ldionne on gh-pages
Update benchmarks to 490dbf6 fo… (compare)
ldionne on gh-pages
Update benchmarks to 490dbf6 fo… (compare)
ldionne on gh-pages
Update benchmarks to 490dbf6 fo… (compare)
push —force
ing to update the PR?
The following should work. Execute the commands one by one, and make sure it makes sense at each step, because I haven't proofread the steps and I don't want to delete your whole hard drive:
git checkout the-name-of-your-branch
# make sure your working directory is clean
git rebase -i HEAD~3
A file should pop-up in your default editor. Follow the instructions written in that file. Basically, you should put squash
instead of pick
in front of your 2 last commits. Once you're done, save it and close it. The rebase should take place, and you'll be asked to edit the commit message of the squashed commit; do it. Normally, you'll be left with a single commit containing the changes of your 3 current commits, and with the commit message that you'll have chosen. Now, you can push --force
your new commit to your branch, overwriting the 3 previous commits:
git push --force
Again, take these steps with a grain of salt.
#include
lightweight declarations instead of full blown definitions when only a declaration is requried. This can help with compile times. Also, it’s necessary for some circularly-dependent stuff.
#include<boost/hana.hpp>
namespace hana = boost::hana;
int main()
{
static_assert(hana::find_if(hana::make_tuple(
hana::make_tuple(),
hana::make_tuple(),
hana::make_tuple(hana::int_c<0>, hana::int_c<1>),
hana::make_tuple()), hana::length)
==
hana::just(hana::make_tuple(hana::int_c<0>, hana::int_c<1>)), "");
}
/usr/local/include/boost/hana/detail/index_if.hpp:56:50: error: implicit instantiation of undefined
template 'boost::hana::detail::index_if<const boost::hana::length_t &,
boost::hana::detail::pack<boost::hana::tuple<boost::hana::integral_constant<int, 0>,
boost::hana::integral_constant<int, 1> >, boost::hana::tuple<> >, boost::hana::when<true> >'
static constexpr std::size_t value = 1 + index_if<Pred, pack<Ts...>>::value;
int
from a predicate, but it should probably still work.
int
is a Logical
.
static_cast<bool>
s around.
I should probably have a sort prove it's not using the default predicate.
What do you mean?
Would using 'tuple_c' in all of that be okay?
It would, but I'd rather you leave it like it is, since tuple_c
might go at some point. Since it's already written with make_tuple
, there's little benefit to removing it.
tuple_c
and tuple_t
are really convenient and make for more concise, readable code, although I guess I can't see many practical use cases for tuple_c
. I did see it used sparingly in other tests, which is why I didn't completely avoid using it. I definitely hope you keep tuple_t
and range_c
though.