Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 31 2019 15:06

    ldionne on gh-pages

    Update benchmarks to 490dbf6 fo… (compare)

  • Jan 24 2019 07:47

    ldionne on gh-pages

    Update benchmarks to 490dbf6 fo… (compare)

  • Jan 23 2019 02:04
    pthom commented #432
  • Jan 18 2019 12:46

    ldionne on gh-pages

    Update benchmarks to 490dbf6 fo… (compare)

  • Jan 16 2019 22:27
    ricejasonf commented #434
  • Jan 05 2019 06:22
    ricejasonf commented #330
  • Jan 03 2019 11:40

    ldionne on gh-pages

    Update benchmarks to 490dbf6 fo… (compare)

  • Jan 02 2019 00:33
    ricejasonf closed #434
  • Jan 02 2019 00:33
    ricejasonf commented #434
  • Jan 02 2019 00:04
    ricejasonf opened #434
  • Dec 27 2018 13:11

    ldionne on gh-pages

    Update benchmarks to 490dbf6 fo… (compare)

  • Dec 22 2018 11:56
    pthom commented #432
  • Dec 22 2018 11:55
    pthom commented #432
  • Dec 21 2018 15:48
    pthom synchronize #432
  • Dec 21 2018 09:19
    sdebionne opened #433
  • Dec 21 2018 00:08
    ricejasonf commented #432
  • Dec 21 2018 00:03
    ricejasonf commented #432
  • Dec 20 2018 23:36
    pthom commented #432
  • Dec 20 2018 23:36
    pthom commented #432
  • Dec 20 2018 23:13
    ricejasonf commented #432
Jason Rice
@ricejasonf
sorry, but I think you just didn't fix the name shadowing correctly
don't use names like result2 and it becomes less confusing
not that i don't do that from time to time
Hoss Ajallooiean
@katetsu
oops
see here please
Jason Rice
@ricejasonf
still says result2 and it is still a variant being passed to at_key
how about auto member_name_var = converter(member_name)
by the time you get to the at_key you should not need the variant anymore
because the information you needed from it was member_name_var.index() which is visited as I
Hoss Ajallooiean
@katetsu
but converter return a variant
Jason Rice
@ricejasonf
yes
Hoss Ajallooiean
@katetsu
Jason Rice
@ricejasonf
            auto& member = boost::hana::at_key(result, I);
            using Member = std::remove_reference_t<decltype(std::get<mp_at_c<Type, I>>(active_member))>
???
the name active_member is incorrect
it is still a variant of compile-time strings
I would think Member would be the type of member unless what you want is MemberName the type of a compile-time string. (which I don't think you want)
in any case the names don't match up
I'd say make the names make sense then go from there
gtg
Hoss Ajallooiean
@katetsu
thnx
how can i get the compile time string from std variant?
Jason Rice
@ricejasonf
it is encoded in the variable's type. you are already getting it mp_at_c<decltype(member_name_var)>
your call to std::get isn't needed
in that line
nor should you need to "remove reference"
err the "remove reference" comment I was looking at the old code in the chat
hana::at_key(result, MemberName{})
Hoss Ajallooiean
@katetsu
i tried that
but still geetting errors
auto& member = boost::hana::at_key(result, mp_at_c<decltype(member_name_var), I>);
I being the index
Jason Rice
@ricejasonf
break that line up
using MemberName = the error will be more obvious
you are passing a type where an expression is expected
Hoss Ajallooiean
@katetsu
exactly
Jason Rice
@ricejasonf
hence MemberName{} <- note the default construction
Hoss Ajallooiean
@katetsu
i see
ok so the default ctor creates the compile time string value?
vs the type is compile type hana string?
Jason Rice
@ricejasonf
same as decltype("timer"_s){}
or hana::string<'t', 'i', 'm', 'e', 'r'>{}
Hoss Ajallooiean
@katetsu
ok got it thanks a lot:)
Hoss Ajallooiean
@katetsu
hi @ricejasonf, do you have any idea what this compiler error means? https://godbolt.org/z/f1MPT3
Jason Rice
@ricejasonf
the key is not in the map
when calling at_key
internally it uses find which returns an optional hence the weird error