Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Aug 17 12:01
    dependabot[bot] closed #1539
  • Aug 17 12:01
    dependabot[bot] labeled #1541
  • Aug 17 12:01
    dependabot[bot] labeled #1541
  • Aug 17 12:01
    dependabot[bot] opened #1541
  • Aug 16 16:36
    notriddle closed #1540
  • Aug 16 10:49
    codebreach opened #1540
  • Aug 15 12:01
    dependabot[bot] labeled #1539
  • Aug 15 12:01
    dependabot[bot] labeled #1539
  • Aug 15 12:01
    dependabot[bot] opened #1539
  • Aug 13 18:01
    notriddle synchronize #177
  • Aug 06 04:50
    bors[bot] closed #1534
  • Aug 04 00:41
    bors[bot] closed #1532
  • Aug 03 02:10
    bors[bot] closed #1538
  • Aug 03 00:08
    jsoref synchronize #1538
  • Aug 03 00:04
    jsoref opened #1538
  • Aug 02 18:58
    jonathan-boudreau-work opened #1537
  • Aug 02 16:15
    bors[bot] closed #1536
  • Aug 02 16:15
    bors[bot] closed #1535
  • Aug 02 15:44
    notriddle opened #1536
  • Aug 02 15:24
    BrianHicks opened #1535
Michael Howell
@notriddle
https://developer.github.com/v3/apps/available-endpoints/ Doesn't list required reviews as an avilable branch endpoint.
It lists status checks. Ugh.
@khodzha: GitHub just enabled the required_pull_request_reviews endpoint for Apps.
Tristan Seligmann
@mithrandi
Hrm, if I approve a PR that modifies bors.toml, bors will still be using the bors.toml on master for that build, right?
Michael Howell
@notriddle
No.
bors uses the bors.toml file in the staging branch to figure out which CI systems to use.
It also uses the bors.toml from the PR branch itself to figure out things like blocking labels.
Tristan Seligmann
@mithrandi
Ah, thanks.
Tristan Seligmann
@mithrandi
So I got "Merge conflict (retrying...)" on a batch, and now all the PRs are split into two batches that are "Waiting to run" forever it seems.
image.png

The history tab has a bit of a weird ordering:

17/11/2017, 10:16:12 Batch Failed #117 #104 #116 #109 #110 #108
17/11/2017, 10:16:03 Batch Waiting to run #109 #110 #108
17/11/2017, 10:16:02 Batch Waiting to run #117 #104 #116

Tristan Seligmann
@mithrandi
I'm going to leave everything as-is since I'm not in a rush but I'm not sure where to start debugging.
Tristan Seligmann
@mithrandi
Oh, I guess it is actually doing something since it found another merge conflict. Weird.
Tristan Seligmann
@mithrandi
So I guess "Waiting to run" is inaccurate?
Tristan Seligmann
@mithrandi
Or there's just a much bigger delay, hmm.
Michael Howell
@notriddle
@mithrandi You're still using a version of bors-ng that doesn't add a=AUTHOR_NAME to the merge commits.
That feature was added in August.
Michael Howell
@notriddle
You're a bit out-of-date.
Michael Howell
@notriddle
bors-ng/bors-ng#307 probably fixed your problem.
Michael Howell
@notriddle
... or not. Now that I test it, it apparently still waits a half-hour after bisecting every time.
Tristan Seligmann
@mithrandi
I updated just before I ran into that issue, FWIW.
Michael Howell
@notriddle
I see that, yeah. Your latest commits do have the author info in them...
Tristan Seligmann
@mithrandi
Still need to figure out how to build this Docker container in a better way.
Currently I need to supply all my config env vars at build time as well because it seems doing a prod build fails to load the config modules otherwise, but that's obviously problematic for being able to distribute the image.
Step 10/15 : RUN mix local.hex --force && mix local.rebar --force
 ---> Running in 198b9e1d4eec                                       
** (Mix.Config.LoadError) could not load config apps/bors_github/config/prod.secret.exs
    ** (ArgumentError) argument error 
    :erlang.binary_to_integer(nil)                                           
    (stdlib) erl_eval.erl:670: :erl_eval.do_apply/6
Michael Howell
@notriddle
Probably need to switch off of hard coding getenv lines in the config file.
Instead, it needs to be changed to use a thing like Phoenix does, where you put a {:system, "NAME"} tuple in and it resolves it at runtime.
Pascal Hertleif
@killercup
i think a failed ci build -> r- -> r+ confused bors a bit: killercup/wasm-experiments#9 at least it seems to still be "running" a while after the staging ci build succeeded i'm just too stupid to copypasta the correct config, this one had appveyor in it which wasn't active for the repo
Michael Howell
@notriddle
@killercup no problem
msiglreith
@msiglreith
sup, we migrated a project from kvark/portability to gfx-rs/portability but apparently lost bors in the process (not responding in the new repository) similar to bors-ng/bors-ng#291 . Will reinstalling be enough? (I'm hesitating to avoid break running merges)
msiglreith
@msiglreith
reinstalling worked! (:
Michael Howell
@notriddle
Reinstalling it should be fine, but all of your running merges will simply have stopped.
Ghost
@ghost~529c6c8ded5ab0b3bf04d947
hello!
I'm a big fan of bors, got it installed in two places already, with two more in mind
one thing that is currently missing is the ability to squash merges, especially on OSS project, it is some times difficult to ask contributors to keep a clean history
or when there is a single commit in the PR, it would be nice if bors was able to detect that and act accordingly
Ghost
@ghost~529c6c8ded5ab0b3bf04d947
anyways, I'm looking into implementing bors-ng/bors-ng#194
it seems like there are a few possible variations so it would be nice to discuss what we want
Michael Howell
@notriddle
If I were you, I'd try to implement the version that you want.
At least that way, you know at least one person is going to find it useful.
Ghost
@ghost~529c6c8ded5ab0b3bf04d947
sounds good
do you have any pointers of where I should look at in the code?
I found Bors.Command to process the comments
this probably needs some extension to allow to specify the merge strategy
Michael Howell
@notriddle
Yes, that's where the commands get parsed and dispatched.
Ghost
@ghost~529c6c8ded5ab0b3bf04d947
probably this means extending the DB schema a bit with the additional parameter
Michael Howell
@notriddle
Are you sure you don't want it in the config file? To have it always squash-and-merge?
Ghost
@ghost~529c6c8ded5ab0b3bf04d947
I also want to add a bors.toml extension for the default merge strategy