Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 22 2018 14:10
    briancavalier commented #181
  • Aug 22 2018 14:03
    joshburgess commented #181
  • Aug 09 2018 11:26
    briancavalier commented #181
  • Aug 07 2018 19:43
    joshburgess opened #181
  • May 29 2018 11:36
    briancavalier edited #179
  • May 29 2018 11:36
    briancavalier edited #179
  • May 29 2018 11:36
    briancavalier commented #178
  • May 29 2018 11:36
    coveralls commented #180
  • May 29 2018 11:36
    coveralls commented #180
  • May 29 2018 11:36
    coveralls commented #180
  • May 29 2018 11:34
    briancavalier opened #180
  • May 29 2018 11:32

    briancavalier on reorg-api-docs-es-aplus

    Move then and resolve to intero… (compare)

  • May 11 2018 01:01
    briancavalier commented #178
  • May 11 2018 01:00
    briancavalier edited #179
  • May 11 2018 01:00
    briancavalier opened #179
  • May 11 2018 00:40
    briancavalier commented #178
  • May 10 2018 03:31
    dmitriz commented #178
  • May 09 2018 05:08
    dmitriz commented #178
  • May 09 2018 05:01
    dmitriz commented #178
  • May 09 2018 05:00
    dmitriz commented #178
Brian Cavalier
@briancavalier
I also thought about trying to merge the source maps created at each step … there’s a tool that claims to do it, but I didn’t try
in an ideal world, what we’d end up with is a coverage report that shows coverage holes on the original es6 source code
Bergi
@bergus
Ah, if that was possible I'd love to have it… Though if we distribute ES5 code, I'm perfectly fine with coverage reports on that
Brian Cavalier
@briancavalier
I’ve gotten it to work in babel projects at my day job using isparta instead of istanbul, but not sure yet how to do it with buble (it generates source maps, tho, so it’s probably possible)
Brian Cavalier
@briancavalier
ok, back to cleaning up the build for a sec
sounds like the plan is: clean up the dist build to use buble rollup plugin to do away with the build/ dir
David Chase
@davidchase
:+1:
Bergi
@bergus
…and Buba for testing and coverage, right? Sounds good :+1:
Brian Cavalier
@briancavalier
yep!
Brian Cavalier
@briancavalier
#22
lmkwyt
David Chase
@davidchase
Looks great
Brian Cavalier
@briancavalier
cuts down on all the npm run gymnastics, too
Bergi
@bergus
400 lines of documentation!
Brian Cavalier
@briancavalier
wow :) lots to read
Bergi
@bergus
Now as https://github.com/briancavalier/creed/pull/21/commits/b1ad38434c45144fa42581919f067d1ada4c383b (I forgot to git add before git commit --amending and didn't push the fixes :-/)
Brian Cavalier
@briancavalier
prolly gonna release current master, with the new build tooling, as 1.0.2 (no API change or bug fix, so patch-level bump seems fine). It’s such a nice perf boost
Brian Cavalier
@briancavalier
about to publish 1.0.2 as soon as travis says ok … updated the perf results for 1.0.2 and node 6.3, and updated versions of all the other perf test libs:
creed does extremely well now
another interesting thing is how well async 2.0 does
David Chase
@davidchase
thats awesome
is async 2.0 still a huge file size?
Brian Cavalier
@briancavalier
no idea, I didn’t even know 2.0 had been released :)
David Chase
@davidchase
there minified is about ~7.6 - 8kb
Brian Cavalier
@briancavalier
-rw-r--r--  1 brian  staff    7489 Jul 15 10:06 async.min.js.gz
what size was 1.x?
David Chase
@davidchase
according to cdnjs it was 2.4kb ?
minified
version 1.22
then 1.5.2 was 5kb minified
Brian Cavalier
@briancavalier
is that min+gzip or just min?
because just minified, async 2.0 is 20k
-rw-r--r--  1 brian  staff   3825 Jul 15 09:39 creed.min.js.gz
David Chase
@davidchase
i think its gzip as well im looking at the network panel from cdnjs
Brian Cavalier
@briancavalier
ok
yeah, I can’t imagine it was 2.4k min-only and ballooned 10x to 20k min-only
David Chase
@davidchase
yeah i think it was an old version
David Chase
@davidchase
:clap: thats awesome
Bergi
@bergus
Regarding greenkeeper: as there are no pull requests open, wouldn't that mean that there should not be any greenkeeper-xy branches either? At least that's how I understood greenkeeperio/greenkeeper#120. I don't think you need to delete them manually. Can you investigate that? Maybe its a workflow thing, a bug, or just a config issue.
Brian Cavalier
@briancavalier
Yeah, I dunno … there shouldn’t be any greenkeeper config needed to get the default behavior. Seems like probably a bug
Bergi
@bergus
Did you report it already? Should I do (I don't know much about what you did to enable GK)?
Brian Cavalier
@briancavalier
Not yet, but will do it tonight, when I get back to my laptop
Bergi
@bergus
:+1:
Brian Cavalier
@briancavalier
It looks like we may have to change creed’s travis config
greenkeeperio/greenkeeper#221
but it’s still not totally clear to me if that’s what’s going on
but looking at the OP’s PR to his own project, it certainly looks like we could just do the same thing: BenoitAverty/reactive-goban@ec61edb