Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 28 2019 05:59

    brunchboy on master

    Update change log. (compare)

  • Dec 27 2019 20:01

    brunchboy on master

    Update license to version 2.0 o… (compare)

  • Dec 27 2019 06:33

    brunchboy on master

    Add contribution guide and code… (compare)

  • Nov 03 2019 20:26

    brunchboy on master

    Turn off broken "Edit this Page… (compare)

  • Oct 01 2019 22:12

    brunchboy on master

    Add antora and netlify credits … (compare)

  • Sep 08 2019 16:14

    brunchboy on master

    Update other dependencies. (compare)

  • Sep 08 2019 16:04

    brunchboy on master

    Update CoreMidi4J. (compare)

  • Jun 11 2019 03:19

    brunchboy on master

    Update to link to netlify hoste… (compare)

  • Jun 11 2019 03:01

    brunchboy on master

    Update doc readme to reflect us… (compare)

  • Jun 10 2019 21:40

    brunchboy on master

    Fix typo in function name. (compare)

  • Jun 10 2019 21:18

    brunchboy on master

    Remove insecure HTTP link, than… Try simplifying API doc path, u… (compare)

  • Jun 10 2019 20:48

    brunchboy on master

    Working on netlify doc build. (compare)

  • Jun 10 2019 20:27

    brunchboy on master

    Update Clojure version. Update Codox version. Try setting up Netlify build fo… (compare)

  • May 27 2019 18:14
    brunchboy edited #70
  • May 27 2019 18:12
    brunchboy edited #70
  • May 27 2019 18:12
    brunchboy labeled #70
  • May 27 2019 18:12
    brunchboy opened #70
  • May 22 2019 05:21
    brunchboy closed #69
  • May 22 2019 05:21

    brunchboy on master

    Update jquery.mincolors color p… Start wedding reception show. (compare)

  • May 22 2019 01:44
    brunchboy opened #69
James Elliott
@brunchboy
Line 88 of launchpad_mk2.clj.
Change 24 10 led to 24 11 led.
Benjamin Gudehus
@hastebrot
Done. And now I have to reload my file into the REPL?
James Elliott
@brunchboy
Just that function
(the whole file should be harmless, but if you can find the key for just the function, that is safest)
Benjamin Gudehus
@hastebrot
Hmm, so I just call mk/set-pad-color and it will automatically use the changed source code?
James Elliott
@brunchboy
Correct.
REPL-based development is awesome like that.
(If you have reloaded that function.)
There must be a command in Cursive for that.
Benjamin Gudehus
@hastebrot
Sync files in REPL (Ctrl-Shift-M)
Whoa!
Now it is correct.
James Elliott
@brunchboy
Syncing all the files is way overkill, I still am trying to find how you could have just evaluated that one form, but EXCELLENT.
I will let the person at Novation I am working with about this error in the manual!
How strange that it was doing anything at all with the wrong SysEx prefix.
Benjamin Gudehus
@hastebrot
Loading src/afterglow/controllers/launchpad_mk2.clj... done
Cursive intelligently knows which files were changed.
James Elliott
@brunchboy
The reason I want to do just the function, not the whole file, is that sometimes protocols get redefined, which causes incompatibilities with things that were created before reloading the file.
In this case that did not happen, but in other parts of Afterglow, it does cause issues.
Benjamin Gudehus
@hastebrot
Ahh, ok.
James Elliott
@brunchboy
(It won’t be an issue when you are in your own project.)
Benjamin Gudehus
@hastebrot
Sample cues are also correct.
James Elliott
@brunchboy
That’s great.
Benjamin Gudehus
@hastebrot
(mk2/deactivate mk2-watcher)
CompilerException clojure.lang.ExceptionInfo: Invariant violation in `afterglow.controllers.launchpad-mk2:564` [pred-form, val]:
 [(#{:launchpad-mk2 :launchpad-mk2-watcher} (type controller)), :launchpad-pro] {:*?data* nil, :elidable? true, :dt #inst "2016-02-12T02:08:55.758-00:00", :val :launchpad-pro, :ns-str "afterglow.controllers.launchpad-mk2", :val-type clojure.lang.Keyword, :?err nil, :*assert* true, :?data nil, :?line 564, :form-str "(#{:launchpad-mk2 :launchpad-mk2-watcher} (type controller))"}, compiling:(/home/benjamin/Sources/clojure/afterglow/test/afterglow/afterglow_sample.clj:16:1)
James Elliott
@brunchboy
I can’t see anything after the first line.
Benjamin Gudehus
@hastebrot
Added the rest.
Don't know if this is caused by (def mk2-controller @(:controller mk2-watcher)).
James Elliott
@brunchboy
I am giving up on fighting Cursive to try to figure out how you can run Tools :arrow_forward: REPL :arrow_forward: Run sexp before cursor
That is the command I wanted you to be able to use, but I will leave Cursive support to a Cursive user. I would suggest you explore Edit :arrow_forward: Structural Editing and Navigate :arrow_forward: Structural Movement when you have time.
What does (type c) give you?
Oh, I see!
Yes, my mistake.
Line 686 needs to be {:type :launchpad-mk2})]
Benjamin Gudehus
@hastebrot

Run sexp before cursor

You mean "Send form before caret to REPL"?

James Elliott
@brunchboy
Ah, sounds good! The page I was looking at was outdated.
So if you had put your cursor after the closing paren of set-pad-color and issued that command, it would have redefined just that function for us.
Benjamin Gudehus
@hastebrot
Ahh!
James Elliott
@brunchboy
Do you want to make a pull request with these two fixes, or shall I just do them locally?
Benjamin Gudehus
@hastebrot
I first thought something like (reload 'afterglow.controllers....set-led-color)..
James Elliott
@brunchboy
Ah, I don’t think Clojure itself offers any way of reloading just part of a file like that. But Cursive and CIDER do.
I’m afraid the easiest way to recover from the fact that I gave your controller the wrong type tag is to shut down and reload the REPL after that line is fixed.
Benjamin Gudehus
@hastebrot
I'll make a PR :)
James Elliott
@brunchboy
Great!
Benjamin Gudehus
@hastebrot
Do you have a contributors guideline? Or I'll just put these changes into two commits in a new branch and create the PR.
James Elliott
@brunchboy
Yeah, this is simple and clear. That sounds like a good approach.
I do not yet have contributor guidelines, but we both know what these are about. In the commit messages say something like “correct error in reference manual” for the first, and “correct copy paste error” for the second.
I have a house full of people practicing LED glove performances, and the pizza has just arrived. An interesting Thursday. :grinning:
Benjamin Gudehus
@hastebrot
Bon appetit!
Benjamin Gudehus
@hastebrot
So PR was send. Have fun and thanks for help. I learnt a lot.