Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 11 03:19

    brunchboy on master

    Update to link to netlify hoste… (compare)

  • Jun 11 03:01

    brunchboy on master

    Update doc readme to reflect us… (compare)

  • Jun 10 21:40

    brunchboy on master

    Fix typo in function name. (compare)

  • Jun 10 21:18

    brunchboy on master

    Remove insecure HTTP link, than… Try simplifying API doc path, u… (compare)

  • Jun 10 20:48

    brunchboy on master

    Working on netlify doc build. (compare)

  • Jun 10 20:27

    brunchboy on master

    Update Clojure version. Update Codox version. Try setting up Netlify build fo… (compare)

  • May 27 18:14
    brunchboy edited #70
  • May 27 18:12
    brunchboy edited #70
  • May 27 18:12
    brunchboy labeled #70
  • May 27 18:12
    brunchboy opened #70
  • May 22 05:21
    brunchboy closed #69
  • May 22 05:21

    brunchboy on master

    Update jquery.mincolors color p… Start wedding reception show. (compare)

  • May 22 01:44
    brunchboy opened #69
  • May 22 01:42
    brunchboy closed #23
  • May 22 01:41
    brunchboy closed #65
  • Apr 29 21:08

    brunchboy on master

    Fix more broken images due to w… (compare)

  • Apr 29 21:03

    brunchboy on master

    Fix more broken images due to w… (compare)

  • Apr 29 20:56

    brunchboy on master

    Try without line break? (Older … (compare)

  • Apr 29 20:53

    brunchboy on master

    Fix image macro with comma in a… (compare)

  • Apr 29 07:07

    brunchboy on master

    Make guide base URL independent… (compare)

Benjamin Gudehus
@hastebrot
Whoa!
Now it is correct.
James Elliott
@brunchboy
Syncing all the files is way overkill, I still am trying to find how you could have just evaluated that one form, but EXCELLENT.
I will let the person at Novation I am working with about this error in the manual!
How strange that it was doing anything at all with the wrong SysEx prefix.
Benjamin Gudehus
@hastebrot
Loading src/afterglow/controllers/launchpad_mk2.clj... done
Cursive intelligently knows which files were changed.
James Elliott
@brunchboy
The reason I want to do just the function, not the whole file, is that sometimes protocols get redefined, which causes incompatibilities with things that were created before reloading the file.
In this case that did not happen, but in other parts of Afterglow, it does cause issues.
Benjamin Gudehus
@hastebrot
Ahh, ok.
James Elliott
@brunchboy
(It won’t be an issue when you are in your own project.)
Benjamin Gudehus
@hastebrot
Sample cues are also correct.
James Elliott
@brunchboy
That’s great.
Benjamin Gudehus
@hastebrot
(mk2/deactivate mk2-watcher)
CompilerException clojure.lang.ExceptionInfo: Invariant violation in `afterglow.controllers.launchpad-mk2:564` [pred-form, val]:
 [(#{:launchpad-mk2 :launchpad-mk2-watcher} (type controller)), :launchpad-pro] {:*?data* nil, :elidable? true, :dt #inst "2016-02-12T02:08:55.758-00:00", :val :launchpad-pro, :ns-str "afterglow.controllers.launchpad-mk2", :val-type clojure.lang.Keyword, :?err nil, :*assert* true, :?data nil, :?line 564, :form-str "(#{:launchpad-mk2 :launchpad-mk2-watcher} (type controller))"}, compiling:(/home/benjamin/Sources/clojure/afterglow/test/afterglow/afterglow_sample.clj:16:1)
James Elliott
@brunchboy
I can’t see anything after the first line.
Benjamin Gudehus
@hastebrot
Added the rest.
Don't know if this is caused by (def mk2-controller @(:controller mk2-watcher)).
James Elliott
@brunchboy
I am giving up on fighting Cursive to try to figure out how you can run Tools :arrow_forward: REPL :arrow_forward: Run sexp before cursor
That is the command I wanted you to be able to use, but I will leave Cursive support to a Cursive user. I would suggest you explore Edit :arrow_forward: Structural Editing and Navigate :arrow_forward: Structural Movement when you have time.
What does (type c) give you?
Oh, I see!
Yes, my mistake.
Line 686 needs to be {:type :launchpad-mk2})]
Benjamin Gudehus
@hastebrot

Run sexp before cursor

You mean "Send form before caret to REPL"?

James Elliott
@brunchboy
Ah, sounds good! The page I was looking at was outdated.
So if you had put your cursor after the closing paren of set-pad-color and issued that command, it would have redefined just that function for us.
Benjamin Gudehus
@hastebrot
Ahh!
James Elliott
@brunchboy
Do you want to make a pull request with these two fixes, or shall I just do them locally?
Benjamin Gudehus
@hastebrot
I first thought something like (reload 'afterglow.controllers....set-led-color)..
James Elliott
@brunchboy
Ah, I don’t think Clojure itself offers any way of reloading just part of a file like that. But Cursive and CIDER do.
I’m afraid the easiest way to recover from the fact that I gave your controller the wrong type tag is to shut down and reload the REPL after that line is fixed.
Benjamin Gudehus
@hastebrot
I'll make a PR :)
James Elliott
@brunchboy
Great!
Benjamin Gudehus
@hastebrot
Do you have a contributors guideline? Or I'll just put these changes into two commits in a new branch and create the PR.
James Elliott
@brunchboy
Yeah, this is simple and clear. That sounds like a good approach.
I do not yet have contributor guidelines, but we both know what these are about. In the commit messages say something like “correct error in reference manual” for the first, and “correct copy paste error” for the second.
I have a house full of people practicing LED glove performances, and the pizza has just arrived. An interesting Thursday. :grinning:
Benjamin Gudehus
@hastebrot
Bon appetit!
Benjamin Gudehus
@hastebrot
So PR was send. Have fun and thanks for help. I learnt a lot.
James Elliott
@brunchboy
I just merged it! Thank you for helping figure this out. I’ll be happy to continue to help as you explore other areas of Afterglow. I am also happy to see how well it seems to work in Linux.
I will look at photos of the Mk2 and think about where to move the non-arrow round buttons. If you have any thoughts, please let me know. The are the tap-tempo, shift, stop (starts and stops sending DMX for the show) and user-mode buttons (suspends the mapping to let you switch between it and Ableton Live).
James Elliott
@brunchboy
Ok, having found a photo of the Mk2, I have moved some round buttons around. Other than the arrows, the only button active along the top is now the User 2 button, which suspends and reactivates the mapping. There was not a great place to put Click (Tap Tempo) or Shift, so I have made Volume be Tap Tempo, and Pan be Shift. Stop has moved to the button which is actually labeled Stop.
Since I can’t actually test these things, I am a bit nervous about having broken something. If you have a chance to pull the latest code and give it a try, I would appreciate it!
James Elliott
@brunchboy
I guess I should mention @hastebrot to increase the chances of you seeing my question.
James Elliott
@brunchboy
I have moved the buttons again slightly because after studying the Mini and S decals and photos, I can make the Mk2, Mini, and S all use the same round button mapping, and it makes slightly more sense than I described above. When you have time to test, it should be as documented here (follow the link to the photo of the Mini).
Benjamin Gudehus
@hastebrot
I hope to find time this evening to test this out.
James Elliott
@brunchboy
Thanks! There is no hurry, I just wanted to be sure that you someday saw the question.
James Elliott
@brunchboy
I am starting to document and prepare for the next release, so I am going to assume that the Mk2 is working properly unless I hear otherwise in the next few days. Thanks for your help in figuring it out, @hastebrot
James Elliott
@brunchboy
Actually, @hastebrot , I just greatly changed the way all controller bindings work, so that Afterglow figures out what code to call based on the device identification response it gets back from MIDI, and you no longer need to know which namespace to load. I have been able to test it with all the other controllers I support, but I still lack a Launchpad Mk2. If you could test that the new instructions work for you with the latest 0.2.1-SNAPSHOT code in the next few days I would greatly appreciate it.
Benjamin Gudehus
@hastebrot
I'll have a look at it. :) Give me a day.