Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Starmute
@Starmute
@buddhi1980 Will test on Sunday, as I’m away from my machine until then.
Krzysztof Marczak
@buddhi1980
OK
Krzysztof Marczak
@buddhi1980
Mandelbulber 2.13-2 is in Debian SID
Sebastian Jennen
@zebastian
Awesome!
Sebastian Jennen
@zebastian
hey guys, about code "modernization":
the following clang-tidy modernization flags are not yet applied to the code base, as they are arguable:
  • modernize-loop-convert
    --> simplifies loops and may be more optimized
  • modernize-return-braced-init-list
    --> function returns braced initializers instead of qualified constructors --> {22 ,33} instead of QRect(22, 33)
  • modernize-use-auto
    auto type deduction removes declaring types
  • modernize-use-default-member-init
    --> default member init (init moved from initializer list to member init)
  • modernize-use-equals-default
    --> removes default function definition and replaces with default keyword
    To test these flags, just uncomment the specified flags here: https://github.com/buddhi1980/mandelbulber2/blob/master/mandelbulber2/tools/codeStyleCheck.php#L270 and run the script. You will need to have clang-tidy installed and specifiy the paths of RUN_CLANG_TIDY_EXEC_PATH and CLANG_APPLY_BINARY_PATH

IMHO the following are nice:

  • modernize-loop-convert
  • modernize-return-braced-init-list
  • modernize-use-auto
  • modernize-use-equals-default

And this one is worse:

  • modernize-use-default-member-init

What is your opinion?

Krzysztof Marczak
@buddhi1980
I'm sorry for delayed answer. I was away from home for last week. @zebastian I think most of these tidy-up actions can be applied
Sebastian Jennen
@zebastian
OK, will do...
Krzysztof Marczak
@buddhi1980
Today is much to hot for programming. My brain is overheating!
Sebastian Jennen
@zebastian
Sleeping in the basement lately :smile:
Krzysztof Marczak
@buddhi1980
Last week I have been by the lake so I could go to a water very often. But this week I'm in my apartment and is incredibery hot in my room (now is 31 centigrades)
So today my computer is working, but not me. I don't have enough good radiator on my head.
42
@Bux42
Hey
Is it possible yet to use materials on windows with GPU?
Krzysztof Marczak
@buddhi1980
Yes, it is possible, but without texture mapping.
42
@Bux42
So the purple and green?
Krzysztof Marczak
@buddhi1980
Switch to full mode. Combo box is just below Render button. Fast mode is just a shape preview.
Sebastian Jennen
@zebastian
@buddhi1980 what you think about clang-format-5 for tools/* see here: https://github.com/buddhi1980/mandelbulber2/commit/6bb4b9e02f07b3e080f8c895aefde4127e6ccedb#comments
Krzysztof Marczak
@buddhi1980
I will check it after October 22th. Now I'm leaving for one week vacation.
Sebastian Jennen
@zebastian
hey guys, so now:
  • language for german is updated
  • all formula files seem up to date and working / formula opencl files are all compilable
    "Go!" for 2.15 release from my side.
BTW: I am working on new feature for more image channels (diffuse, specular, ...) which will be merged after 2.15 release...
Krzysztof Marczak
@buddhi1980
You will have more translations to do. Tomorrow I'm going to add tooltips for all new functions.
Starmute
@Starmute
There is still needed macOS OpenCL compatibility for 2.15 release.
Krzysztof Marczak
@buddhi1980
@Starmute What doesn't work on macOS?
Starmute
@Starmute
@buddhi1980 OpenCL with discrete GPU is completely broken on my MacBook Pro. Doesn’t even start rendering before the program crashes.
Starmute
@Starmute
On bleeding edge build it crashes when open preferences and also crashes with integrated GPU OpenCL
Krzysztof Marczak
@buddhi1980
Which MacBook Pro do you have?
Starmute
@Starmute
15 inch, 2018, AMD RX 560X
Krzysztof Marczak
@buddhi1980
Starmute
@Starmute
It’s deprecated but you can still use I’m pretty sure
I’m on 10.13
Krzysztof Marczak
@buddhi1980
But when some years ago it was planned to kill OpenCL under MacOS, developers of graphics drivers were not interested to maintain OpenCL compiler and could be a lot of bugs
Even older MacOS versios didn't work well with OpenCL
Can you see any errors in mandelbulber_log.txt when it crashes?
Starmute
@Starmute
Will check in few minutes.
luchansky
@luchansky
there is the log
Krzysztof Marczak
@buddhi1980
Does it happen for every settings? By the way can you attach full log file?
This is strange: CL_KERNEL_WORK_GROUP_SIZE, value = 0
luchansky
@luchansky
Yep all settings, that is full log
Krzysztof Marczak
@buddhi1980
Set log verbosity level to 2. Close the program. Start again. Press render. Send the log file.
Log started form 22nd second
I need date reported from OpenCL at initialization of the program.
*data
Have you tried to delete mandelbulber.ini file and set OpenCL settings once again?
luchansky
@luchansky
Yes I've deleted it and tried
Krzysztof Marczak
@buddhi1980
Thx. I will analyze it.
Krzysztof Marczak
@buddhi1980
Can you generate log from basic mandelbulb? Just start the program and press render.